You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Berenguer Blasi (Jira)" <ji...@apache.org> on 2021/03/24 15:00:00 UTC
[jira] [Comment Edited] (CASSANDRA-16532) Fix flaky
testSkipScrubCorruptedCounterRowWithTool
[ https://issues.apache.org/jira/browse/CASSANDRA-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307713#comment-17307713 ]
Berenguer Blasi edited comment on CASSANDRA-16532 at 3/24/21, 2:59 PM:
-----------------------------------------------------------------------
Ok so the problem probably stems from the fact that {{StandaloneScrubber}} is to be used as a tool. That should be executed in it's own process hence all tidying would complete on exit with no possible races between calls.
I haven't managed to repro locally but with an internal multiplexing tool. The new push seems to solve that problem by using a different KS on each tool call hence there won't be any file races. Can you confirm if you can still repro or if it has been fixed?
Latest review comments pushed + I did trigger a new multiplexing run.
was (Author: bereng):
Ok so the problem probably stems from the fact that {{StandaloneScrubber}} is to be used as a tool. That should be executed in it's own process hence all tidying would complete on exit with no possible races between calls.
I haven't managed to repro locally but with an internal multiplexing tool. The new push seems to solve that problem by using a different KS on each tool call hence there won't be any file races. Can you confirm if you can still repro or if it has been fixed?
> Fix flaky testSkipScrubCorruptedCounterRowWithTool
> --------------------------------------------------
>
> Key: CASSANDRA-16532
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16532
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Berenguer Blasi
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 4.0-rc
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Fix flaky [testSkipScrubCorruptedCounterRowWithTool|https://ci-cassandra.apache.org/job/Cassandra-trunk/365/testReport/junit/org.apache.cassandra.db/ScrubTest/testSkipScrubCorruptedCounterRowWithTool_compression/]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org