[PR] [Improvement-18662][API]Allow creating schedule for offline workflow definition [dolphinscheduler]

["njnu-seafish (via GitHub)" <gi...@apache.org>]

njnu-seafish opened a new pull request, #18663:
URL: https://github.com/apache/dolphinscheduler/pull/18663

   <!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
   
   ## Was this PR generated or assisted by AI?
   
   NO
   
   ## Purpose of the pull request
   
   close #18662 
   
   ## Brief change log
   
   Allow creating schedule for offline workflow definition; 
   Align insertSchedule validation with updateSchedule to allow scheduling offline workflows
   
   ## Verify this pull request
   
   <!--*(Please pick either of the following options)*-->
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   Added unit test.
   
   ## Pull Request Notice
   [Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
   
   If your pull request contains incompatible change, you should also add it to `docs/docs/en/guide/upgrade/incompatible.md`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Improvement-18662][API]Allow creating schedule for offline workflow definition [dolphinscheduler]

["SbloodyS (via GitHub)" <gi...@apache.org>]

SbloodyS closed pull request #18663: [Improvement-18662][API]Allow creating schedule for offline workflow definition
URL: https://github.com/apache/dolphinscheduler/pull/18663


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Improvement-18662][API]Allow creating schedule for offline workflow definition [dolphinscheduler]

["njnu-seafish (via GitHub)" <gi...@apache.org>]

njnu-seafish commented on PR #18663:
URL: https://github.com/apache/dolphinscheduler/pull/18663#issuecomment-5806489536

   > After the offline workflow definition is started regularly, it will trigger the scheduled task, which conflicts with the current logic. Please discuss and reach a consensus before modifying the logic of this block. I'll close this PR for now.
   
   
   Thanks for the review and for closing the PR.
   
   Let me clarify the design intent so we can align on the right direction.
   
   
   The change only relaxes the check in insertSchedule (create schedule). It does not bypass the guard on going online. The full path is:
   
   insertSchedule persists the schedule with releaseState = OFFLINE and only saves it to DB — no Quartz job is registered, so nothing gets scheduled.
   
   Before a schedule can actually fire, the user must go online it via onlineScheduler → doOnlineScheduler. That path still keeps the workflow-level check:
   
   > if (!ReleaseState.ONLINE.equals(workflowDefinition.getReleaseState())) {
   >     throw new ServiceException(Status.WORKFLOW_DEFINITION_NOT_RELEASE, workflowDefinition.getName());
   > }
   
   So an offline workflow definition can never have its schedule online and trigger execution.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org