[GitHub] viirya commented on a change in pull request #23369: [SPARK-26429][SS]add jdbc sink for Structured Streaming.

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #23369: [SPARK-26429][SS]add jdbc sink for Structured Streaming.
URL: https://github.com/apache/spark/pull/23369#discussion_r244636166
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcSourceProvider.scala
 ##########
 @@ -17,12 +17,20 @@
 
 package org.apache.spark.sql.execution.datasources.jdbc
 
+import scala.collection.JavaConverters._
+
 import org.apache.spark.sql.{AnalysisException, DataFrame, SaveMode, SQLContext}
 import org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils._
 import org.apache.spark.sql.sources.{BaseRelation, CreatableRelationProvider, DataSourceRegister, RelationProvider}
+import org.apache.spark.sql.sources.v2.{DataSourceOptions, StreamingWriteSupportProvider}
+import org.apache.spark.sql.sources.v2.writer.streaming.StreamingWriteSupport
+import org.apache.spark.sql.streaming.OutputMode
+import org.apache.spark.sql.types.StructType
 
-class JdbcRelationProvider extends CreatableRelationProvider
-  with RelationProvider with DataSourceRegister {
+class JdbcSourceProvider extends CreatableRelationProvider
 
 Review comment:
   Although it is rare case, but it's still possible that if you use full classname then this will break it. Anyway, I don't see strong reason to support this renaming. You can see others' opinions too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org