You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/10/20 13:55:07 UTC

[GitHub] [nifi] markap14 commented on a diff in pull request #6557: NIFI-10668 Persist proxy password in remote process group

markap14 commented on code in PR #6557:
URL: https://github.com/apache/nifi/pull/6557#discussion_r1000666325


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/registry/flow/mapping/NiFiRegistryFlowMapper.java:
##########
@@ -782,6 +782,7 @@ public VersionedRemoteProcessGroup mapRemoteProcessGroup(final RemoteProcessGrou
         rpg.setProxyHost(remoteGroup.getProxyHost());
         rpg.setProxyPort(remoteGroup.getProxyPort());
         rpg.setProxyUser(remoteGroup.getProxyUser());
+        rpg.setProxyPassword(encrypt(remoteGroup.getProxyPassword()));

Review Comment:
   This will always include the proxy password, which we don't want. We only want to include the proxy password if `flowMappingOptions.isMapSensitiveConfiguration()` is true. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org