You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/28 16:09:22 UTC

[GitHub] [spark] attilapiros commented on issue #24235: [SPARK-27301][Dstream]Shorten the FileSystem cached life cycle to the cleanup method inner scope

attilapiros commented on issue #24235: [SPARK-27301][Dstream]Shorten the FileSystem cached life cycle to the cleanup method inner scope
URL: https://github.com/apache/spark/pull/24235#issuecomment-477663119
 
 
   What I wanted to point out is if you get an already cached instance from `FileSystem#get` where the renewal of token is also missing you run into the same problem. 
   
   I would like to understand the problem well before I would say this solution is fine.
   
   So could you please answer all my questions? Most importantly:
   
   > I assume you get the original error from a long running test, have you tested this change as well with the same long running test?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org