You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/07/28 10:40:55 UTC
[GitHub] [nifi] kotarot commented on a change in pull request #4943: NIFI-5886: Add RPM profile for NiFi Toolkit
kotarot commented on a change in pull request #4943:
URL: https://github.com/apache/nifi/pull/4943#discussion_r678170058
##########
File path: nifi-toolkit/nifi-toolkit-assembly/pom.xml
##########
@@ -308,5 +308,135 @@ language governing permissions and limitations under the License. -->
</plugins>
</build>
</profile>
+ <profile>
+ <id>rpm</id>
+ <activation>
+ <activeByDefault>false</activeByDefault>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>unpack-shared-resources</id>
+ <goals>
+ <goal>unpack-dependencies</goal>
+ </goals>
+ <phase>generate-resources</phase>
+ <configuration>
+ <outputDirectory>${project.build.directory}/generated-resources</outputDirectory>
+ <includeArtifactIds>nifi-resources</includeArtifactIds>
+ <includeGroupIds>org.apache.nifi</includeGroupIds>
+ <excludeTransitive>false</excludeTransitive>
+ </configuration>
+ </execution>
+ <execution>
+ <id>unpack-docs</id>
+ <goals>
+ <goal>unpack-dependencies</goal>
+ </goals>
+ <phase>generate-resources</phase>
+ <configuration>
+ <outputDirectory>${project.build.directory}/generated-docs</outputDirectory>
+ <includeArtifactIds>nifi-docs</includeArtifactIds>
+ <includeGroupIds>org.apache.nifi</includeGroupIds>
+ <excludeTransitive>false</excludeTransitive>
+ <excludes>LICENSE,NOTICE</excludes>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>rpm-maven-plugin</artifactId>
+ <configuration>
+ <name>nifi-toolkit</name>
+ <summary>Apache NiFi Toolkit</summary>
+ <description>Apache NiFi Toolkit</description>
Review comment:
The description should be more detailed like [nifi-registry](https://github.com/apache/nifi/blob/2daac5714a6050dd872522ff74d7fe71f700db6e/nifi-registry/nifi-registry-assembly/pom.xml#L283).
My suggestion:
```
The NiFi Toolkit contains several command line utilities to setup and support NiFi in standalone and clustered environments.
```
from [Apache NiFi Toolkit Guide](https://nifi.apache.org/docs/nifi-docs/html/toolkit-guide.html).
##########
File path: nifi-toolkit/nifi-toolkit-assembly/pom.xml
##########
@@ -308,5 +308,135 @@ language governing permissions and limitations under the License. -->
</plugins>
</build>
</profile>
+ <profile>
+ <id>rpm</id>
+ <activation>
+ <activeByDefault>false</activeByDefault>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>unpack-shared-resources</id>
+ <goals>
+ <goal>unpack-dependencies</goal>
+ </goals>
+ <phase>generate-resources</phase>
+ <configuration>
+ <outputDirectory>${project.build.directory}/generated-resources</outputDirectory>
+ <includeArtifactIds>nifi-resources</includeArtifactIds>
+ <includeGroupIds>org.apache.nifi</includeGroupIds>
+ <excludeTransitive>false</excludeTransitive>
+ </configuration>
+ </execution>
+ <execution>
+ <id>unpack-docs</id>
+ <goals>
+ <goal>unpack-dependencies</goal>
+ </goals>
+ <phase>generate-resources</phase>
+ <configuration>
+ <outputDirectory>${project.build.directory}/generated-docs</outputDirectory>
+ <includeArtifactIds>nifi-docs</includeArtifactIds>
+ <includeGroupIds>org.apache.nifi</includeGroupIds>
+ <excludeTransitive>false</excludeTransitive>
+ <excludes>LICENSE,NOTICE</excludes>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
Review comment:
We don't need this `maven-dependency-plugin` here, because we don't have `nifi-resources` or `nifi-docs` under the `nifi-toolkit`.
##########
File path: nifi-toolkit/nifi-toolkit-assembly/pom.xml
##########
@@ -308,5 +308,135 @@ language governing permissions and limitations under the License. -->
</plugins>
</build>
</profile>
+ <profile>
+ <id>rpm</id>
+ <activation>
+ <activeByDefault>false</activeByDefault>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>unpack-shared-resources</id>
+ <goals>
+ <goal>unpack-dependencies</goal>
+ </goals>
+ <phase>generate-resources</phase>
+ <configuration>
+ <outputDirectory>${project.build.directory}/generated-resources</outputDirectory>
+ <includeArtifactIds>nifi-resources</includeArtifactIds>
+ <includeGroupIds>org.apache.nifi</includeGroupIds>
+ <excludeTransitive>false</excludeTransitive>
+ </configuration>
+ </execution>
+ <execution>
+ <id>unpack-docs</id>
+ <goals>
+ <goal>unpack-dependencies</goal>
+ </goals>
+ <phase>generate-resources</phase>
+ <configuration>
+ <outputDirectory>${project.build.directory}/generated-docs</outputDirectory>
+ <includeArtifactIds>nifi-docs</includeArtifactIds>
+ <includeGroupIds>org.apache.nifi</includeGroupIds>
+ <excludeTransitive>false</excludeTransitive>
+ <excludes>LICENSE,NOTICE</excludes>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>rpm-maven-plugin</artifactId>
+ <configuration>
+ <name>nifi-toolkit</name>
+ <summary>Apache NiFi Toolkit</summary>
+ <description>Apache NiFi Toolkit</description>
+ <license>Apache License, Version 2.0 and others (see included LICENSE file)</license>
+ <url>http://nifi.apache.org</url>
Review comment:
My suggestion:
```suggestion
<url>https://nifi.apache.org/docs/nifi-docs/html/toolkit-guide.html</url>
```
like (nifi-registry)[https://github.com/apache/nifi/blob/2daac5714a6050dd872522ff74d7fe71f700db6e/nifi-registry/nifi-registry-assembly/pom.xml#L285].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org