You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Phil Steitz <ph...@gmail.com> on 2011/05/14 18:44:37 UTC
Re: svn commit: r1103145 - /commons/proper/net/trunk/pom.xml
On 5/14/11 9:09 AM, sebb@apache.org wrote:
> Author: sebb
> Date: Sat May 14 16:09:22 2011
> New Revision: 1103145
>
> URL: http://svn.apache.org/viewvc?rev=1103145&view=rev
> Log:
> Archives for 3.0 were created with -bin suffix (so add -bin not bin!)
huh? Can you explain what is going on here?
Phil
> Modified:
> commons/proper/net/trunk/pom.xml
>
> Modified: commons/proper/net/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/pom.xml?rev=1103145&r1=1103144&r2=1103145&view=diff
> ==============================================================================
> --- commons/proper/net/trunk/pom.xml (original)
> +++ commons/proper/net/trunk/pom.xml Sat May 14 16:09:22 2011
> @@ -127,7 +127,7 @@ Supported protocols include: Echo, Finge
> <commons.componentid>net</commons.componentid>
> <commons.release.version>3.0</commons.release.version>
> <commons.rc.version>RC1</commons.rc.version>
> - <commons.binary.suffix>bin</commons.binary.suffix>
> + <commons.binary.suffix>-bin</commons.binary.suffix>
> <commons.release.desc>(Requires Java 1.5 or later)</commons.release.desc>
> <commons.release.2.version>1.4.1</commons.release.2.version>
> <commons.release.2.binary.suffix />
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1103145 - /commons/proper/net/trunk/pom.xml
Posted by sebb <se...@gmail.com>.
On 16 May 2011 00:23, Niall Pemberton <ni...@gmail.com> wrote:
> On Sun, May 15, 2011 at 11:50 PM, Phil Steitz <ph...@gmail.com> wrote:
>> On 5/15/11 2:40 PM, sebb wrote:
>>> On 14 May 2011 17:44, Phil Steitz <ph...@gmail.com> wrote:
>>>> On 5/14/11 9:09 AM, sebb@apache.org wrote:
>>>>> Author: sebb
>>>>> Date: Sat May 14 16:09:22 2011
>>>>> New Revision: 1103145
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=1103145&view=rev
>>>>> Log:
>>>>> Archives for 3.0 were created with -bin suffix (so add -bin not bin!)
>>>> huh? Can you explain what is going on here?
>>> See my other posting:
>>>
>>> http://markmail.org/message/f4jjmhlp3ob66hlm
>>>
>>> This is needed to correct the download page so it agrees with the archives.
>>
>> I saw the other post, which said we should use "bin", which you
>> initially did. What I don't get is why you changed it to "-bin" below?
>>
>> This, btw, is yet another thing pushing me ever closer to start
>> throwing grenades of the s/maven/ant variety ;)
>
> I think its just Sebb's mistake. You don't have to set the suffix if
> you're using the maven defaults. The correct thing would be to remove
> those from the commons-net pom.
I thought it was my mistake originally too, but as far as I can tell
there's no way to remove the -bin suffix - please see the thread:
http://markmail.org/message/f4jjmhlp3ob66hlm
I added the -bin to the pom in order to ensure that the generated
download.xml agrees with the artifacts as generated from the 3.0 RC1
tag and already voted on.
Yes, I could have renamed the archives, and waited for the mirrors
again, but they had already been published, so I thought it was better
to just fix the download page to agree with the archive names.
I was unable to generate the binary archives without the -bin suffix
except by reverting to assembly 2.2-beta5 and using an empty <id></id>
in the assembly desc.
However according to the Maven docs (referenced in my e-mail) this has
always been an error - but only reported and detected in assembly
2.2.
So I don't think we should continue to rely on that work-round.
As it stands, Net trunk now corresponds with the generated download
page, and should continue to do so for future releases.
I don't care if the binary archive has a -bin suffix or not (though I
think the majority of components currently do), so long as:
- the download page has the correct link
- the binary archive can be distinguished from the source archive
(i.e. the source archive must have a suffix if the binary archive does
not).
I was not able to achieve those goals except by changing the pom as I did.
If anyone can work out how to drop the -bin from the binary archives,
please advise.
Again, please see:
http://markmail.org/message/f4jjmhlp3ob66hlm
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1103145 - /commons/proper/net/trunk/pom.xml
Posted by Niall Pemberton <ni...@gmail.com>.
On Sun, May 15, 2011 at 11:50 PM, Phil Steitz <ph...@gmail.com> wrote:
> On 5/15/11 2:40 PM, sebb wrote:
>> On 14 May 2011 17:44, Phil Steitz <ph...@gmail.com> wrote:
>>> On 5/14/11 9:09 AM, sebb@apache.org wrote:
>>>> Author: sebb
>>>> Date: Sat May 14 16:09:22 2011
>>>> New Revision: 1103145
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1103145&view=rev
>>>> Log:
>>>> Archives for 3.0 were created with -bin suffix (so add -bin not bin!)
>>> huh? Can you explain what is going on here?
>> See my other posting:
>>
>> http://markmail.org/message/f4jjmhlp3ob66hlm
>>
>> This is needed to correct the download page so it agrees with the archives.
>
> I saw the other post, which said we should use "bin", which you
> initially did. What I don't get is why you changed it to "-bin" below?
>
> This, btw, is yet another thing pushing me ever closer to start
> throwing grenades of the s/maven/ant variety ;)
I think its just Sebb's mistake. You don't have to set the suffix if
you're using the maven defaults. The correct thing would be to remove
those from the commons-net pom.
Niall
> Phil
>>
>>
>>> Phil
>>>> Modified:
>>>> commons/proper/net/trunk/pom.xml
>>>>
>>>> Modified: commons/proper/net/trunk/pom.xml
>>>> URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/pom.xml?rev=1103145&r1=1103144&r2=1103145&view=diff
>>>> ==============================================================================
>>>> --- commons/proper/net/trunk/pom.xml (original)
>>>> +++ commons/proper/net/trunk/pom.xml Sat May 14 16:09:22 2011
>>>> @@ -127,7 +127,7 @@ Supported protocols include: Echo, Finge
>>>> <commons.componentid>net</commons.componentid>
>>>> <commons.release.version>3.0</commons.release.version>
>>>> <commons.rc.version>RC1</commons.rc.version>
>>>> - <commons.binary.suffix>bin</commons.binary.suffix>
>>>> + <commons.binary.suffix>-bin</commons.binary.suffix>
>>>> <commons.release.desc>(Requires Java 1.5 or later)</commons.release.desc>
>>>> <commons.release.2.version>1.4.1</commons.release.2.version>
>>>> <commons.release.2.binary.suffix />
>>>>
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1103145 - /commons/proper/net/trunk/pom.xml
Posted by Phil Steitz <ph...@gmail.com>.
On 5/15/11 2:40 PM, sebb wrote:
> On 14 May 2011 17:44, Phil Steitz <ph...@gmail.com> wrote:
>> On 5/14/11 9:09 AM, sebb@apache.org wrote:
>>> Author: sebb
>>> Date: Sat May 14 16:09:22 2011
>>> New Revision: 1103145
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1103145&view=rev
>>> Log:
>>> Archives for 3.0 were created with -bin suffix (so add -bin not bin!)
>> huh? Can you explain what is going on here?
> See my other posting:
>
> http://markmail.org/message/f4jjmhlp3ob66hlm
>
> This is needed to correct the download page so it agrees with the archives.
I saw the other post, which said we should use "bin", which you
initially did. What I don't get is why you changed it to "-bin" below?
This, btw, is yet another thing pushing me ever closer to start
throwing grenades of the s/maven/ant variety ;)
Phil
>
>
>> Phil
>>> Modified:
>>> commons/proper/net/trunk/pom.xml
>>>
>>> Modified: commons/proper/net/trunk/pom.xml
>>> URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/pom.xml?rev=1103145&r1=1103144&r2=1103145&view=diff
>>> ==============================================================================
>>> --- commons/proper/net/trunk/pom.xml (original)
>>> +++ commons/proper/net/trunk/pom.xml Sat May 14 16:09:22 2011
>>> @@ -127,7 +127,7 @@ Supported protocols include: Echo, Finge
>>> <commons.componentid>net</commons.componentid>
>>> <commons.release.version>3.0</commons.release.version>
>>> <commons.rc.version>RC1</commons.rc.version>
>>> - <commons.binary.suffix>bin</commons.binary.suffix>
>>> + <commons.binary.suffix>-bin</commons.binary.suffix>
>>> <commons.release.desc>(Requires Java 1.5 or later)</commons.release.desc>
>>> <commons.release.2.version>1.4.1</commons.release.2.version>
>>> <commons.release.2.binary.suffix />
>>>
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1103145 - /commons/proper/net/trunk/pom.xml
Posted by sebb <se...@gmail.com>.
On 14 May 2011 17:44, Phil Steitz <ph...@gmail.com> wrote:
> On 5/14/11 9:09 AM, sebb@apache.org wrote:
>> Author: sebb
>> Date: Sat May 14 16:09:22 2011
>> New Revision: 1103145
>>
>> URL: http://svn.apache.org/viewvc?rev=1103145&view=rev
>> Log:
>> Archives for 3.0 were created with -bin suffix (so add -bin not bin!)
>
> huh? Can you explain what is going on here?
See my other posting:
http://markmail.org/message/f4jjmhlp3ob66hlm
This is needed to correct the download page so it agrees with the archives.
> Phil
>> Modified:
>> commons/proper/net/trunk/pom.xml
>>
>> Modified: commons/proper/net/trunk/pom.xml
>> URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/pom.xml?rev=1103145&r1=1103144&r2=1103145&view=diff
>> ==============================================================================
>> --- commons/proper/net/trunk/pom.xml (original)
>> +++ commons/proper/net/trunk/pom.xml Sat May 14 16:09:22 2011
>> @@ -127,7 +127,7 @@ Supported protocols include: Echo, Finge
>> <commons.componentid>net</commons.componentid>
>> <commons.release.version>3.0</commons.release.version>
>> <commons.rc.version>RC1</commons.rc.version>
>> - <commons.binary.suffix>bin</commons.binary.suffix>
>> + <commons.binary.suffix>-bin</commons.binary.suffix>
>> <commons.release.desc>(Requires Java 1.5 or later)</commons.release.desc>
>> <commons.release.2.version>1.4.1</commons.release.2.version>
>> <commons.release.2.binary.suffix />
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org