You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ja...@apache.org on 2017/05/09 11:00:33 UTC

lucene-solr:solr10644: SOLR-10644: solr.in.sh installed by install script should be writable by solr user

Repository: lucene-solr
Updated Branches:
  refs/heads/solr10644 [created] cfc1571ba


SOLR-10644: solr.in.sh installed by install script should be writable by solr user


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/cfc1571b
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/cfc1571b
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/cfc1571b

Branch: refs/heads/solr10644
Commit: cfc1571bab64c7c619282141c49fc793176f0846
Parents: c9541c2
Author: Jan Høydahl <ja...@apache.org>
Authored: Tue May 9 11:30:40 2017 +0200
Committer: Jan Høydahl <ja...@apache.org>
Committed: Tue May 9 11:30:40 2017 +0200

----------------------------------------------------------------------
 solr/CHANGES.txt                 | 2 ++
 solr/bin/install_solr_service.sh | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/cfc1571b/solr/CHANGES.txt
----------------------------------------------------------------------
diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index 41586ed..d2ce667 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -398,6 +398,8 @@ Other Changes
   was an improvement for the json "arrntv" format, it caused problems for the default json format.
   (James Dyer, reported by Nikita Pchelintsev)
 
+* SOLR-10644: solr.in.sh installed by install script should be writable by solr user (janhoy)
+
 ==================  6.5.1 ==================
 
 Bug Fixes

http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/cfc1571b/solr/bin/install_solr_service.sh
----------------------------------------------------------------------
diff --git a/solr/bin/install_solr_service.sh b/solr/bin/install_solr_service.sh
index f42dd5a..54b62e5 100755
--- a/solr/bin/install_solr_service.sh
+++ b/solr/bin/install_solr_service.sh
@@ -331,8 +331,8 @@ SOLR_LOGS_DIR=\"$SOLR_VAR_DIR/logs\"
 SOLR_PORT=\"$SOLR_PORT\"
 " >> "/etc/default/$SOLR_SERVICE.in.sh"
 fi
-chown root: "/etc/default/$SOLR_SERVICE.in.sh"
-chmod 0644 "/etc/default/$SOLR_SERVICE.in.sh"
+chown ${SOLR_USER}: "/etc/default/$SOLR_SERVICE.in.sh"
+chmod 0660 "/etc/default/$SOLR_SERVICE.in.sh"
 
 # install data directories and files
 mkdir -p "$SOLR_VAR_DIR/data"


Re: lucene-solr:solr10644: SOLR-10644: solr.in.sh installed by install script should be writable by solr user

Posted by Chris Hostetter <ho...@fucit.org>.
NOTE: I'm -0 to this change, see detailed comments in SOLR-10644


: Date: Tue,  9 May 2017 11:00:33 +0000 (UTC)
: From: janhoy@apache.org
: Reply-To: dev@lucene.apache.org
: To: commits@lucene.apache.org
: Subject: lucene-solr:solr10644: SOLR-10644: solr.in.sh installed by install
:     script should be writable by solr user
: 
: Repository: lucene-solr
: Updated Branches:
:   refs/heads/solr10644 [created] cfc1571ba
: 
: 
: SOLR-10644: solr.in.sh installed by install script should be writable by solr user
: 
: 
: Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
: Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/cfc1571b
: Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/cfc1571b
: Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/cfc1571b
: 
: Branch: refs/heads/solr10644
: Commit: cfc1571bab64c7c619282141c49fc793176f0846
: Parents: c9541c2
: Author: Jan H??ydahl <ja...@apache.org>
: Authored: Tue May 9 11:30:40 2017 +0200
: Committer: Jan H??ydahl <ja...@apache.org>
: Committed: Tue May 9 11:30:40 2017 +0200
: 
: ----------------------------------------------------------------------
:  solr/CHANGES.txt                 | 2 ++
:  solr/bin/install_solr_service.sh | 4 ++--
:  2 files changed, 4 insertions(+), 2 deletions(-)
: ----------------------------------------------------------------------
: 
: 
: http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/cfc1571b/solr/CHANGES.txt
: ----------------------------------------------------------------------
: diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
: index 41586ed..d2ce667 100644
: --- a/solr/CHANGES.txt
: +++ b/solr/CHANGES.txt
: @@ -398,6 +398,8 @@ Other Changes
:    was an improvement for the json "arrntv" format, it caused problems for the default json format.
:    (James Dyer, reported by Nikita Pchelintsev)
:  
: +* SOLR-10644: solr.in.sh installed by install script should be writable by solr user (janhoy)
: +
:  ==================  6.5.1 ==================
:  
:  Bug Fixes
: 
: http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/cfc1571b/solr/bin/install_solr_service.sh
: ----------------------------------------------------------------------
: diff --git a/solr/bin/install_solr_service.sh b/solr/bin/install_solr_service.sh
: index f42dd5a..54b62e5 100755
: --- a/solr/bin/install_solr_service.sh
: +++ b/solr/bin/install_solr_service.sh
: @@ -331,8 +331,8 @@ SOLR_LOGS_DIR=\"$SOLR_VAR_DIR/logs\"
:  SOLR_PORT=\"$SOLR_PORT\"
:  " >> "/etc/default/$SOLR_SERVICE.in.sh"
:  fi
: -chown root: "/etc/default/$SOLR_SERVICE.in.sh"
: -chmod 0644 "/etc/default/$SOLR_SERVICE.in.sh"
: +chown ${SOLR_USER}: "/etc/default/$SOLR_SERVICE.in.sh"
: +chmod 0660 "/etc/default/$SOLR_SERVICE.in.sh"
:  
:  # install data directories and files
:  mkdir -p "$SOLR_VAR_DIR/data"
: 
: 

-Hoss
http://www.lucidworks.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org