You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2016/04/16 10:29:34 UTC
Review Request 46298: Rejected relative path agent work_dir.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46298/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Jie Yu.
Bugs: MESOS-5123
https://issues.apache.org/jira/browse/MESOS-5123
Repository: mesos
Description
-------
Rejected relative path agent work_dir.
Diffs
-----
src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86
src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48
Diff: https://reviews.apache.org/r/46298/diff/
Testing
-------
1. make && make check
2. e2e test:
```
$ ./src/mesos-slave --work_dir=aa --master=aa
The required option `--work_dir` must be absolute path.
```
Thanks,
Klaus Ma
Re: Review Request 46298: Rejected relative path agent work_dir.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46298/#review129503
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46298]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 19, 2016, 7:31 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46298/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 7:31 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jie Yu.
>
>
> Bugs: MESOS-5123
> https://issues.apache.org/jira/browse/MESOS-5123
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rejected relative path agent work_dir.
>
>
> Diffs
> -----
>
> src/slave/flags.cpp 10d2974bd2b6e79255fc894979607f0d2d00c315
> src/slave/main.cpp 38bd00584dd9c6a872398678b2288edeed1cd2a4
>
> Diff: https://reviews.apache.org/r/46298/diff/
>
>
> Testing
> -------
>
> 1. make && make check
> 2. e2e test:
>
> ```
> $ ./src/mesos-slave --work_dir=aa --master=aa
> The required option `--work_dir` must be absolute path.
> ```
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 46298: Rejected relative path agent work_dir.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46298/
-----------------------------------------------------------
(Updated April 19, 2016, 3:31 p.m.)
Review request for mesos, Alexander Rukletsov and Jie Yu.
Changes
-------
Address AlexR's comments.
Bugs: MESOS-5123
https://issues.apache.org/jira/browse/MESOS-5123
Repository: mesos
Description
-------
Rejected relative path agent work_dir.
Diffs (updated)
-----
src/slave/flags.cpp 10d2974bd2b6e79255fc894979607f0d2d00c315
src/slave/main.cpp 38bd00584dd9c6a872398678b2288edeed1cd2a4
Diff: https://reviews.apache.org/r/46298/diff/
Testing
-------
1. make && make check
2. e2e test:
```
$ ./src/mesos-slave --work_dir=aa --master=aa
The required option `--work_dir` must be absolute path.
```
Thanks,
Klaus Ma
Re: Review Request 46298: Rejected relative path agent work_dir.
Posted by Klaus Ma <kl...@gmail.com>.
> On April 18, 2016, 5:47 p.m., Alexander Rukletsov wrote:
> > LGTM.
> >
> > Do you want to document somewhere that if docker task will be run on the agent, this path should only contain symbols allowed for docker volumes (that's because we always create a docker volume for task's sandbox). Or do you want to do it in a separate patch?
>
> Klaus Ma wrote:
> I'll submit another patch for that :).
@AlexR, I updated usage out for this in this patch.
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46298/#review129313
-----------------------------------------------------------
On April 19, 2016, 3:31 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46298/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 3:31 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jie Yu.
>
>
> Bugs: MESOS-5123
> https://issues.apache.org/jira/browse/MESOS-5123
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rejected relative path agent work_dir.
>
>
> Diffs
> -----
>
> src/slave/flags.cpp 10d2974bd2b6e79255fc894979607f0d2d00c315
> src/slave/main.cpp 38bd00584dd9c6a872398678b2288edeed1cd2a4
>
> Diff: https://reviews.apache.org/r/46298/diff/
>
>
> Testing
> -------
>
> 1. make && make check
> 2. e2e test:
>
> ```
> $ ./src/mesos-slave --work_dir=aa --master=aa
> The required option `--work_dir` must be absolute path.
> ```
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 46298: Rejected relative path agent work_dir.
Posted by Klaus Ma <kl...@gmail.com>.
> On April 18, 2016, 5:47 p.m., Alexander Rukletsov wrote:
> > LGTM.
> >
> > Do you want to document somewhere that if docker task will be run on the agent, this path should only contain symbols allowed for docker volumes (that's because we always create a docker volume for task's sandbox). Or do you want to do it in a separate patch?
I'll submit another patch for that :).
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46298/#review129313
-----------------------------------------------------------
On April 16, 2016, 4:29 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46298/
> -----------------------------------------------------------
>
> (Updated April 16, 2016, 4:29 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jie Yu.
>
>
> Bugs: MESOS-5123
> https://issues.apache.org/jira/browse/MESOS-5123
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rejected relative path agent work_dir.
>
>
> Diffs
> -----
>
> src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86
> src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48
>
> Diff: https://reviews.apache.org/r/46298/diff/
>
>
> Testing
> -------
>
> 1. make && make check
> 2. e2e test:
>
> ```
> $ ./src/mesos-slave --work_dir=aa --master=aa
> The required option `--work_dir` must be absolute path.
> ```
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 46298: Rejected relative path agent work_dir.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46298/#review129313
-----------------------------------------------------------
LGTM.
Do you want to document somewhere that if docker task will be run on the agent, this path should only contain symbols allowed for docker volumes (that's because we always create a docker volume for task's sandbox). Or do you want to do it in a separate patch?
- Alexander Rukletsov
On April 16, 2016, 8:29 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46298/
> -----------------------------------------------------------
>
> (Updated April 16, 2016, 8:29 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jie Yu.
>
>
> Bugs: MESOS-5123
> https://issues.apache.org/jira/browse/MESOS-5123
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rejected relative path agent work_dir.
>
>
> Diffs
> -----
>
> src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86
> src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48
>
> Diff: https://reviews.apache.org/r/46298/diff/
>
>
> Testing
> -------
>
> 1. make && make check
> 2. e2e test:
>
> ```
> $ ./src/mesos-slave --work_dir=aa --master=aa
> The required option `--work_dir` must be absolute path.
> ```
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 46298: Rejected relative path agent work_dir.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46298/#review129247
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On April 16, 2016, 8:29 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46298/
> -----------------------------------------------------------
>
> (Updated April 16, 2016, 8:29 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jie Yu.
>
>
> Bugs: MESOS-5123
> https://issues.apache.org/jira/browse/MESOS-5123
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rejected relative path agent work_dir.
>
>
> Diffs
> -----
>
> src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86
> src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48
>
> Diff: https://reviews.apache.org/r/46298/diff/
>
>
> Testing
> -------
>
> 1. make && make check
> 2. e2e test:
>
> ```
> $ ./src/mesos-slave --work_dir=aa --master=aa
> The required option `--work_dir` must be absolute path.
> ```
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 46298: Rejected relative path agent work_dir.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46298/#review129243
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46298]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 16, 2016, 8:29 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46298/
> -----------------------------------------------------------
>
> (Updated April 16, 2016, 8:29 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jie Yu.
>
>
> Bugs: MESOS-5123
> https://issues.apache.org/jira/browse/MESOS-5123
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rejected relative path agent work_dir.
>
>
> Diffs
> -----
>
> src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86
> src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48
>
> Diff: https://reviews.apache.org/r/46298/diff/
>
>
> Testing
> -------
>
> 1. make && make check
> 2. e2e test:
>
> ```
> $ ./src/mesos-slave --work_dir=aa --master=aa
> The required option `--work_dir` must be absolute path.
> ```
>
>
> Thanks,
>
> Klaus Ma
>
>