You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2011/02/16 08:38:58 UTC

[jira] Created: (HDFS-1629) Add a method to BlockPlacementPolicy for not removing the chosen nodes

Add a method to BlockPlacementPolicy for not removing the chosen nodes
----------------------------------------------------------------------

                 Key: HDFS-1629
                 URL: https://issues.apache.org/jira/browse/HDFS-1629
             Project: Hadoop HDFS
          Issue Type: Sub-task
            Reporter: Tsz Wo (Nicholas), SZE
            Assignee: Tsz Wo (Nicholas), SZE


{{BlockPlacementPolicy}} supports chosen nodes in some of the {{chooseTarget(..)}} methods.  The chosen nodes will be removed from the output array.  For adding new datanodes to an existing pipeline, it is useful to keep the chosen nodes in the output array.



-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-1629) Add a method to BlockPlacementPolicy for not removing the chosen nodes

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022537#comment-13022537 ] 

Hudson commented on HDFS-1629:
------------------------------

Integrated in Hadoop-Hdfs-trunk #643 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/])
    

> Add a method to BlockPlacementPolicy for not removing the chosen nodes
> ----------------------------------------------------------------------
>
>                 Key: HDFS-1629
>                 URL: https://issues.apache.org/jira/browse/HDFS-1629
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.23.0
>
>         Attachments: h1629_20110216.patch, h1629_20110217.patch
>
>
> {{BlockPlacementPolicy}} supports chosen nodes in some of the {{chooseTarget(..)}} methods.  The chosen nodes will be removed from the output array.  For adding new datanodes to an existing pipeline, it is useful to keep the chosen nodes in the output array.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (HDFS-1629) Add a method to BlockPlacementPolicy for not removing the chosen nodes

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995224#comment-12995224 ] 

Hadoop QA commented on HDFS-1629:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12471163/h1629_20110216.patch
  against trunk revision 1071023.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.hdfs.server.datanode.TestBlockReport
                  org.apache.hadoop.hdfs.server.namenode.TestReplicationPolicy
                  org.apache.hadoop.hdfs.TestFileConcurrentReader

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/166//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/166//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/166//console

This message is automatically generated.

> Add a method to BlockPlacementPolicy for not removing the chosen nodes
> ----------------------------------------------------------------------
>
>                 Key: HDFS-1629
>                 URL: https://issues.apache.org/jira/browse/HDFS-1629
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node, hdfs client
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h1629_20110216.patch
>
>
> {{BlockPlacementPolicy}} supports chosen nodes in some of the {{chooseTarget(..)}} methods.  The chosen nodes will be removed from the output array.  For adding new datanodes to an existing pipeline, it is useful to keep the chosen nodes in the output array.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HDFS-1629) Add a method to BlockPlacementPolicy for not removing the chosen nodes

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995720#comment-12995720 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-1629:
----------------------------------------------

Created MAPREDUCE-2334 to update {{BlockPlacementPolicyRaid}}.

> Add a method to BlockPlacementPolicy for not removing the chosen nodes
> ----------------------------------------------------------------------
>
>                 Key: HDFS-1629
>                 URL: https://issues.apache.org/jira/browse/HDFS-1629
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.23.0
>
>         Attachments: h1629_20110216.patch, h1629_20110217.patch
>
>
> {{BlockPlacementPolicy}} supports chosen nodes in some of the {{chooseTarget(..)}} methods.  The chosen nodes will be removed from the output array.  For adding new datanodes to an existing pipeline, it is useful to keep the chosen nodes in the output array.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (HDFS-1629) Add a method to BlockPlacementPolicy for not removing the chosen nodes

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE resolved HDFS-1629.
------------------------------------------

    Resolution: Fixed

MAPREDUCE-2334 is committed.  Feel free to reopen this if you find any problem.

> Add a method to BlockPlacementPolicy for not removing the chosen nodes
> ----------------------------------------------------------------------
>
>                 Key: HDFS-1629
>                 URL: https://issues.apache.org/jira/browse/HDFS-1629
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.23.0
>
>         Attachments: h1629_20110216.patch, h1629_20110217.patch
>
>
> {{BlockPlacementPolicy}} supports chosen nodes in some of the {{chooseTarget(..)}} methods.  The chosen nodes will be removed from the output array.  For adding new datanodes to an existing pipeline, it is useful to keep the chosen nodes in the output array.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HDFS-1629) Add a method to BlockPlacementPolicy for not removing the chosen nodes

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HDFS-1629:
-----------------------------------------

    Status: Patch Available  (was: Open)

Thanks Dhruba for review the patch.

> Add a method to BlockPlacementPolicy for not removing the chosen nodes
> ----------------------------------------------------------------------
>
>                 Key: HDFS-1629
>                 URL: https://issues.apache.org/jira/browse/HDFS-1629
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node, hdfs client
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h1629_20110216.patch, h1629_20110217.patch
>
>
> {{BlockPlacementPolicy}} supports chosen nodes in some of the {{chooseTarget(..)}} methods.  The chosen nodes will be removed from the output array.  For adding new datanodes to an existing pipeline, it is useful to keep the chosen nodes in the output array.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HDFS-1629) Add a method to BlockPlacementPolicy for not removing the chosen nodes

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HDFS-1629:
-----------------------------------------

    Attachment: h1629_20110216.patch

h1629_20110216.patch: added a new method.

> Add a method to BlockPlacementPolicy for not removing the chosen nodes
> ----------------------------------------------------------------------
>
>                 Key: HDFS-1629
>                 URL: https://issues.apache.org/jira/browse/HDFS-1629
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node, hdfs client
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h1629_20110216.patch
>
>
> {{BlockPlacementPolicy}} supports chosen nodes in some of the {{chooseTarget(..)}} methods.  The chosen nodes will be removed from the output array.  For adding new datanodes to an existing pipeline, it is useful to keep the chosen nodes in the output array.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HDFS-1629) Add a method to BlockPlacementPolicy for not removing the chosen nodes

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HDFS-1629:
-----------------------------------------

    Attachment: h1629_20110217.patch

h1629_20110217.patch: fixed the new unit test.

> Add a method to BlockPlacementPolicy for not removing the chosen nodes
> ----------------------------------------------------------------------
>
>                 Key: HDFS-1629
>                 URL: https://issues.apache.org/jira/browse/HDFS-1629
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node, hdfs client
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h1629_20110216.patch, h1629_20110217.patch
>
>
> {{BlockPlacementPolicy}} supports chosen nodes in some of the {{chooseTarget(..)}} methods.  The chosen nodes will be removed from the output array.  For adding new datanodes to an existing pipeline, it is useful to keep the chosen nodes in the output array.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HDFS-1629) Add a method to BlockPlacementPolicy for not removing the chosen nodes

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995710#comment-12995710 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-1629:
----------------------------------------------

Let me take a look.  The fix seems obvious.

> Add a method to BlockPlacementPolicy for not removing the chosen nodes
> ----------------------------------------------------------------------
>
>                 Key: HDFS-1629
>                 URL: https://issues.apache.org/jira/browse/HDFS-1629
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.23.0
>
>         Attachments: h1629_20110216.patch, h1629_20110217.patch
>
>
> {{BlockPlacementPolicy}} supports chosen nodes in some of the {{chooseTarget(..)}} methods.  The chosen nodes will be removed from the output array.  For adding new datanodes to an existing pipeline, it is useful to keep the chosen nodes in the output array.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HDFS-1629) Add a method to BlockPlacementPolicy for not removing the chosen nodes

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HDFS-1629:
-----------------------------------------

    Status: Open  (was: Patch Available)

> Add a method to BlockPlacementPolicy for not removing the chosen nodes
> ----------------------------------------------------------------------
>
>                 Key: HDFS-1629
>                 URL: https://issues.apache.org/jira/browse/HDFS-1629
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node, hdfs client
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h1629_20110216.patch, h1629_20110217.patch
>
>
> {{BlockPlacementPolicy}} supports chosen nodes in some of the {{chooseTarget(..)}} methods.  The chosen nodes will be removed from the output array.  For adding new datanodes to an existing pipeline, it is useful to keep the chosen nodes in the output array.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Reopened: (HDFS-1629) Add a method to BlockPlacementPolicy for not removing the chosen nodes

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon reopened HDFS-1629:
-------------------------------


> Add a method to BlockPlacementPolicy for not removing the chosen nodes
> ----------------------------------------------------------------------
>
>                 Key: HDFS-1629
>                 URL: https://issues.apache.org/jira/browse/HDFS-1629
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.23.0
>
>         Attachments: h1629_20110216.patch, h1629_20110217.patch
>
>
> {{BlockPlacementPolicy}} supports chosen nodes in some of the {{chooseTarget(..)}} methods.  The chosen nodes will be removed from the output array.  For adding new datanodes to an existing pipeline, it is useful to keep the chosen nodes in the output array.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HDFS-1629) Add a method to BlockPlacementPolicy for not removing the chosen nodes

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HDFS-1629:
-----------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.23.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

I have committed this.

> Add a method to BlockPlacementPolicy for not removing the chosen nodes
> ----------------------------------------------------------------------
>
>                 Key: HDFS-1629
>                 URL: https://issues.apache.org/jira/browse/HDFS-1629
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.23.0
>
>         Attachments: h1629_20110216.patch, h1629_20110217.patch
>
>
> {{BlockPlacementPolicy}} supports chosen nodes in some of the {{chooseTarget(..)}} methods.  The chosen nodes will be removed from the output array.  For adding new datanodes to an existing pipeline, it is useful to keep the chosen nodes in the output array.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HDFS-1629) Add a method to BlockPlacementPolicy for not removing the chosen nodes

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995704#comment-12995704 ] 

Todd Lipcon commented on HDFS-1629:
-----------------------------------

This patch seems to have broken the MR contrib build:

    [javac] /data/1/scratch/patchqueue/patch-worker-32764/patch_62/svnrepo/src/contrib/raid/src/java/org/apache/hadoop/hdfs/server/namenode/BlockPlacementPolicyRaid.java:50: org.apache.hadoop.hdfs.server.namenode.BlockPlacementPolicyRaid is not abstract and does not override abstract method chooseTarget(java.lang.String,int,org.apache.hadoop.hdfs.server.namenode.DatanodeDescriptor,java.util.List<org.apache.hadoop.hdfs.server.namenode.DatanodeDescriptor>,boolean,java.util.HashMap<org.apache.hadoop.net.Node,org.apache.hadoop.net.Node>,long) in org.apache.hadoop.hdfs.server.namenode.BlockPlacementPolicy
    [javac] public class BlockPlacementPolicyRaid extends BlockPlacementPolicy {
    [javac]        ^

as well as a couple other errors there. Should we revert this until we have a fix ready for MR?

> Add a method to BlockPlacementPolicy for not removing the chosen nodes
> ----------------------------------------------------------------------
>
>                 Key: HDFS-1629
>                 URL: https://issues.apache.org/jira/browse/HDFS-1629
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.23.0
>
>         Attachments: h1629_20110216.patch, h1629_20110217.patch
>
>
> {{BlockPlacementPolicy}} supports chosen nodes in some of the {{chooseTarget(..)}} methods.  The chosen nodes will be removed from the output array.  For adding new datanodes to an existing pipeline, it is useful to keep the chosen nodes in the output array.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HDFS-1629) Add a method to BlockPlacementPolicy for not removing the chosen nodes

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HDFS-1629:
-----------------------------------------

    Status: Patch Available  (was: Open)

> Add a method to BlockPlacementPolicy for not removing the chosen nodes
> ----------------------------------------------------------------------
>
>                 Key: HDFS-1629
>                 URL: https://issues.apache.org/jira/browse/HDFS-1629
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node, hdfs client
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h1629_20110216.patch
>
>
> {{BlockPlacementPolicy}} supports chosen nodes in some of the {{chooseTarget(..)}} methods.  The chosen nodes will be removed from the output array.  For adding new datanodes to an existing pipeline, it is useful to keep the chosen nodes in the output array.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HDFS-1629) Add a method to BlockPlacementPolicy for not removing the chosen nodes

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HDFS-1629:
-----------------------------------------

    Component/s:     (was: hdfs client)
                     (was: data-node)
                 name-node

> Add a method to BlockPlacementPolicy for not removing the chosen nodes
> ----------------------------------------------------------------------
>
>                 Key: HDFS-1629
>                 URL: https://issues.apache.org/jira/browse/HDFS-1629
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h1629_20110216.patch, h1629_20110217.patch
>
>
> {{BlockPlacementPolicy}} supports chosen nodes in some of the {{chooseTarget(..)}} methods.  The chosen nodes will be removed from the output array.  For adding new datanodes to an existing pipeline, it is useful to keep the chosen nodes in the output array.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HDFS-1629) Add a method to BlockPlacementPolicy for not removing the chosen nodes

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995445#comment-12995445 ] 

dhruba borthakur commented on HDFS-1629:
----------------------------------------

+1, looks fine to me.

> Add a method to BlockPlacementPolicy for not removing the chosen nodes
> ----------------------------------------------------------------------
>
>                 Key: HDFS-1629
>                 URL: https://issues.apache.org/jira/browse/HDFS-1629
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node, hdfs client
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h1629_20110216.patch
>
>
> {{BlockPlacementPolicy}} supports chosen nodes in some of the {{chooseTarget(..)}} methods.  The chosen nodes will be removed from the output array.  For adding new datanodes to an existing pipeline, it is useful to keep the chosen nodes in the output array.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HDFS-1629) Add a method to BlockPlacementPolicy for not removing the chosen nodes

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995696#comment-12995696 ] 

Hudson commented on HDFS-1629:
------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #544 (See [https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/544/])
    HDFS-1629. Add a method to BlockPlacementPolicy for keeping the chosen nodes in the output array.


> Add a method to BlockPlacementPolicy for not removing the chosen nodes
> ----------------------------------------------------------------------
>
>                 Key: HDFS-1629
>                 URL: https://issues.apache.org/jira/browse/HDFS-1629
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.23.0
>
>         Attachments: h1629_20110216.patch, h1629_20110217.patch
>
>
> {{BlockPlacementPolicy}} supports chosen nodes in some of the {{chooseTarget(..)}} methods.  The chosen nodes will be removed from the output array.  For adding new datanodes to an existing pipeline, it is useful to keep the chosen nodes in the output array.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HDFS-1629) Add a method to BlockPlacementPolicy for not removing the chosen nodes

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995654#comment-12995654 ] 

Hadoop QA commented on HDFS-1629:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12471247/h1629_20110217.patch
  against trunk revision 1071023.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/169//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/169//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/169//console

This message is automatically generated.

> Add a method to BlockPlacementPolicy for not removing the chosen nodes
> ----------------------------------------------------------------------
>
>                 Key: HDFS-1629
>                 URL: https://issues.apache.org/jira/browse/HDFS-1629
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h1629_20110216.patch, h1629_20110217.patch
>
>
> {{BlockPlacementPolicy}} supports chosen nodes in some of the {{chooseTarget(..)}} methods.  The chosen nodes will be removed from the output array.  For adding new datanodes to an existing pipeline, it is useful to keep the chosen nodes in the output array.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira