Re: [PR] KAFKA-15201: Allow git push to fail gracefully [kafka]

["Owen-CH-Leung (via GitHub)" <gi...@apache.org>]

Owen-CH-Leung commented on code in PR #14645:
URL: https://github.com/apache/kafka/pull/14645#discussion_r1378515252


##########
release.py:
##########
@@ -730,7 +730,7 @@ def select_gpg_key():
     fail("Ok, giving up")
 if not user_ok("Ok to push RC tag %s (y/n)?: " % rc_tag):
     fail("Ok, giving up")
-cmd("Pushing RC tag", "git push %s %s" % (PUSH_REMOTE_NAME, rc_tag))
+cmd("Pushing RC tag", "git push %s %s" % (PUSH_REMOTE_NAME, rc_tag), num_retries=0)

Review Comment:
   I think the original implementation is that whenever cmd fails, the clean-up logic will always be fired (i.e. switch to the original working branch, delete the release branch & the tag). If we add the git-failure check, we may lose such feature.
   
   I've modified the git push part to avoid using the cmd function (thereby avoiding the cmd/fail loop). Could you take a look and leave me some feedback ? 
   
   The proposed logic is that when git push fails, the program will exit gracefully without cleaning the release branch & tag (so the user will have to manually clear them in order to restart)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org