[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1410: MINIFICPP-1500 Fix multiple archive tests running in parallel

[GitBox <gi...@apache.org>]

lordgamez commented on code in PR #1410:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1410#discussion_r963719514


##########
libminifi/include/utils/Id.h:
##########
@@ -126,12 +126,12 @@ class NonRepeatingStringGenerator {
   std::string generate() {
     return prefix_ + std::to_string(incrementor_++);
   }
-    uint64_t generateId() {
-      return incrementor_++;
-    }
+  uint64_t generateId() {
+    return incrementor_++;
+  }
  private:
   std::atomic<uint64_t> incrementor_{0};
-  std::string prefix_{std::to_string(std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::system_clock::now().time_since_epoch()).count()) + "-"};
+  std::string prefix_{IdGenerator::getIdGenerator()->generate().to_string() + "-"};

Review Comment:
   It's not the tests that create temporary files, but the libarchive. `FocusArchiveEntry::ReadCallback` which is used in both `ManipulateArchive` and `FocusArchiveEntry` processors [creates a temporary file when extracting the archive](https://github.com/apache/nifi-minifi-cpp/blob/a3835e1938db1287b0063d159b453b8a70f7a48b/extensions/libarchive/FocusArchiveEntry.cpp#L212) which only uses the timestamp as the filename. When the tests for `ManipulateArchive` and `FocusArchiveEntry` run in parallel the timestamp can be the same for the extraction and they override each other's temporary files.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org