You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Ranga S <sr...@yahoo.com> on 2011/09/03 01:50:58 UTC

Arquillian-Embedded: Patch for https://issues.apache.org/jira/browse/OPENEJB-1650

Hi

I've uploaded a new patch for the above mentioned issue. I split up the one test into three separate test classes. It still has 16 tests of which 3 are failing.
Please review.


- Ranga

Re: Arquillian-Embedded: Patch for https://issues.apache.org/jira/browse/OPENEJB-1652

Posted by Ranga S <sr...@yahoo.com>.

I've added some resource env-entry tests and re-factored the Servlet Listener tests. Please review patch attached to:
https://issues.apache.org/jira/browse/OPENEJB-1652



- Ranga

Re: Arquillian-Embedded: Patch for https://issues.apache.org/jira/browse/OPENEJB-1651

Posted by Ranga S <sr...@yahoo.com>.
Sure, I'll try to get something in next week for the JSF tests.


- Ranga


________________________________
From: David Blevins <da...@gmail.com>
To: Ranga S <sr...@yahoo.com>
Cc: "dev@openejb.apache.org" <de...@openejb.apache.org>
Sent: Saturday, September 10, 2011 2:55 PM
Subject: Re: Arquillian-Embedded: Patch for https://issues.apache.org/jira/browse/OPENEJB-1651


On Sep 9, 2011, at 7:09 PM, Ranga S wrote:

> I've done some re-factoring of the tests and have uploaded a patch to this issue. Please review.

Reviewed and committed!  Thank you!

I'm currently looking at the CDI issues.  Got it down to 51 failures as of this morning (from 75).  Nearly all the remaining issues are in JSF integration.

Would be fantastic to get some of these in:

  - Arquillian: JSF Managed Bean Tests
    https://issues.apache.org/jira/browse/OPENEJB-1653


-David

> From: David Blevins <da...@gmail.com>
> To: dev@openejb.apache.org
> Cc: Ranga S <sr...@yahoo.com>
> Sent: Friday, September 2, 2011 6:17 PM
> Subject: Re: Arquillian-Embedded: Patch for https://issues.apache.org/jira/browse/OPENEJB-1651
> 
> Very excellent!
> 
> Was just remembering in terms of injection w should add these "built-in" types.  All are declared via @Resource or <resource-env-ref>.
> 
> - java:comp/UserTransaction
> - java:comp/TransactionManager
> - java:comp/TransactionSynchronizationRegistry
> - java:comp/ValidatorFactory
> - java:comp/Validator
> 
> Any of those things should be able to be looked up or injected.
> 
> -David
> 
> On Sep 2, 2011, at 5:11 PM, Ranga S wrote:
> 
> > 
> > 
> > Hi
> > 
> > 
> > I've uploaded a patch for the above mentioned issue. They contain unit tests for injection into ServletFilters. It has 16 tests of which 3 are failing.
> > Please review.
> > 
> > 
> > - Ranga
> 
> 
>

Re: Arquillian-Embedded: Patch for https://issues.apache.org/jira/browse/OPENEJB-1651

Posted by David Blevins <da...@gmail.com>.
On Sep 9, 2011, at 7:09 PM, Ranga S wrote:

> I've done some re-factoring of the tests and have uploaded a patch to this issue. Please review.

Reviewed and committed!  Thank you!

I'm currently looking at the CDI issues.  Got it down to 51 failures as of this morning (from 75).  Nearly all the remaining issues are in JSF integration.

Would be fantastic to get some of these in:

  - Arquillian: JSF Managed Bean Tests
    https://issues.apache.org/jira/browse/OPENEJB-1653


-David

> From: David Blevins <da...@gmail.com>
> To: dev@openejb.apache.org
> Cc: Ranga S <sr...@yahoo.com>
> Sent: Friday, September 2, 2011 6:17 PM
> Subject: Re: Arquillian-Embedded: Patch for https://issues.apache.org/jira/browse/OPENEJB-1651
> 
> Very excellent!
> 
> Was just remembering in terms of injection w should add these "built-in" types.  All are declared via @Resource or <resource-env-ref>.
> 
> - java:comp/UserTransaction
> - java:comp/TransactionManager
> - java:comp/TransactionSynchronizationRegistry
> - java:comp/ValidatorFactory
> - java:comp/Validator
> 
> Any of those things should be able to be looked up or injected.
> 
> -David
> 
> On Sep 2, 2011, at 5:11 PM, Ranga S wrote:
> 
> > 
> > 
> > Hi
> > 
> > 
> > I've uploaded a patch for the above mentioned issue. They contain unit tests for injection into ServletFilters. It has 16 tests of which 3 are failing.
> > Please review.
> > 
> > 
> > - Ranga
> 
> 
>

Re: Arquillian-Embedded: Patch for https://issues.apache.org/jira/browse/OPENEJB-1651

Posted by Ranga S <sr...@yahoo.com>.
I've done some re-factoring of the tests and have uploaded a patch to this issue. Please review.


- Ranga


________________________________
From: David Blevins <da...@gmail.com>
To: dev@openejb.apache.org
Cc: Ranga S <sr...@yahoo.com>
Sent: Friday, September 2, 2011 6:17 PM
Subject: Re: Arquillian-Embedded: Patch for https://issues.apache.org/jira/browse/OPENEJB-1651

Very excellent!

Was just remembering in terms of injection w should add these "built-in" types.  All are declared via @Resource or <resource-env-ref>.

- java:comp/UserTransaction
- java:comp/TransactionManager
- java:comp/TransactionSynchronizationRegistry
- java:comp/ValidatorFactory
- java:comp/Validator

Any of those things should be able to be looked up or injected.

-David

On Sep 2, 2011, at 5:11 PM, Ranga S wrote:

> 
> 
> Hi
> 
> 
> I've uploaded a patch for the above mentioned issue. They contain unit tests for injection into ServletFilters. It has 16 tests of which 3 are failing.
> Please review.
> 
> 
> - Ranga

Re: Arquillian-Embedded: Patch for https://issues.apache.org/jira/browse/OPENEJB-1651

Posted by David Blevins <da...@gmail.com>.
Very excellent!

Was just remembering in terms of injection w should add these "built-in" types.  All are declared via @Resource or <resource-env-ref>.

 - java:comp/UserTransaction
 - java:comp/TransactionManager
 - java:comp/TransactionSynchronizationRegistry
 - java:comp/ValidatorFactory
 - java:comp/Validator

Any of those things should be able to be looked up or injected.

-David

On Sep 2, 2011, at 5:11 PM, Ranga S wrote:

> 
> 
> Hi
> 
> 
> I've uploaded a patch for the above mentioned issue. They contain unit tests for injection into ServletFilters. It has 16 tests of which 3 are failing.
> Please review.
> 
> 
> - Ranga

Re: Arquillian-Embedded: Servlet Listeners

Posted by David Blevins <da...@gmail.com>.
On Sep 2, 2011, at 6:32 PM, Ranga S wrote:

> I've uploaded a patch for the JIRA issue https://issues.apache.org/jira/browse/OPENEJB-1652. They contain unit tests for injection into Servlet Listeners. It has 32 tests of which 8 are failing.
> Please review.

I should have sent a note earlier, but I applied your three outstanding patches this Saturday.

  - OPENEJB-1650: Arquillian: Servlet Tests
  - OPENEJB-1651: Arquillian: Servlet Filter Tests
  - OPENEJB-1652: Arquillian: Servlet Listener Tests

Pretty excellent!

We're really getting a great number of TomEE tests now.  Nearly up to 100!  Quite impressive progress.

Great work, Ranga!


-David

Arquillian-Embedded: Servlet Listeners

Posted by Ranga S <sr...@yahoo.com>.
Hi


I've uploaded a patch for the JIRA issue https://issues.apache.org/jira/browse/OPENEJB-1652. They contain unit tests for injection into Servlet Listeners. It has 32 tests of which 8 are failing.
Please review.


- Ranga

Arquillian-Embedded: Patch for https://issues.apache.org/jira/browse/OPENEJB-1651

Posted by Ranga S <sr...@yahoo.com>.

Hi


I've uploaded a patch for the above mentioned issue. They contain unit tests for injection into ServletFilters. It has 16 tests of which 3 are failing.
Please review.


- Ranga