You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ws.apache.org by "Daniel Kulp (JIRA)" <ji...@apache.org> on 2011/02/09 18:47:57 UTC
[jira] Resolved: (NEETHI-8) Some improvements for flexibility!
[ https://issues.apache.org/jira/browse/NEETHI-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Kulp resolved NEETHI-8.
------------------------------
Resolution: Fixed
Fix Version/s: 3.0
Assignee: Daniel Kulp (was: Ajith Harshana Ranabahu)
This is all now fixed in 3.0.
PolicyEngine is no longer a bunch of static methods. It requires an instance. It holds onto an instance of the builder factory and converter factory and such so things can be completely configured per-instance.
> Some improvements for flexibility!
> ----------------------------------
>
> Key: NEETHI-8
> URL: https://issues.apache.org/jira/browse/NEETHI-8
> Project: Neethi
> Issue Type: Improvement
> Reporter: Ajith Harshana Ranabahu
> Assignee: Daniel Kulp
> Fix For: 3.0
>
> Attachments: neethi.patch
>
>
> 1. The AssertionBuilderFactory is made static inside the PolicyEngine.
> It seems this is not flexible since I want to have my own defaults. It
> would have been better if we can control this via a System property
> but for now I made it a field and added a setter so that one can set a
> custom factory
> 2. The AssertionBuilderFactory need not have any static methods . It
> should be an instance inside the PolicyEngine (static right now) and
> it has a static registerBuilder method which makes it really ugly.
> Actually the static factory instance is never used to register the
> builders. So I've made the registerBuilder method an instance
> method and also modified the PolicyEngine to rightfully use the static
> factory instance. Also moved the static intializer code to the
> constructor.
> 3. The element field in XMLPrimitiveAssertion has a default scope and
> is impossible to extend in an outside package. So I've made that a
> protected variable.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org