[GitHub] [airflow] potiuk commented on a change in pull request #22685: Fix processor cleanup on DagFileProcessorManager

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #22685:
URL: https://github.com/apache/airflow/pull/22685#discussion_r840643542



##########
File path: airflow/dag_processing/processor.py
##########
@@ -231,6 +231,9 @@ def _kill_process(self) -> None:
         if self._process.is_alive() and self._process.pid:
             self.log.warning("Killing DAGFileProcessorProcess (PID=%d)", self._process.pid)
             os.kill(self._process.pid, signal.SIGKILL)
+
+            # Reap the spawned zombie
+            os.waitpid(self._process.pid, 0)

Review comment:
       Indeed there might be a short time between even SIGKILL gets processed so waiting here makes sense.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org