You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by or...@apache.org on 2005/09/09 14:11:05 UTC

svn commit: r279748 - /myfaces/impl/trunk/src/java/org/apache/myfaces/application/jsp/JspStateManagerImpl.java

Author: oros
Date: Fri Sep  9 05:10:58 2005
New Revision: 279748

URL: http://svn.apache.org/viewcvs?rev=279748&view=rev
Log:
MYFACES-534

Modified:
    myfaces/impl/trunk/src/java/org/apache/myfaces/application/jsp/JspStateManagerImpl.java

Modified: myfaces/impl/trunk/src/java/org/apache/myfaces/application/jsp/JspStateManagerImpl.java
URL: http://svn.apache.org/viewcvs/myfaces/impl/trunk/src/java/org/apache/myfaces/application/jsp/JspStateManagerImpl.java?rev=279748&r1=279747&r2=279748&view=diff
==============================================================================
--- myfaces/impl/trunk/src/java/org/apache/myfaces/application/jsp/JspStateManagerImpl.java (original)
+++ myfaces/impl/trunk/src/java/org/apache/myfaces/application/jsp/JspStateManagerImpl.java Fri Sep  9 05:10:58 2005
@@ -260,15 +260,14 @@
     public void writeState(FacesContext facesContext,
                            SerializedView serializedView) throws IOException
     {
-        if (!isSavingStateInClient(facesContext))
+        if (isSavingStateInClient(facesContext))
         {
-            throw new IllegalStateException("Must not be called in server state saving mode");
+            UIViewRoot uiViewRoot = facesContext.getViewRoot();
+            //save state in response (client)
+            RenderKit renderKit = getRenderKitFactory().getRenderKit(facesContext, uiViewRoot.getRenderKitId());
+            renderKit.getResponseStateManager().writeState(facesContext, serializedView);
         }
 
-        UIViewRoot uiViewRoot = facesContext.getViewRoot();
-        //save state in response (client)
-        RenderKit renderKit = getRenderKitFactory().getRenderKit(facesContext, uiViewRoot.getRenderKitId());
-        renderKit.getResponseStateManager().writeState(facesContext, serializedView);
     }
 
     /**
@@ -280,24 +279,23 @@
     public void writeStateAsUrlParams(FacesContext facesContext,
                                       SerializedView serializedView) throws IOException
     {
-        if (!isSavingStateInClient(facesContext))
+        if (isSavingStateInClient(facesContext))
         {
-            throw new IllegalStateException("Must not be called in server state saving mode");
+            UIViewRoot uiViewRoot = facesContext.getViewRoot();
+            //save state in response (client)
+            RenderKit renderKit = getRenderKitFactory().getRenderKit(facesContext, uiViewRoot.getRenderKitId());
+            ResponseStateManager responseStateManager = renderKit.getResponseStateManager();
+            if (responseStateManager instanceof MyfacesResponseStateManager)
+            {
+                ((MyfacesResponseStateManager)responseStateManager).writeStateAsUrlParams(facesContext,
+                                                                                          serializedView);
+            }
+            else
+            {
+                log.error("ResponseStateManager of render kit " + uiViewRoot.getRenderKitId() + " is no MyfacesResponseStateManager and does not support saving state in url parameters.");
+            }
         }
 
-        UIViewRoot uiViewRoot = facesContext.getViewRoot();
-        //save state in response (client)
-        RenderKit renderKit = getRenderKitFactory().getRenderKit(facesContext, uiViewRoot.getRenderKitId());
-        ResponseStateManager responseStateManager = renderKit.getResponseStateManager();
-        if (responseStateManager instanceof MyfacesResponseStateManager)
-        {
-            ((MyfacesResponseStateManager)responseStateManager).writeStateAsUrlParams(facesContext,
-                                                                                      serializedView);
-        }
-        else
-        {
-            log.error("ResponseStateManager of render kit " + uiViewRoot.getRenderKitId() + " is no MyfacesResponseStateManager and does not support saving state in url parameters.");
-        }
     }