You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "spectrometerHBH (via GitHub)" <gi...@apache.org> on 2023/03/10 01:59:38 UTC

[GitHub] [tvm] spectrometerHBH opened a new pull request, #14266: [Unity][Transform] Let MetaScheduleApplyDatabase use DefaultSchedule when no record is found.

spectrometerHBH opened a new pull request, #14266:
URL: https://github.com/apache/tvm/pull/14266

   This pr enhances the current MetaScheduleApplyDatabase transformation. It will try to apply the corresponding default schedule pass when no record is found in the db.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on a diff in pull request #14266: [Unity][Transform] Let MetaScheduleApplyDatabase use DefaultSchedule when no record is found.

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on code in PR #14266:
URL: https://github.com/apache/tvm/pull/14266#discussion_r1132445714


##########
python/tvm/relax/transform/transform.py:
##########
@@ -475,18 +475,20 @@ def multiply(
 
 
 def MetaScheduleApplyDatabase(
-    work_dir: Optional[str] = None,
+    work_dir: Optional[str] = None, default_schedule_fallback=False
 ) -> tvm.ir.transform.Pass:
     """Apply the best schedule from tuning database.
     work_dir : Optional[str]
        work directory to deduce default database if database is not provided
        (it will be ignored when an user passes database)
+    default_schedule_fallback : bool
+       whether to fallback to default schedule when no schedule is found in database
     Returns
     -------
     ret : tvm.transform.Pass
         The registered pass
     """
-    return _ffi_api.MetaScheduleApplyDatabase(work_dir)  # type: ignore
+    return _ffi_api.MetaScheduleApplyDatabase(work_dir, default_schedule_fallback)  # type: ignore

Review Comment:
   Let us instead do a compositional pass, so in this case.  We can instead have a flag `warn_missing_entry`.
   Which can be set to false.
   
   Then we can compose the two pass together without having to injecting fallback logic into MSApplyDB



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao merged pull request #14266: [Unity][Transform] DefaultSchedule pass

Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao merged PR #14266:
URL: https://github.com/apache/tvm/pull/14266


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #14266: [Unity][Transform] Let MetaScheduleApplyDatabase use DefaultSchedule when no record is found.

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14266:
URL: https://github.com/apache/tvm/pull/14266#issuecomment-1463093340

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] spectrometerHBH commented on pull request #14266: [Unity][Transform] DefaultSchedule pass

Posted by "spectrometerHBH (via GitHub)" <gi...@apache.org>.
spectrometerHBH commented on PR #14266:
URL: https://github.com/apache/tvm/pull/14266#issuecomment-1475380646

   @tqchen Would you mind taking another look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org