You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "KeDeng (Code Review)" <ge...@cloudera.org> on 2023/02/07 09:14:03 UTC
[kudu-CR] [www] add slow scans show control
KeDeng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19480
Change subject: [www] add slow scans show control
......................................................................
[www] add slow scans show control
The slow sans show functions may lead full scanning and affecting
normal Kudu service without perception. So I add --show_slow_scans
to control whether to show slow scans in the /scans page of web
and record the slow scans in the log.
The default value of the flag --show_slow_scans is false, which means
slow scans show is disabled by default.
Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
---
M src/kudu/client/scan_token-test.cc
M src/kudu/tserver/scanners.cc
2 files changed, 40 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/19480/1
--
To view, visit http://gerrit.cloudera.org:8080/19480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
Gerrit-Change-Number: 19480
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
[kudu-CR] [www] add slow scans show control
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Ashwani Raina, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19480
to look at the new patch set (#6).
Change subject: [www] add slow scans show control
......................................................................
[www] add slow scans show control
The slow scans show functionality may lead to full scanning and affecting
normal Kudu service unexpectedly. Add --show_slow_scans flag to control
whether to show slow scans on the /scans page of web and record the
slow scans in the log.
The default value of the flag --show_slow_scans is false, which means
slow scans show is disabled by default.
Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
---
M src/kudu/client/scan_token-test.cc
M src/kudu/tserver/scanners.cc
2 files changed, 40 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/19480/6
--
To view, visit http://gerrit.cloudera.org:8080/19480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
Gerrit-Change-Number: 19480
Gerrit-PatchSet: 6
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [www] add slow scans show control
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19480 )
Change subject: [www] add slow scans show control
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
Gerrit-Change-Number: 19480
Gerrit-PatchSet: 8
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Wed, 22 Feb 2023 02:49:09 +0000
Gerrit-HasComments: No
[kudu-CR] [www] add slow scans show control
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19480 )
Change subject: [www] add slow scans show control
......................................................................
Patch Set 2:
(9 comments)
Thank you for adding this.
http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@9
PS1, Line 9: lead full
nit: lead to full
http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@9
PS1, Line 9: sans
nit: scans
http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@10
PS1, Line 10: So I add
nit: Add
http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@10
PS1, Line 10: perception
not sure what you mean perception here?
Do you want to say "without warning" ?
http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@11
PS1, Line 11: in
nit: on
http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@11
PS1, Line 11: to
nit: flag to
http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/client/scan_token-test.cc
File src/kudu/client/scan_token-test.cc:
http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/client/scan_token-test.cc@429
PS1, Line 429: FLAGS_show_slow_scans = false;
FLAGS_show_slow_scans seems to be already disabled when you come here.
Either get rid of line 373 or remove this statement.
http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/client/scan_token-test.cc@434
PS1, Line 434: // Create a slow scan scenarios.
I guess you can also add one more test case where you can enable FLAGS_show_slow_scans and see if slow scan works fine. Just an idea- it might as well be an assertion with no NULL vector. Or if you find a better way to validate that slow scan ran and completed.
http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/tserver/scanners.cc
File src/kudu/tserver/scanners.cc:
http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/tserver/scanners.cc@71
PS1, Line 71: perception
I am not quite clear on usage of this word here. It would help if you could explain it in one line, for my understanding.
--
To view, visit http://gerrit.cloudera.org:8080/19480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
Gerrit-Change-Number: 19480
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 07 Feb 2023 11:20:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] [www] add slow scans show control
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19480 )
Change subject: [www] add slow scans show control
......................................................................
Patch Set 5:
(3 comments)
Thanks for your reviews and I need your help to check it again.
http://gerrit.cloudera.org:8080/#/c/19480/4/src/kudu/tserver/scanners.cc
File src/kudu/tserver/scanners.cc:
http://gerrit.cloudera.org:8080/#/c/19480/4/src/kudu/tserver/scanners.cc@69
PS4, Line 69: or
> or
Done
http://gerrit.cloudera.org:8080/#/c/19480/4/src/kudu/tserver/scanners.cc@69
PS4, Line 69: on
> on
Done
http://gerrit.cloudera.org:8080/#/c/19480/4/src/kudu/tserver/scanners.cc@71
PS4, Line 71: edly.");
> Still doesn't make sense. Same comment for similar sentence in COMMIT_MSG.
Yes, that's what I want to express. Thank you for your correction.
--
To view, visit http://gerrit.cloudera.org:8080/19480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
Gerrit-Change-Number: 19480
Gerrit-PatchSet: 5
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 09 Feb 2023 02:12:56 +0000
Gerrit-HasComments: Yes
[kudu-CR] [www] add slow scans show control
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19480 )
Change subject: [www] add slow scans show control
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
Looks good to me. Just a minor comment.
http://gerrit.cloudera.org:8080/#/c/19480/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19480/5//COMMIT_MSG@9
PS5, Line 9: functions
I had noticed this before but somehow missed to update here last time.
I think you want to say "functionality" instead of "functions".
--
To view, visit http://gerrit.cloudera.org:8080/19480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
Gerrit-Change-Number: 19480
Gerrit-PatchSet: 5
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 09 Feb 2023 08:27:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] [www] add slow scans show control
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19480 )
Change subject: [www] add slow scans show control
......................................................................
Patch Set 8:
(1 comment)
Thanks for your reviews.
http://gerrit.cloudera.org:8080/#/c/19480/7/src/kudu/client/scan_token-test.cc
File src/kudu/client/scan_token-test.cc:
http://gerrit.cloudera.org:8080/#/c/19480/7/src/kudu/client/scan_token-test.cc@439
PS7, Line 439: an only get 0, which represents th
> nit: update the comment, it's not related to the actual function call below
Done
--
To view, visit http://gerrit.cloudera.org:8080/19480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
Gerrit-Change-Number: 19480
Gerrit-PatchSet: 8
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Wed, 22 Feb 2023 02:16:56 +0000
Gerrit-HasComments: Yes
[kudu-CR] [www] add slow scans show control
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19480 )
Change subject: [www] add slow scans show control
......................................................................
Patch Set 3:
(9 comments)
Thanks for your reviews and I've updated the patch. Please help to check it again. Thanks a lot.
http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@9
PS1, Line 9: scan
> nit: scans
Done
http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@9
PS1, Line 9: lead to
> nit: lead to full
Done
http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@10
PS1, Line 10: Add --sh
> nit: Add
Done
http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@10
PS1, Line 10: expectatio
> not sure what you mean perception here?
I mean without expectation.
http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@11
PS1, Line 11: on
> nit: on
Done
http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@11
PS1, Line 11: to
> nit: flag to
Done
http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/client/scan_token-test.cc
File src/kudu/client/scan_token-test.cc:
http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/client/scan_token-test.cc@429
PS1, Line 429: FLAGS_show_slow_scans = false;
> FLAGS_show_slow_scans seems to be already disabled when you come here.
The default value is false and I check it in line 372.
Then I set it to true to enable the slow scans show in line 373 so I can get the right value in line 411 and line 424.
So in here before line 429 the value is true.
http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/client/scan_token-test.cc@434
PS1, Line 434: // Create a slow scan scenarios.
> I guess you can also add one more test case where you can enable FLAGS_show
Yes, this case has done in line 424. Thanks for your advice.
http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/tserver/scanners.cc
File src/kudu/tserver/scanners.cc:
http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/tserver/scanners.cc@71
PS1, Line 71: perception
> I am not quite clear on usage of this word here. It would help if you could
I mean expectation. And I will update the comments.
--
To view, visit http://gerrit.cloudera.org:8080/19480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
Gerrit-Change-Number: 19480
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 07 Feb 2023 11:50:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] [www] add slow scans show control
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19480 )
Change subject: [www] add slow scans show control
......................................................................
Patch Set 4:
(5 comments)
Overall changes look good to me. Just some minor comments.
http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/client/scan_token-test.cc
File src/kudu/client/scan_token-test.cc:
http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/client/scan_token-test.cc@429
PS1, Line 429: FLAGS_show_slow_scans = false;
> The default value is false and I check it in line 372.
Ah! My bad! For some reason I incorrectly though that flag is always set to false.
Thanks for the clarification.
http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/client/scan_token-test.cc@434
PS1, Line 434: // Create a slow scan scenarios.
> Yes, this case has done in line 424. Thanks for your advice.
Same reason as above.
Thanks for the clarification!
http://gerrit.cloudera.org:8080/#/c/19480/4/src/kudu/tserver/scanners.cc
File src/kudu/tserver/scanners.cc:
http://gerrit.cloudera.org:8080/#/c/19480/4/src/kudu/tserver/scanners.cc@69
PS4, Line 69: and
or
http://gerrit.cloudera.org:8080/#/c/19480/4/src/kudu/tserver/scanners.cc@69
PS4, Line 69: in
on
http://gerrit.cloudera.org:8080/#/c/19480/4/src/kudu/tserver/scanners.cc@71
PS4, Line 71: expectation
Still doesn't make sense. Same comment for similar sentence in COMMIT_MSG.
Do you want to say this - "the normal Kudu service unexpectedly" ?
--
To view, visit http://gerrit.cloudera.org:8080/19480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
Gerrit-Change-Number: 19480
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 08 Feb 2023 14:01:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] [www] add slow scans show control
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Ashwani Raina, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19480
to look at the new patch set (#7).
Change subject: [www] add slow scans show control
......................................................................
[www] add slow scans show control
The slow scans show functionality may lead to full scanning and affecting
normal Kudu service unexpectedly. Add --show_slow_scans flag to control
whether to show slow scans on the /scans page of web and record the
slow scans in the log.
The default value of the flag --show_slow_scans is false, which means
slow scans show is disabled by default.
Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
---
M src/kudu/client/scan_token-test.cc
M src/kudu/tserver/scanners.cc
2 files changed, 40 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/19480/7
--
To view, visit http://gerrit.cloudera.org:8080/19480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
Gerrit-Change-Number: 19480
Gerrit-PatchSet: 7
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [www] add slow scans show control
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Ashwani Raina, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19480
to look at the new patch set (#3).
Change subject: [www] add slow scans show control
......................................................................
[www] add slow scans show control
The slow scans show functions may lead to full scanning and affecting
normal Kudu service without expectation. Add --show_slow_scans flag
to control whether to show slow scans on the /scans page of web
and record the slow scans in the log.
The default value of the flag --show_slow_scans is false, which means
slow scans show is disabled by default.
Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
---
M src/kudu/client/scan_token-test.cc
M src/kudu/tserver/scanners.cc
2 files changed, 40 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/19480/3
--
To view, visit http://gerrit.cloudera.org:8080/19480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
Gerrit-Change-Number: 19480
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [www] add slow scans show control
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Ashwani Raina, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19480
to look at the new patch set (#4).
Change subject: [www] add slow scans show control
......................................................................
[www] add slow scans show control
The slow scans show functions may lead to full scanning and affecting
normal Kudu service without expectation. Add --show_slow_scans flag
to control whether to show slow scans on the /scans page of web
and record the slow scans in the log.
The default value of the flag --show_slow_scans is false, which means
slow scans show is disabled by default.
Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
---
M src/kudu/client/scan_token-test.cc
M src/kudu/tserver/scanners.cc
2 files changed, 40 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/19480/4
--
To view, visit http://gerrit.cloudera.org:8080/19480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
Gerrit-Change-Number: 19480
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [www] add slow scans show control
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19480 )
Change subject: [www] add slow scans show control
......................................................................
Patch Set 6:
(1 comment)
Thanks for your reviews.
http://gerrit.cloudera.org:8080/#/c/19480/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19480/5//COMMIT_MSG@9
PS5, Line 9: functiona
> I had noticed this before but somehow missed to update here last time.
Done
--
To view, visit http://gerrit.cloudera.org:8080/19480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
Gerrit-Change-Number: 19480
Gerrit-PatchSet: 6
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 09 Feb 2023 10:06:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] [www] add slow scans show control
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19480 )
Change subject: [www] add slow scans show control
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19480/7/src/kudu/client/scan_token-test.cc
File src/kudu/client/scan_token-test.cc:
http://gerrit.cloudera.org:8080/#/c/19480/7/src/kudu/client/scan_token-test.cc@439
PS7, Line 439: ListSlowScans() return NULL vector
nit: update the comment, it's not related to the actual function call below.
--
To view, visit http://gerrit.cloudera.org:8080/19480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
Gerrit-Change-Number: 19480
Gerrit-PatchSet: 7
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 21 Feb 2023 15:05:17 +0000
Gerrit-HasComments: Yes
[kudu-CR] [www] add slow scans show control
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19480 )
Change subject: [www] add slow scans show control
......................................................................
[www] add slow scans show control
The slow scans show functionality may lead to full scanning and affecting
normal Kudu service unexpectedly. Add --show_slow_scans flag to control
whether to show slow scans on the /scans page of web and record the
slow scans in the log.
The default value of the flag --show_slow_scans is false, which means
slow scans show is disabled by default.
Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
Reviewed-on: http://gerrit.cloudera.org:8080/19480
Reviewed-by: Yingchun Lai <la...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/client/scan_token-test.cc
M src/kudu/tserver/scanners.cc
2 files changed, 40 insertions(+), 5 deletions(-)
Approvals:
Yingchun Lai: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
Gerrit-Change-Number: 19480
Gerrit-PatchSet: 9
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [www] add slow scans show control
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Ashwani Raina, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19480
to look at the new patch set (#5).
Change subject: [www] add slow scans show control
......................................................................
[www] add slow scans show control
The slow scans show functions may lead to full scanning and affecting
normal Kudu service unexpectedly. Add --show_slow_scans flag to control
whether to show slow scans on the /scans page of web and record the
slow scans in the log.
The default value of the flag --show_slow_scans is false, which means
slow scans show is disabled by default.
Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
---
M src/kudu/client/scan_token-test.cc
M src/kudu/tserver/scanners.cc
2 files changed, 40 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/19480/5
--
To view, visit http://gerrit.cloudera.org:8080/19480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
Gerrit-Change-Number: 19480
Gerrit-PatchSet: 5
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [www] add slow scans show control
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19480
to look at the new patch set (#2).
Change subject: [www] add slow scans show control
......................................................................
[www] add slow scans show control
The slow sans show functions may lead full scanning and affecting
normal Kudu service without perception. So I add --show_slow_scans
to control whether to show slow scans in the /scans page of web
and record the slow scans in the log.
The default value of the flag --show_slow_scans is false, which means
slow scans show is disabled by default.
Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
---
M src/kudu/client/scan_token-test.cc
M src/kudu/tserver/scanners.cc
2 files changed, 40 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/19480/2
--
To view, visit http://gerrit.cloudera.org:8080/19480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
Gerrit-Change-Number: 19480
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [www] add slow scans show control
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Ashwani Raina, Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19480
to look at the new patch set (#8).
Change subject: [www] add slow scans show control
......................................................................
[www] add slow scans show control
The slow scans show functionality may lead to full scanning and affecting
normal Kudu service unexpectedly. Add --show_slow_scans flag to control
whether to show slow scans on the /scans page of web and record the
slow scans in the log.
The default value of the flag --show_slow_scans is false, which means
slow scans show is disabled by default.
Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
---
M src/kudu/client/scan_token-test.cc
M src/kudu/tserver/scanners.cc
2 files changed, 40 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/19480/8
--
To view, visit http://gerrit.cloudera.org:8080/19480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6
Gerrit-Change-Number: 19480
Gerrit-PatchSet: 8
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>