You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "CalvinKirs (via GitHub)" <gi...@apache.org> on 2023/06/26 11:10:20 UTC
[GitHub] [doris] CalvinKirs opened a new pull request, #21191: [dependency](fe)Dependency version upgrade
CalvinKirs opened a new pull request, #21191:
URL: https://github.com/apache/doris/pull/21191
## Proposed changes
- Keep hadoop-aliyun version consistent with hadoop main version (3.3.5)
- upgrade jackson to 2.14.3
- upgrade netty version to 4.1.94.final
- binding check.freamework version to 3.32.0
- upgrade snappy-java to 1.1.10.1
- upgrade hudi version to 0.13.1
- upgrade spring version to 2.7.13
- upgrade orc version to 1.8.4
- revert nonsensical changes
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zy-kkk merged pull request #21191: [dependency](fe)Dependency version upgrade
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk merged PR #21191:
URL: https://github.com/apache/doris/pull/21191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] CalvinKirs commented on pull request #21191: [dependency](fe)Dependency version upgrade
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #21191:
URL: https://github.com/apache/doris/pull/21191#issuecomment-1607284268
run clickbench
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] CalvinKirs commented on a diff in pull request #21191: [dependency](fe)Dependency version upgrade
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on code in PR #21191:
URL: https://github.com/apache/doris/pull/21191#discussion_r1245997145
##########
fe/pom.xml:
##########
@@ -1025,7 +1049,7 @@ under the License.
<groupId>org.apache.spark</groupId>
<artifactId>spark-launcher_2.12</artifactId>
<version>${spark.version}</version>
- <!-- <scope>provided</scope> -->
+ <scope>provided</scope>
Review Comment:
There is a CVE for the current version, and since it's an optional feature, I'd rather ignore it, and users can add this jar manually, if needed.
I will investigate the version API compatibility of Spark 2 and 3 to complete the version upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] CalvinKirs commented on a diff in pull request #21191: [dependency](fe)Dependency version upgrade
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on code in PR #21191:
URL: https://github.com/apache/doris/pull/21191#discussion_r1246000506
##########
fe/pom.xml:
##########
@@ -482,6 +489,18 @@ under the License.
<artifactId>hadoop-auth</artifactId>
<version>${hadoop.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-aliyun</artifactId>
+ <version>${hadoop.version}</version>
+ <exclusions>
+ <!-- pls confirm if this is a mandatory dependency -->
+ <exclusion>
+ <groupId>org.ini4j</groupId>
+ <artifactId>ini4j</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
check done.it's ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21191: [dependency](fe)Dependency version upgrade
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21191:
URL: https://github.com/apache/doris/pull/21191#issuecomment-1612318802
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] CalvinKirs commented on pull request #21191: [dependency](fe)Dependency version upgrade
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #21191:
URL: https://github.com/apache/doris/pull/21191#issuecomment-1607239741
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21191: [dependency](fe)Dependency version upgrade
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21191:
URL: https://github.com/apache/doris/pull/21191#issuecomment-1612318829
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] CalvinKirs commented on a diff in pull request #21191: [dependency](fe)Dependency version upgrade
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on code in PR #21191:
URL: https://github.com/apache/doris/pull/21191#discussion_r1242022918
##########
fe/pom.xml:
##########
@@ -482,6 +489,18 @@ under the License.
<artifactId>hadoop-auth</artifactId>
<version>${hadoop.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-aliyun</artifactId>
+ <version>${hadoop.version}</version>
+ <exclusions>
+ <!-- pls confirm if this is a mandatory dependency -->
+ <exclusion>
+ <groupId>org.ini4j</groupId>
+ <artifactId>ini4j</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
@morningman Hi, could you help me confirm for this point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #21191: [dependency](fe)Dependency version upgrade
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #21191:
URL: https://github.com/apache/doris/pull/21191#issuecomment-1607362062
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43 seconds
stream load tsv: 454 seconds loaded 74807831229 Bytes, about 157 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
stream load parquet: 29 seconds loaded 861443392 Bytes, about 28 MB/s
insert into select: 68.6 seconds inserted 10000000 Rows, about 145K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230626122251_clickbench_pr_168016.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org