You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/26 06:01:41 UTC
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request
#4484: Modify visitor of dataTypeName
tristaZero opened a new pull request #4484: Modify visitor of dataTypeName
URL: https://github.com/apache/incubator-shardingsphere/pull/4484
Ref #4482
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4484:
Modify visitor of dataTypeName
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4484: Modify visitor of dataTypeName
URL: https://github.com/apache/incubator-shardingsphere/pull/4484#issuecomment-591260864
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4484?src=pr&el=h1) Report
> Merging [#4484](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4484?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/87d31b0e8caef1d9f2e7d1239993cef82d2e1aaa?src=pr&el=desc) will **increase** coverage by `0.78%`.
> The diff coverage is `30.45%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4484?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4484 +/- ##
============================================
+ Coverage 54.57% 55.36% +0.78%
Complexity 330 330
============================================
Files 952 952
Lines 18242 17984 -258
Branches 3387 3384 -3
============================================
+ Hits 9956 9957 +1
+ Misses 7641 7382 -259
Partials 645 645
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4484?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...phere/sql/parser/visitor/impl/MySQLDCLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4484/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvaW1wbC9NeVNRTERDTFZpc2l0b3IuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/sql/parser/visitor/impl/SQLServerDCLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4484/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbHNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci92aXNpdG9yL2ltcGwvU1FMU2VydmVyRENMVmlzaXRvci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...phere/sql/parser/visitor/impl/SQL92DCLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4484/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbDkyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvaW1wbC9TUUw5MkRDTFZpc2l0b3IuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...here/sql/parser/visitor/impl/OracleDCLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4484/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW9yYWNsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci92aXNpdG9yL2ltcGwvT3JhY2xlRENMVmlzaXRvci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...tener/PostShardingRegistryCenterEventListener.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4484/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vaW50ZXJuYWwvcmVnaXN0cnkvbGlzdGVuZXIvUG9zdFNoYXJkaW5nUmVnaXN0cnlDZW50ZXJFdmVudExpc3RlbmVyLmphdmE=) | `42.85% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../sql/parser/visitor/impl/PostgreSQLDCLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4484/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvdmlzaXRvci9pbXBsL1Bvc3RncmVTUUxEQ0xWaXNpdG9yLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...state/listener/DataSourceStateChangedListener.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4484/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vaW50ZXJuYWwvcmVnaXN0cnkvc3RhdGUvbGlzdGVuZXIvRGF0YVNvdXJjZVN0YXRlQ2hhbmdlZExpc3RlbmVyLmphdmE=) | `71.42% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...y/state/listener/InstanceStateChangedListener.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4484/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vaW50ZXJuYWwvcmVnaXN0cnkvc3RhdGUvbGlzdGVuZXIvSW5zdGFuY2VTdGF0ZUNoYW5nZWRMaXN0ZW5lci5qYXZh) | `75% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ardingsphere/sql/parser/visitor/OracleVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4484/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW9yYWNsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci92aXNpdG9yL09yYWNsZVZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...phere/sql/parser/visitor/impl/SQL92DMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4484/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbDkyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvaW1wbC9TUUw5MkRNTFZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [30 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4484/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4484?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4484?src=pr&el=footer). Last update [87d31b0...aa44b03](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4484?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4484:
Modify visitor of dataTypeName
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4484: Modify visitor of dataTypeName
URL: https://github.com/apache/incubator-shardingsphere/pull/4484
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4484:
Modify visitor of dataTypeName
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4484: Modify visitor of dataTypeName
URL: https://github.com/apache/incubator-shardingsphere/pull/4484#issuecomment-591261924
## Pull Request Test Coverage Report for [Build 9804](https://coveralls.io/builds/28964812)
* **0** of **5** **(0.0%)** changed or added relevant lines in **5** files are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.006%**) to **59.019%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLVisitor.java](https://coveralls.io/builds/28964812/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLVisitor.java#L545) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/OracleVisitor.java](https://coveralls.io/builds/28964812/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FOracleVisitor.java#L433) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java](https://coveralls.io/builds/28964812/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FPostgreSQLVisitor.java#L462) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/SQL92Visitor.java](https://coveralls.io/builds/28964812/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FSQL92Visitor.java#L418) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/SQLServerVisitor.java](https://coveralls.io/builds/28964812/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FSQLServerVisitor.java#L434) | 0 | 1 | 0.0%
<!-- | **Total:** | **0** | **5** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28964812/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/28964812) |
| :-- | --: |
| Change from base [Build 933](https://coveralls.io/builds/28944931): | -0.006% |
| Covered Lines: | 10614 |
| Relevant Lines: | 17984 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4484: Modify visitor of dataTypeName
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4484: Modify visitor of dataTypeName
URL: https://github.com/apache/incubator-shardingsphere/pull/4484#issuecomment-591261924
## Pull Request Test Coverage Report for [Build 1887](https://coveralls.io/builds/28964837)
* **0** of **5** **(0.0%)** changed or added relevant lines in **5** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **59.025%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLVisitor.java](https://coveralls.io/builds/28964837/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLVisitor.java#L545) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/OracleVisitor.java](https://coveralls.io/builds/28964837/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FOracleVisitor.java#L433) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java](https://coveralls.io/builds/28964837/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FPostgreSQLVisitor.java#L462) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/SQL92Visitor.java](https://coveralls.io/builds/28964837/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FSQL92Visitor.java#L418) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/SQLServerVisitor.java](https://coveralls.io/builds/28964837/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FSQLServerVisitor.java#L434) | 0 | 1 | 0.0%
<!-- | **Total:** | **0** | **5** | **0.0%** | -->
| Totals | [](https://coveralls.io/builds/28964837) |
| :-- | --: |
| Change from base [Build 933](https://coveralls.io/builds/28944931): | 0.0% |
| Covered Lines: | 10615 |
| Relevant Lines: | 17984 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services