You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/11/14 18:06:29 UTC

[kudu-CR] client-internal.h: add missing include 

Hello Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5070

to review the following change.

Change subject: client-internal.h: add missing include
......................................................................

client-internal.h: add missing include

This appears to be the only change necessary to build Kudu with GCC 6.2.

Change-Id: Ib13af3dd236256643d59ffd9d36ec1cffb5282de
---
M src/kudu/client/client-internal.h
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/5070/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib13af3dd236256643d59ffd9d36ec1cffb5282de
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>

[kudu-CR] client-internal.h: add missing include

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5070

to look at the new patch set (#2).

Change subject: client-internal.h: add missing include
......................................................................

client-internal.h: add missing include

This appears to be the only change necessary to build Kudu with GCC 6.2.

Change-Id: Ib13af3dd236256643d59ffd9d36ec1cffb5282de
---
M src/kudu/client/client-internal.h
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/5070/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib13af3dd236256643d59ffd9d36ec1cffb5282de
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] client-internal.h: add missing include

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: client-internal.h: add missing include
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5070/2/src/kudu/client/client-internal.h
File src/kudu/client/client-internal.h:

PS2, Line 26:   
> Nit: strayed extra spaces.
oops, typo

I meant 'git diff --check HEAD^'


-- 
To view, visit http://gerrit.cloudera.org:8080/5070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib13af3dd236256643d59ffd9d36ec1cffb5282de
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] client-internal.h: add missing include

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: client-internal.h: add missing include
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5070/1/src/kudu/client/client-internal.h
File src/kudu/client/client-internal.h:

PS1, Line 20: #include <algorithm>
            : #include <boost/function.hpp>
            : #include <cmath>
            : #include <set>
            : #include <string>
            : #include <unordered_set>
            : #include <vector>
> While you at it, could you re-order the list of include files to conform wi
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib13af3dd236256643d59ffd9d36ec1cffb5282de
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] client-internal.h: add missing include

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: client-internal.h: add missing include
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5070/2/src/kudu/client/client-internal.h
File src/kudu/client/client-internal.h:

PS2, Line 26:   
Nit: strayed extra spaces.

Running 'diff --check HEAD^' helps to find those, if your version of git is fresh enough.


-- 
To view, visit http://gerrit.cloudera.org:8080/5070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib13af3dd236256643d59ffd9d36ec1cffb5282de
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] client-internal.h: add missing include

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: client-internal.h: add missing include
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5070/2/src/kudu/client/client-internal.h
File src/kudu/client/client-internal.h:

PS2, Line 26:   
> oops, typo
woops.  This was just an artifact of me trying to use the crappy gerrit editor.  Fixed.


-- 
To view, visit http://gerrit.cloudera.org:8080/5070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib13af3dd236256643d59ffd9d36ec1cffb5282de
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] client-internal.h: add missing include

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.

Change subject: client-internal.h: add missing include
......................................................................


client-internal.h: add missing include

This appears to be the only change necessary to build Kudu with GCC 6.2.

Change-Id: Ib13af3dd236256643d59ffd9d36ec1cffb5282de
Reviewed-on: http://gerrit.cloudera.org:8080/5070
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/client/client-internal.h
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib13af3dd236256643d59ffd9d36ec1cffb5282de
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] client-internal.h: add missing include

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: client-internal.h: add missing include
......................................................................


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib13af3dd236256643d59ffd9d36ec1cffb5282de
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] client-internal.h: add missing include

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5070

to look at the new patch set (#3).

Change subject: client-internal.h: add missing include
......................................................................

client-internal.h: add missing include

This appears to be the only change necessary to build Kudu with GCC 6.2.

Change-Id: Ib13af3dd236256643d59ffd9d36ec1cffb5282de
---
M src/kudu/client/client-internal.h
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/5070/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib13af3dd236256643d59ffd9d36ec1cffb5282de
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] client-internal.h: add missing include

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: client-internal.h: add missing include
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5070/1/src/kudu/client/client-internal.h
File src/kudu/client/client-internal.h:

PS1, Line 20: #include <algorithm>
            : #include <boost/function.hpp>
            : #include <cmath>
            : #include <set>
            : #include <string>
            : #include <unordered_set>
            : #include <vector>
While you at it, could you re-order the list of include files to conform with the style guide: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes  ?

It would help me down the road while resolving conflicts with my IWYU branch (<cmath> is there already, but I also re-ordered those includes).

Thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/5070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib13af3dd236256643d59ffd9d36ec1cffb5282de
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes