You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (JIRA)" <ji...@apache.org> on 2012/05/03 10:48:51 UTC

[jira] [Updated] (CASSANDRA-4192) CQL3: fix index dropping and assign default name if none provided at index creation

     [ https://issues.apache.org/jira/browse/CASSANDRA-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sylvain Lebresne updated CASSANDRA-4192:
----------------------------------------

    Attachment: 4192-v2.txt

Right, I looked too quickly at that code and missed that we already validate the name is not unique and we already do assign a name to index that don't have one, sorry. What we could do though is to make sure we pick a name that is unique when choosing a default one (it's not a big deal to fail in that case, the user can always pick a name itself, but it's not very nice).

Anyway, attaching v2, that only includes the fix to DROP INDEX and make sure we pick a unique name.
                
> CQL3: fix index dropping and assign default name if none provided at index creation
> -----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-4192
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4192
>             Project: Cassandra
>          Issue Type: Bug
>          Components: API
>    Affects Versions: 1.1.0
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>              Labels: cql3
>             Fix For: 1.1.1
>
>         Attachments: 4192-v2.txt, 4192.txt
>
>
> This ticket proposes to fix two problems of CQL3 index handling:
> # DROP INDEX is broken (because the code forgot to clone the metadata before doing modification which break the schema update path)
> # If an index is created with a name (which CREATE INDEX allow), there is no way to drop the index (note that we will internally assign a name to the index ColumnFamilyStore, but we don't assign a name in the ColumnDefinition object, which is the only one checked by DROP INDEX).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira