You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Brian Topping (JIRA)" <ji...@apache.org> on 2007/03/06 03:51:24 UTC
[jira] Created: (WICKET-362) Add ability to manage disabled items
from subclasses of AbstractChoice
Add ability to manage disabled items from subclasses of AbstractChoice
----------------------------------------------------------------------
Key: WICKET-362
URL: https://issues.apache.org/jira/browse/WICKET-362
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 2.0
Reporter: Brian Topping
AbstractChoice does almost everything but disabled items. This patch adds that ability.
This is my first patch to Wicket. I had some question about whether to include a default implementation for isDisabled(), but that would have required a Map to be supplied. Then I started wondering about whether four more ctors should be provided to pass in the map. Then I decided it was better managed by the subclass. It can always be improved later.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-362) Add ability to manage disabled items
from subclasses of AbstractChoice
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Quenot resolved WICKET-362.
-----------------------------------------
Resolution: Fixed
Fix Version/s: 1.3
Committed, thanks for your contribution!
> Add ability to manage disabled items from subclasses of AbstractChoice
> ----------------------------------------------------------------------
>
> Key: WICKET-362
> URL: https://issues.apache.org/jira/browse/WICKET-362
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 2.0
> Reporter: Brian Topping
> Assigned To: Jean-Baptiste Quenot
> Fix For: 1.3
>
> Attachments: AbstractChoice.patch
>
>
> AbstractChoice does almost everything but disabled items. This patch adds that ability.
> This is my first patch to Wicket. I had some question about whether to include a default implementation for isDisabled(), but that would have required a Map to be supplied. Then I started wondering about whether four more ctors should be provided to pass in the map. Then I decided it was better managed by the subclass. It can always be improved later.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-362) Add ability to manage disabled items
from subclasses of AbstractChoice
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Quenot updated WICKET-362:
----------------------------------------
Fix Version/s: (was: trunk)
1.3.0-beta2
> Add ability to manage disabled items from subclasses of AbstractChoice
> ----------------------------------------------------------------------
>
> Key: WICKET-362
> URL: https://issues.apache.org/jira/browse/WICKET-362
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 2.0 branch (discontinued)
> Reporter: Brian Topping
> Assignee: Jean-Baptiste Quenot
> Fix For: 1.3.0-beta2
>
> Attachments: AbstractChoice.patch
>
>
> AbstractChoice does almost everything but disabled items. This patch adds that ability.
> This is my first patch to Wicket. I had some question about whether to include a default implementation for isDisabled(), but that would have required a Map to be supplied. Then I started wondering about whether four more ctors should be provided to pass in the map. Then I decided it was better managed by the subclass. It can always be improved later.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-362) Add ability to manage disabled items
from subclasses of AbstractChoice
Posted by "Brian Topping (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Topping updated WICKET-362:
---------------------------------
Attachment: AbstractChoice.patch
> Add ability to manage disabled items from subclasses of AbstractChoice
> ----------------------------------------------------------------------
>
> Key: WICKET-362
> URL: https://issues.apache.org/jira/browse/WICKET-362
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 2.0
> Reporter: Brian Topping
> Attachments: AbstractChoice.patch
>
>
> AbstractChoice does almost everything but disabled items. This patch adds that ability.
> This is my first patch to Wicket. I had some question about whether to include a default implementation for isDisabled(), but that would have required a Map to be supplied. Then I started wondering about whether four more ctors should be provided to pass in the map. Then I decided it was better managed by the subclass. It can always be improved later.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-362) Add ability to manage disabled items
from subclasses of AbstractChoice
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Quenot reassigned WICKET-362:
-------------------------------------------
Assignee: Jean-Baptiste Quenot
> Add ability to manage disabled items from subclasses of AbstractChoice
> ----------------------------------------------------------------------
>
> Key: WICKET-362
> URL: https://issues.apache.org/jira/browse/WICKET-362
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 2.0
> Reporter: Brian Topping
> Assigned To: Jean-Baptiste Quenot
> Attachments: AbstractChoice.patch
>
>
> AbstractChoice does almost everything but disabled items. This patch adds that ability.
> This is my first patch to Wicket. I had some question about whether to include a default implementation for isDisabled(), but that would have required a Map to be supplied. Then I started wondering about whether four more ctors should be provided to pass in the map. Then I decided it was better managed by the subclass. It can always be improved later.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.