You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/18 16:04:15 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #7797: ARROW-4189 [Rust] Added coverage report.
jorgecarleitao opened a new pull request #7797:
URL: https://github.com/apache/arrow/pull/7797
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-696598247
@jorgecarleitao could you rebase on top of the master? I'm unable to push to your fork, but the build failures should be resolved after a rebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692231293
Revision: 48310b5aa83bdc30a8a14285badfffc08939385d
Submitted crossbow builds: [ursa-labs/crossbow @ actions-537](https://github.com/ursa-labs/crossbow/branches/all?query=actions-537)
|Task|Status|
|----|------|
|rust-coverage|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-537-github-rust-coverage)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692244399
The current status is that this is only running the `arrow` workspace. I am trying to make this run the whole thing.
@github-actions crossbow submit rust-coverage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692230137
@github-actions crossbow submit rust-coverage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-693798216
Ok, @kszucs I think that this is ready for a re-review.
Report is here: https://codecov.io/github/apache/arrow/commit/604065c5188af00f640051d909e27f37db4eb43b
I removed all code in tasks, and created a new workflow on github for this, like you initially suggested, as I was unable to make it work on the nightly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692432646
@github-actions crossbow submit rust-coverage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692442749
Revision: d2d7aa9fc29afe597a7c644072f119ed41aa7c39
Submitted crossbow builds: [ursa-labs/crossbow @ actions-540](https://github.com/ursa-labs/crossbow/branches/all?query=actions-540)
|Task|Status|
|----|------|
|rust-coverage|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-540-github-rust-coverage)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#discussion_r490803947
##########
File path: .github/workflows/rust_cron.yml
##########
@@ -0,0 +1,56 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Rust Cron
+
+on:
+ push:
+ paths:
+ - '.github/workflows/rust_cron.yml'
+ pull_request:
+ paths:
+ - '.github/workflows/rust_cron.yml'
+ schedule:
+ - cron: 0 */12 * * *
+
+jobs:
+ coverage:
+ name: AMD64 Debian 10 Rust ${{ matrix.rust }}
Review comment:
```suggestion
name: AMD64 Debian 10 Rust ${{ matrix.rust }} Coverage
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao edited a comment on pull request #7797: ARROW-4189 [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao edited a comment on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-660551616
I investigated how to add this to the docker image. It is possible, but we need to run the image using `--security-opt seccomp=unconfined` as [explained here](https://crates.io/crates/cargo-tarpaulin#docker). Since `docker-compose run` is executed through dev/archery, we need to add this option to `dev/archery`.
Note that this argument introduces a couple of attack vectors to the docker orchestration - I am not even sure if travis accepts it. Regardless, let me know your thoughts on this @sunchao .
For reference, the error that I get (locally and on the CI) when this argument is not passed is shown in [these logs](https://github.com/jorgecarleitao/arrow/runs/885629631?check_suite_focus=true).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sunchao commented on pull request #7797: ARROW-4189 [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-660542447
coverage report will be nice!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-691928331
@github-actions crossbow submit rust-coverage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs edited a comment on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
kszucs edited a comment on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692811492
@jorgecarleitao thanks for setting this up!
I'm afraid the [codecov](https://github.com/apache/arrow/pull/7797/files#diff-65f11a6b56b838fa108262f1f2c3e65aR45) script picks up the CI environment (branch commit sha etc.) belonging to crossbow, so it will make the reports less browsable/usable.
We can also schedule nightly builds on apache/arrow directly, we already have nightly builds configured for [Python](https://github.com/apache/arrow/blob/master/.github/workflows/python_cron.yml) and [C++](https://github.com/apache/arrow/blob/master/.github/workflows/cpp_cron.yml). It may be better to have a similar `rust_cron.yml` where codecov would hopefully pick up the right git metadata.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189 [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-660877250
@sunchao , I moved the coverage to run on the docker image and added reporting to codecov to github's workflow.
Since coverage reporting requires a different compilation strategy, it recompiles the project and thus the CI takes longer. One way to address this is to make all our tests run through `cargo tarpaulin` (instead of `cargo test`). This has not been addressed here. I am hoping that #7799 helps to mitigate this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692774444
@github-actions crossbow submit rust-coverage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692184333
@kszucs , thanks a lot. Can we try again (I tried, but I likely do not have authority to ask the bot stuff).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao edited a comment on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao edited a comment on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692184333
@kszucs , thanks a lot. Can we try again (I tried, but I likely do not have authority to ask the bot stuff).
EDIT: nevermind, it also answers to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-686695972
@sunchao @andygrove, based on @wesm hint on ARROW-5972, I made this PR be to place rust coverage on nightly builds instead of every PR/build.
I do not know how to test if this works, though. I mostly got inspiration by (aka copied) code around to my purposes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189 [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-660503710
Here is an example of the current report: https://codecov.io/gh/jorgecarleitao/arrow/tree/rust_coverage/rust
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692752525
@github-actions crossbow submit rust-coverage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #7797:
URL: https://github.com/apache/arrow/pull/7797
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692182729
@github-actions crossbow submit rust-coverage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692791457
Revision: 2ba754d1f40ea7ff7a7c4d35f28d00cbe413e2fa
Submitted crossbow builds: [ursa-labs/crossbow @ actions-543](https://github.com/ursa-labs/crossbow/branches/all?query=actions-543)
|Task|Status|
|----|------|
|rust-coverage|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-543-github-rust-coverage)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-695151817
Thanks @kszucs , good ideas. Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692263153
Revision: 038fa8fc000811da02f681bce10b30515daddf53
Submitted crossbow builds: [ursa-labs/crossbow @ actions-538](https://github.com/ursa-labs/crossbow/branches/all?query=actions-538)
|Task|Status|
|----|------|
|rust-coverage|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-538-github-rust-coverage)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692212218
@github-actions crossbow submit rust-coverage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692811492
@jorgecarleitao thanks for setting this up!
I'm afraid the [codecov](https://github.com/apache/arrow/pull/7797/files#diff-65f11a6b56b838fa108262f1f2c3e65aR45) script picks up the CI environment (branch commit sha etc.) belonging to crossbow, so it will make the reports less browsable.
We can also schedule nightly builds on apache/arrow directly, we already have nightly builds configured for [Python](https://github.com/apache/arrow/blob/master/.github/workflows/python_cron.yml) and [C++](https://github.com/apache/arrow/blob/master/.github/workflows/cpp_cron.yml). It may be better to have a similar `rust_cron.yml` where codecov would hopefully pick up the right git metadata.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692189392
@github-actions crossbow submit rust-coverage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-691929582
Revision: 46dc7f282cf1fba9758fbc62649d21fa9667e33c
Submitted crossbow builds: [ursa-labs/crossbow @ actions-530](https://github.com/ursa-labs/crossbow/branches/all?query=actions-530)
|Task|Status|
|----|------|
|rust-coverage|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-530-github-rust-coverage)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-693558594
@github-actions crossbow submit rust-coverage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692213285
Revision: 26319d253ba12a34289a8f0fecdb70d61e6c1abf
Submitted crossbow builds: [ursa-labs/crossbow @ actions-536](https://github.com/ursa-labs/crossbow/branches/all?query=actions-536)
|Task|Status|
|----|------|
|rust-coverage|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-536-github-rust-coverage)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692805801
@nevi-me , @kszucs , @emkornfield @sunchao @andygrove , I think that this is now ready to review.
The report is [here](https://codecov.io/gh/ursa-labs/crossbow/tree/a2881cf28bb969826202bfdb110f5cb25a1d2392/arrow).
The report takes 15m to make, and also runs all tests. We could replace running tests by this, but I am not sure we want to run tests with different compilation flags, and thus nightly seems more appropriate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-691980090
Seems like the template has [errors](https://github.com/ursa-labs/crossbow/actions/runs/253553399). You can take a look at the builds under the crossbow repository's [actions tab](https://github.com/ursa-labs/crossbow/actions).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692196511
Revision: aa1991437826a34211e54086afecc5a65d20f750
Submitted crossbow builds: [ursa-labs/crossbow @ actions-535](https://github.com/ursa-labs/crossbow/branches/all?query=actions-535)
|Task|Status|
|----|------|
|rust-coverage|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-535-github-rust-coverage)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692192080
Revision: f1985530770d5eadd729164687c46b46bd944524
Submitted crossbow builds: [ursa-labs/crossbow @ actions-534](https://github.com/ursa-labs/crossbow/branches/all?query=actions-534)
|Task|Status|
|----|------|
|rust-coverage|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-534-github-rust-coverage)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189 [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-660551616
I investigated how to add this to the docker image. It is possible, but we need to run the image using `--security-opt seccomp=unconfined` as [explained here](https://crates.io/crates/cargo-tarpaulin#docker). Since `docker-compose run` is executed through dev/archery, we need to add this option to `dev/archery`.
Note that this argument introduces a couple of attack vectors to the docker orchestration - I am not even sure if travis accepts it. Regardless, let me know your thoughts on this @sunchao .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692758643
Revision: b26d19d7344cae7f24df10fa4604a9e8d0aa4c84
Submitted crossbow builds: [ursa-labs/crossbow @ actions-542](https://github.com/ursa-labs/crossbow/branches/all?query=actions-542)
|Task|Status|
|----|------|
|rust-coverage|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-542-github-rust-coverage)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-691821579
@kszucs could you take a look and see if there is a good way to test this? Otherwise maybe we can merge and test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-693564370
Revision: 92f59f16b4ec1b25ecb127890db63a80fd72f9bb
Submitted crossbow builds: [ursa-labs/crossbow @ actions-544](https://github.com/ursa-labs/crossbow/branches/all?query=actions-544)
|Task|Status|
|----|------|
|rust-coverage|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-544-github-rust-coverage)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on a change in pull request #7797: ARROW-4189 [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#discussion_r456803458
##########
File path: ci/scripts/rust_coverage.sh
##########
@@ -0,0 +1,56 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -ex
+
+arrow_dir=${1}
+source_dir=${1}/rust
+build_dir=${2}/rust
+
+export ARROW_TEST_DATA=${arrow_dir}/testing/data
+export PARQUET_TEST_DATA=${arrow_dir}/cpp/submodules/parquet-testing/data
+export CARGO_TARGET_DIR=${build_dir}
+export RUSTFLAGS="-D warnings"
+
+pushd ${source_dir}
+
+# install cargo install cargo-tarpaulin
+rustup update nightly-2020-04-22 && rustup default nightly-2020-04-22
Review comment:
This is sub-optimal: we should derive this from the matrix from github templates. No idea how to do this though. Any ideas?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692184480
Revision: c58d803ec2e049216b2442177f9f3cdfab13fc6c
Submitted crossbow builds: [ursa-labs/crossbow @ actions-533](https://github.com/ursa-labs/crossbow/branches/all?query=actions-533)
|Task|Status|
|----|------|
|rust-coverage|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-533-github-rust-coverage)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692442382
Revision: d2d7aa9fc29afe597a7c644072f119ed41aa7c39
Submitted crossbow builds: [ursa-labs/crossbow @ actions-539](https://github.com/ursa-labs/crossbow/branches/all?query=actions-539)
|Task|Status|
|----|------|
|rust-coverage|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-539-github-rust-coverage)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao edited a comment on pull request #7797: ARROW-4189 [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao edited a comment on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-673082183
@andygrove , unfortunately do not benefit from caching here, as this needs to be built from scratch. I am not very happy with the build time (+10m of build time).
IMO it is great to have these reports, but I do not think we should block the build for more 10m for this, specially since we are not imposing any min coverage.
Do we have any place to put nightly stuff? This could maybe fit there. My thinking is that increasing coverage is a great "starter" issues, and having a link to the nightly coverage report could create an incentive for people to pick a file and start increasing coverage on it.
Another option is to run this instead of the tests (since this runs the lib tests anyway).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-694747857
Thanks @jorgecarleitao, it looks good to me. Just one nit, could you please add a coverage report link to the rust README to improve its visibilty?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on pull request #7797: ARROW-4189 [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-672564300
@jorgecarleitao So I saw that #7799 was merged. What does that mean for this PR now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692817299
@kszucs , I agree that the browsability should be fixed.
Either works for me: we can [try to fix the paths](https://docs.codecov.io/docs/fixing-paths) or move the build to apache/arrow. I am not familiar with the CI in arrow, so I will abstain from a decision: let me know what you prefer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #7797:
URL: https://github.com/apache/arrow/pull/7797
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sunchao commented on pull request #7797: ARROW-4189 [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-661139731
Thanks @jorgecarleitao ! IMO the compilation time is important so let's see of #7799 goes. I'll take a look later today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189 [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-673082183
@andygrove , unfortunately do not benefit from caching here, as this needs to be built from scratch. I am not very happy with the build time (+10m of build time).
IMO it is great to have these reports, but I do not think we should block the build for more 10m for this, specially since we are not imposing any min coverage.
Do we have any place to put nightly stuff? This could maybe fit there. My thinking is that increasing coverage is a great "starter" issues, and having a link to the nightly coverage report could create an incentive for people to pick a file and start reducing increasing coverage on it.
Another option is to run this instead of the tests (since this runs the lib tests anyway).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7797: ARROW-4189 [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-660503712
https://issues.apache.org/jira/browse/ARROW-4189
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189 [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-660512777
This is sub-optimal: the build currently takes 19m, and this PR makes the build take 37m. This is mostly due to the compilation, which I think we should be doing within docker. I will try a couple of things.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692194111
@github-actions crossbow submit rust-coverage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692439667
@github-actions crossbow submit rust-coverage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692262111
@github-actions crossbow submit rust-coverage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-692822149
I thought that codecov looks for the CI specific environment variables, but if placing a `workdir: arrow` to the [codecov step](https://github.com/apache/arrow/pull/7797/files#diff-65f11a6b56b838fa108262f1f2c3e65aR44) (or just `cd arrow` before calling it) would fix the git metadata then this solution sounds good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org