You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/10/18 20:33:08 UTC
Review Request: SQOOP-635: Explaining why it's important to specify weird
urandom path in Troubleshooting guide
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7651/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
I've linked relevant Java bug and explained why it's needed.
This addresses bug SQOOP-635.
https://issues.apache.org/jira/browse/SQOOP-635
Diffs
-----
src/docs/user/troubleshooting.txt d46a886c98be0f04303218c922f080ecab192707
Diff: https://reviews.apache.org/r/7651/diff/
Testing
-------
I've build docs and verified that they look ok.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-635: Explaining why it's important to specify
weird urandom path in Troubleshooting guide
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7651/#review12914
-----------------------------------------------------------
Ship it!
Ship It!
- Cheolsoo Park
On Oct. 30, 2012, 6:23 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7651/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2012, 6:23 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've linked relevant Java bug and explained why it's needed.
>
>
> This addresses bug SQOOP-635.
> https://issues.apache.org/jira/browse/SQOOP-635
>
>
> Diffs
> -----
>
> src/docs/user/troubleshooting.txt d46a886c98be0f04303218c922f080ecab192707
>
> Diff: https://reviews.apache.org/r/7651/diff/
>
>
> Testing
> -------
>
> I've build docs and verified that they look ok.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request: SQOOP-635: Explaining why it's important to specify
weird urandom path in Troubleshooting guide
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7651/
-----------------------------------------------------------
(Updated Oct. 30, 2012, 6:23 p.m.)
Review request for Sqoop.
Changes
-------
Thank you very much for you comments Cheolsoo. I've incorporated both your suggestions.
Description
-------
I've linked relevant Java bug and explained why it's needed.
This addresses bug SQOOP-635.
https://issues.apache.org/jira/browse/SQOOP-635
Diffs (updated)
-----
src/docs/user/troubleshooting.txt d46a886c98be0f04303218c922f080ecab192707
Diff: https://reviews.apache.org/r/7651/diff/
Testing
-------
I've build docs and verified that they look ok.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-635: Explaining why it's important to specify
weird urandom path in Troubleshooting guide
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7651/#review12912
-----------------------------------------------------------
I have two minor comments as below. Please let me know what you think.
src/docs/user/troubleshooting.txt
<https://reviews.apache.org/r/7651/#comment27762>
Can you change this to "as it is due to a Java bug ..."? Note that I dropped the "as" before the "due".
src/docs/user/troubleshooting.txt
<https://reviews.apache.org/r/7651/#comment27763>
Can you change this line as follows?
", or +/dev/urandom+ will be ignored and substituted by +/dev/random+."
- Cheolsoo Park
On Oct. 30, 2012, 3:53 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7651/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2012, 3:53 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've linked relevant Java bug and explained why it's needed.
>
>
> This addresses bug SQOOP-635.
> https://issues.apache.org/jira/browse/SQOOP-635
>
>
> Diffs
> -----
>
> src/docs/user/troubleshooting.txt d46a886c98be0f04303218c922f080ecab192707
>
> Diff: https://reviews.apache.org/r/7651/diff/
>
>
> Testing
> -------
>
> I've build docs and verified that they look ok.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request: SQOOP-635: Explaining why it's important to specify
weird urandom path in Troubleshooting guide
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7651/
-----------------------------------------------------------
(Updated Oct. 30, 2012, 3:53 p.m.)
Review request for Sqoop.
Changes
-------
I've improved provided link to JAVA bug system by removing my session id.
Description
-------
I've linked relevant Java bug and explained why it's needed.
This addresses bug SQOOP-635.
https://issues.apache.org/jira/browse/SQOOP-635
Diffs (updated)
-----
src/docs/user/troubleshooting.txt d46a886c98be0f04303218c922f080ecab192707
Diff: https://reviews.apache.org/r/7651/diff/
Testing
-------
I've build docs and verified that they look ok.
Thanks,
Jarek Cecho