You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2023/01/09 21:01:16 UTC
[GitHub] [logging-log4j2] jvz opened a new pull request, #1196: Apply spotless automatically
jvz opened a new pull request, #1196:
URL: https://github.com/apache/logging-log4j2/pull/1196
This adds executions during process-sources and process-test-sources to ensure that modified files are formatted properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] jvz merged pull request #1196: Apply spotless automatically
Posted by GitBox <gi...@apache.org>.
jvz merged PR #1196:
URL: https://github.com/apache/logging-log4j2/pull/1196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] jvz commented on pull request #1196: Apply spotless automatically
Posted by GitBox <gi...@apache.org>.
jvz commented on PR #1196:
URL: https://github.com/apache/logging-log4j2/pull/1196#issuecomment-1377649991
Oh shit that's a good point on the CI side. And I wasn't sure about the phase; I thought both would be required, but I suppose it depends on the particular plugin (I'm used to configuring the compiler and surefire plugins so much that I get explicit on the phases to attach to).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ppkarwasz commented on pull request #1196: Apply spotless automatically
Posted by GitBox <gi...@apache.org>.
ppkarwasz commented on PR #1196:
URL: https://github.com/apache/logging-log4j2/pull/1196#issuecomment-1376755093
@jvz,
Wouldn't `process-test-sources` be enough? The idea is great: if you run tests on a PR, the code will be automatically formatted. However we have also to disable this in the CI, since it renders the `spotless:check` run useless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org