[GitHub] [incubator-echarts] pissang commented on a change in pull request #13317: [5.0] [Feature] support largest-triangle-three-buckets algo

[GitBox <gi...@apache.org>]

pissang commented on a change in pull request #13317:
URL: https://github.com/apache/incubator-echarts/pull/13317#discussion_r492499816



##########
File path: src/data/List.ts
##########
@@ -1692,6 +1692,109 @@ class List<
         return list as List<HostModel>;
     }
 
+    /**
+     * Large data down sampling using largest-triangle-three-buckets
+     * copied from https://github.com/pingec/downsample-lttb with some modifications
+     * @param {string} baseDimension

Review comment:
       Please don't use the code directly. It will have licence issue.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org