You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/04/04 06:55:36 UTC

[GitHub] zeppelin pull request #2220: [Minor] Fix wrong Python lib path in Matplotlib...

GitHub user AhyoungRyu opened a pull request:

    https://github.com/apache/zeppelin/pull/2220

    [Minor] Fix wrong Python lib path in Matplotlib tutorial note

    ### What is this PR for?
    There is a wrong information about Zeppelin\u2019s matplotlib backend files. It actually located under `ZEPPELIN_HOME/interpreter/lib/python/*` but tutorial note says it as `ZEPPELIN_HOME/lib/python/*`. So I corrected it.
    
    ### What type of PR is it?
    kind a typo fix 
    
    ### What is the Jira issue?
    N/A
    
    ### Screenshots (if appropriate)
     - Before 
    ![screen shot 2017-04-04 at 3 50 06 pm](https://cloud.githubusercontent.com/assets/10060731/24644505/e573d3a0-194e-11e7-826f-4022bc5e1572.png)
    
     - After
    ![screen shot 2017-04-04 at 3 50 56 pm](https://cloud.githubusercontent.com/assets/10060731/24644507/e6ae25c2-194e-11e7-91d7-f42b327d820e.png)
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/zeppelin fix/wrongPythonLibPathInTutorialNote

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2220.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2220
    
----
commit b43dc44ddd3e61e1291997fb50d38cdf50908396
Author: AhyoungRyu <fb...@hanmail.net>
Date:   2017-04-04T06:47:21Z

    Fix wrong Python lib path in tutorial note

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2220: [Minor] Fix wrong Python lib path in Matplotlib tutori...

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/2220
  
    @felixcheung Thanks! 
    Reading `ZEPPELIN_HOME` and providing full path would be better as you said, but it says "usually found in..". So I think it's not that much hard for users to understand or find the matplotlib related files. 
    <img width="1236" alt="screen shot 2017-04-05 at 1 27 19 pm" src="https://cloud.githubusercontent.com/assets/10060731/24689763/b3dfda7c-1a03-11e7-95aa-64017047074f.png">


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2220: [Minor] Fix wrong Python lib path in Matplotlib tutori...

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/2220
  
    Merge into master and branch-0.7 if there are no more comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2220: [Minor] Fix wrong Python lib path in Matplotlib...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2220


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---