You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Glenn Holmer <ce...@kolabnow.com.INVALID> on 2018/09/24 14:12:30 UTC
NETBEANS-870
I've submitted a PR to update the PostgreSQL driver:
https://github.com/apache/incubator-netbeans/pull/900
Since this is my first PR, would someone please review it to ensure that
I've submitted it properly?
--
Glenn Holmer (Linux registered user #16682)
"After the vintage season came the aftermath -- and Cenbe."
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: NETBEANS-870
Posted by Carl Mosca <ca...@gmail.com>.
Excellent, thank you Gj.
On Mon, Sep 24, 2018 at 1:50 PM Geertjan Wielenga
<ge...@googlemail.com.invalid> wrote:
> No, John McD. is right.
>
> Gj
>
> On Monday, September 24, 2018, Carl Mosca <ca...@gmail.com> wrote:
>
> > Good to know...I thought I read about a requirement for a single commit.
> >
> > On Mon, Sep 24, 2018 at 1:29 PM John McDonnell <mcdonnell.john@gmail.com
> >
> > wrote:
> >
> > > HI Glenn,
> > >
> > > I can't talk about the license as I cant see it at the
> moment(travelling)
> > > but you can continue pushing changes to your local branch, and GitHub
> > will
> > > continue to include those changes into the PR.
> > >
> > > So no need to delete the existing PR.
> > >
> > > Regards
> > >
> > > John
> > >
> > > On Mon, 24 Sep 2018 at 16:18, Glenn Holmer <cenbe@kolabnow.com.invalid
> >
> > > wrote:
> > >
> > > > On 09/24/2018 09:12 AM, Glenn Holmer wrote:
> > > > > I've submitted a PR to update the PostgreSQL driver:
> > > > > https://github.com/apache/incubator-netbeans/pull/900
> > > > >
> > > > > Since this is my first PR, would someone please review it to ensure
> > > that
> > > > > I've submitted it properly?
> > > >
> > > > I see the Travis build failed because
> > > > "ide/db.drivers/external/postgresql-42.2.5-license.txt contains a
> > > > license body which does not match that in
> > > > nbbuild/licenses/BSD-postgresql". Looks like I missed something in
> > > > VerifyLibsAndLicenses.java.
> > > >
> > > > What is the correct way to fix this? I copied the license straight
> from
> > > > the Postgres JDBC driver site. Must the one in nbbuild be replaced as
> > > > well? What is the reason for having another copy there, is it to do
> > with
> > > > Rat?
> > > >
> > > > When it's fixed, what's the proper way to correct the PR? Delete it
> and
> > > > create a new one?
> > > >
> > > > --
> > > > Glenn Holmer (Linux registered user #16682)
> > > > "After the vintage season came the aftermath -- and Cenbe."
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail:
> dev-unsubscribe@netbeans.incubator.apache.org
> > > > For additional commands, e-mail:
> > dev-help@netbeans.incubator.apache.org
> > > >
> > > > For further information about the NetBeans mailing lists, visit:
> > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> > > >
> > > >
> > > >
> > > >
> > >
> > --
> > Regards,
> > Carl
> >
>
--
Regards,
Carl
Re: NETBEANS-870
Posted by Geertjan Wielenga <ge...@googlemail.com.INVALID>.
No, John McD. is right.
Gj
On Monday, September 24, 2018, Carl Mosca <ca...@gmail.com> wrote:
> Good to know...I thought I read about a requirement for a single commit.
>
> On Mon, Sep 24, 2018 at 1:29 PM John McDonnell <mc...@gmail.com>
> wrote:
>
> > HI Glenn,
> >
> > I can't talk about the license as I cant see it at the moment(travelling)
> > but you can continue pushing changes to your local branch, and GitHub
> will
> > continue to include those changes into the PR.
> >
> > So no need to delete the existing PR.
> >
> > Regards
> >
> > John
> >
> > On Mon, 24 Sep 2018 at 16:18, Glenn Holmer <ce...@kolabnow.com.invalid>
> > wrote:
> >
> > > On 09/24/2018 09:12 AM, Glenn Holmer wrote:
> > > > I've submitted a PR to update the PostgreSQL driver:
> > > > https://github.com/apache/incubator-netbeans/pull/900
> > > >
> > > > Since this is my first PR, would someone please review it to ensure
> > that
> > > > I've submitted it properly?
> > >
> > > I see the Travis build failed because
> > > "ide/db.drivers/external/postgresql-42.2.5-license.txt contains a
> > > license body which does not match that in
> > > nbbuild/licenses/BSD-postgresql". Looks like I missed something in
> > > VerifyLibsAndLicenses.java.
> > >
> > > What is the correct way to fix this? I copied the license straight from
> > > the Postgres JDBC driver site. Must the one in nbbuild be replaced as
> > > well? What is the reason for having another copy there, is it to do
> with
> > > Rat?
> > >
> > > When it's fixed, what's the proper way to correct the PR? Delete it and
> > > create a new one?
> > >
> > > --
> > > Glenn Holmer (Linux registered user #16682)
> > > "After the vintage season came the aftermath -- and Cenbe."
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> > > For additional commands, e-mail:
> dev-help@netbeans.incubator.apache.org
> > >
> > > For further information about the NetBeans mailing lists, visit:
> > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> > >
> > >
> > >
> > >
> >
> --
> Regards,
> Carl
>
Re: NETBEANS-870
Posted by Carl Mosca <ca...@gmail.com>.
Good to know...I thought I read about a requirement for a single commit.
On Mon, Sep 24, 2018 at 1:29 PM John McDonnell <mc...@gmail.com>
wrote:
> HI Glenn,
>
> I can't talk about the license as I cant see it at the moment(travelling)
> but you can continue pushing changes to your local branch, and GitHub will
> continue to include those changes into the PR.
>
> So no need to delete the existing PR.
>
> Regards
>
> John
>
> On Mon, 24 Sep 2018 at 16:18, Glenn Holmer <ce...@kolabnow.com.invalid>
> wrote:
>
> > On 09/24/2018 09:12 AM, Glenn Holmer wrote:
> > > I've submitted a PR to update the PostgreSQL driver:
> > > https://github.com/apache/incubator-netbeans/pull/900
> > >
> > > Since this is my first PR, would someone please review it to ensure
> that
> > > I've submitted it properly?
> >
> > I see the Travis build failed because
> > "ide/db.drivers/external/postgresql-42.2.5-license.txt contains a
> > license body which does not match that in
> > nbbuild/licenses/BSD-postgresql". Looks like I missed something in
> > VerifyLibsAndLicenses.java.
> >
> > What is the correct way to fix this? I copied the license straight from
> > the Postgres JDBC driver site. Must the one in nbbuild be replaced as
> > well? What is the reason for having another copy there, is it to do with
> > Rat?
> >
> > When it's fixed, what's the proper way to correct the PR? Delete it and
> > create a new one?
> >
> > --
> > Glenn Holmer (Linux registered user #16682)
> > "After the vintage season came the aftermath -- and Cenbe."
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> > For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
> >
> > For further information about the NetBeans mailing lists, visit:
> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >
> >
> >
> >
>
--
Regards,
Carl
Re: NETBEANS-870
Posted by Glenn Holmer <ce...@kolabnow.com.INVALID>.
On 09/24/2018 12:29 PM, John McDonnell wrote:
> you can continue pushing changes to your local branch, and GitHub will
> continue to include those changes into the PR.
>
> So no need to delete the existing PR.
Thanks, good to know.
--
Glenn Holmer (Linux registered user #16682)
"After the vintage season came the aftermath -- and Cenbe."
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: NETBEANS-870
Posted by John McDonnell <mc...@gmail.com>.
HI Glenn,
I can't talk about the license as I cant see it at the moment(travelling)
but you can continue pushing changes to your local branch, and GitHub will
continue to include those changes into the PR.
So no need to delete the existing PR.
Regards
John
On Mon, 24 Sep 2018 at 16:18, Glenn Holmer <ce...@kolabnow.com.invalid>
wrote:
> On 09/24/2018 09:12 AM, Glenn Holmer wrote:
> > I've submitted a PR to update the PostgreSQL driver:
> > https://github.com/apache/incubator-netbeans/pull/900
> >
> > Since this is my first PR, would someone please review it to ensure that
> > I've submitted it properly?
>
> I see the Travis build failed because
> "ide/db.drivers/external/postgresql-42.2.5-license.txt contains a
> license body which does not match that in
> nbbuild/licenses/BSD-postgresql". Looks like I missed something in
> VerifyLibsAndLicenses.java.
>
> What is the correct way to fix this? I copied the license straight from
> the Postgres JDBC driver site. Must the one in nbbuild be replaced as
> well? What is the reason for having another copy there, is it to do with
> Rat?
>
> When it's fixed, what's the proper way to correct the PR? Delete it and
> create a new one?
>
> --
> Glenn Holmer (Linux registered user #16682)
> "After the vintage season came the aftermath -- and Cenbe."
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
NETBEANS-870
Posted by Glenn Holmer <ce...@kolabnow.com.INVALID>.
On 09/24/2018 09:12 AM, Glenn Holmer wrote:
> I've submitted a PR to update the PostgreSQL driver:
> https://github.com/apache/incubator-netbeans/pull/900
>
> Since this is my first PR, would someone please review it to ensure that
> I've submitted it properly?
I see the Travis build failed because
"ide/db.drivers/external/postgresql-42.2.5-license.txt contains a
license body which does not match that in
nbbuild/licenses/BSD-postgresql". Looks like I missed something in
VerifyLibsAndLicenses.java.
What is the correct way to fix this? I copied the license straight from
the Postgres JDBC driver site. Must the one in nbbuild be replaced as
well? What is the reason for having another copy there, is it to do with
Rat?
When it's fixed, what's the proper way to correct the PR? Delete it and
create a new one?
--
Glenn Holmer (Linux registered user #16682)
"After the vintage season came the aftermath -- and Cenbe."
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists