You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/01/08 18:12:00 UTC

[jira] [Commented] (AIRFLOW-5413) Get pod configuration from JSON or Yaml

    [ https://issues.apache.org/jira/browse/AIRFLOW-5413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010889#comment-17010889 ] 

ASF GitHub Bot commented on AIRFLOW-5413:
-----------------------------------------

davlum commented on pull request #6834: [AIRFLOW-5413] Refactor worker config
URL: https://github.com/apache/airflow/pull/6834
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-5413) issues and references them in the PR title. 
   
   ### Description
   
   - [X] This PR enables users of the K8S API to pass in pod configuration as a string, or as a path to a JSON/YAML file.
   
   ### Tests
   
   - [X] My PR adds the following unit tests.
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Get pod configuration from JSON or Yaml
> ---------------------------------------
>
>                 Key: AIRFLOW-5413
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5413
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: executor-kubernetes
>    Affects Versions: 1.10.5
>            Reporter: David Lum
>            Assignee: David Lum
>            Priority: Minor
>              Labels: kubernetes
>             Fix For: 2.0.0
>
>
> Currently the Kubernetes components of Airflow try to recreate the Kubernetes API, but don't let users pass in their own JSON or YAML. This feature would allow users to do this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)