You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/09/15 01:55:25 UTC

Review Request 62343: Made `GarbageCollector::prune` return a `Future`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62343/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Jie Yu, and Vinod Kone.


Bugs: MESOS-7939
    https://issues.apache.org/jira/browse/MESOS-7939


Repository: mesos


Description
-------

With a `Future` returned by `GarbageCollector::prune`, we are able to
make certain events (e.g., checkpointing) wait for disk GC to ensure
enough disk space.


Diffs
-----

  src/slave/gc.hpp df40165bb8a23f065156bf6c5f354b143d88c088 
  src/slave/gc.cpp 83e4e2f3aba5c0d9900cf0beeea6e92320f889e7 
  src/slave/gc_process.hpp c383ce28411622692e42401c80e9443e7b1f5099 
  src/tests/mock_slave.hpp 57189cee20511d145ae6b47a4dc2c66a14638dad 
  src/tests/mock_slave.cpp db24f9e5b71f558d2f811f0da8a9cc9c7c2dd341 


Diff: https://reviews.apache.org/r/62343/diff/1/


Testing
-------

Testing done in r/62336.


Thanks,

Chun-Hung Hsiao