You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/04/01 00:24:54 UTC

[GitHub] [samza] kw2542 opened a new pull request #1336: SAMZA-2499: Add submission config file support

kw2542 opened a new pull request #1336: SAMZA-2499: Add submission config file support
URL: https://github.com/apache/samza/pull/1336
 
 
   Feature:
   https://cwiki.apache.org/confluence/display/SAMZA/SEP-23:+Simplify+Job+Runner
   
   Changes:
   1. Add config-path option in ApplicationRunnerCommandLine.
   2. Update loadConfig() to read property file specified by config-path as submission config.
   
   Tests:
   Followed https://samza.apache.org/startup/hello-samza/latest/ to test against Hello Samza example:
   
   1. Update wikipedia-feed.properties to include the following properties:
   
   job.config.loader.factory=org.apache.samza.config.loaders.PropertiesConfigLoaderFactory
   job.config.loader.properties.path=./__package/config/wikipedia-feed.properties
   
   2. Deploy the job:
   deploy/samza/bin/run-app.sh --config-path=$PWD/deploy/samza/config/wikipedia-feed.properties
   
   API Changes:
   1. Add --config-path option support when running run-app.sh
   
   Upgrade Instructions:
   None
   
   Usage Instructions:
   Alternative way when submitting job,
   
   deploy/samza/bin/run-app.sh \
     --config app.class=A \
     --config job.stream.factory=B \
     --config yarn.package.path=C \
     --config job.config.loader.factory=D \
     --config job.config.loader.properties.xx=E \
     --config job.name=F
   
   can be simplied to
   
   deploy/samza/bin/run-app.sh --config-path=/path/to/submission/properties/file/submission.properties
   
   where submission.properties contains
   
   app.class=A
   job.stream.factory=B
   yarn.package.path=C
   job.config.loader.factory=D
   job.config.loader.properties.xx=E
   job.name=F

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [samza] cameronlee314 merged pull request #1336: SAMZA-2499: Add submission config file support

Posted by GitBox <gi...@apache.org>.
cameronlee314 merged pull request #1336: SAMZA-2499: Add submission config file support
URL: https://github.com/apache/samza/pull/1336
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services