[jira] Issue Comment Edited: (PIVOT-245) In Skin json file, add optional coefficients for darkening and brightening base colors

["Sandro Martini (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIVOT-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913304#action_12913304 ] 

Sandro Martini edited comment on PIVOT-245 at 9/21/10 7:07 PM:
---------------------------------------------------------------

This is the patch.

Note that to NOT change the static methods brighten and darken I have put the new parameter (colorMultiplier) as a static variable inside the class.

Tell me what do you think on this, and in any case you are free to apply instead of me and change (the variable name "colorMultiplier" probably is not the best).
If no objections, I'll commit the patch (but not before the end of this week).

To see that it works and what happens, try to manually changing the default value for example to 0.2 gives a more contrasted theme.

After this, I'll set the default value even in all other Pivot json themes file (currently there isn't a way to not specify it and catch the exception to leave the default value set in code).


Verify after this (for 2.1) if it's the case to check the given value in the range 0.0, 1.0 (normalized) and give an exception in case of a given wrong value.


      was (Author: smartini):
    This is the patch.

Note that to NOT change the static methods brighten and darken I have put the new parameter () static.

Tell me what do you think on this, and in any case you are free to apply instead of me and change (the variable name "colorMultiplier" probably is not the best).
If no objections, I'll commit the patch (but not before the end of this week).

To see that it works and what happens, try to manually changing the default value for example to 0.2 gives a more contrasted theme.

After this, I'll set the default value even in all other Pivot json themes file (currently there isn't a way to not specify it and catch the exception to leave the default value set in code).


Verify after this (for 2.1) if it's the case to check the given value in the range 0.0, 1.0 (normalized) and give an exception in case of a given wrong value.

  
> In Skin json file, add optional coefficients for darkening and brightening base colors
> --------------------------------------------------------------------------------------
>
>                 Key: PIVOT-245
>                 URL: https://issues.apache.org/jira/browse/PIVOT-245
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>            Reporter: Sandro Martini
>            Assignee: Sandro Martini
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: patch.txt
>
>
> Could be useful to add (also in the json file):
> optional coefficients for darkening and brightening base colors, otherwise the default of the theme (in Terra it's + / - 10%) will be used.
> Because on some color schemes the default it's not enough ... I've just seen with my dark scheme.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.