You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2022/07/13 12:43:13 UTC

[Impala-ASF-CR] IMPALA-11378: Allow INSERT OVERWRITE for bucket tranforms in some cases

Tamas Mate has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18649 )

Change subject: IMPALA-11378: Allow INSERT OVERWRITE for bucket tranforms in some cases
......................................................................

IMPALA-11378: Allow INSERT OVERWRITE for bucket tranforms in some cases

This change has been considered only for Iceberg tables mainly for table
maintenance reasons. Iceberg table writes create new snapshots and these
can accumulate over time. This commit allows a simple form of compaction
of these snapshots, later the old snapshots can be expired.

All types of INSERT OVERWRITES have been blocked in case partition
evolution is in place, to avoid unexpected data loss.

For bucketed tables, the following syntax is allowed to be executed:
  INSERT OVERWRITE ice_tbl SELECT * FROM ice_tbl;
The source and target table has to be the same and specified, only
SELECT '*' select_queries are allowed. These requirements are also in
place to avoid unexpected data loss.

Testing:
 - Added e2e tests.

Change-Id: Ibd1bc19d839297246eadeb754cdeeec1e306098a
---
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-overwrite.test
3 files changed, 88 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/18649/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18649
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibd1bc19d839297246eadeb754cdeeec1e306098a
Gerrit-Change-Number: 18649
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>