You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/06 02:11:18 UTC
[GitHub] [apisix-dashboard] batman-ezio opened a new pull request #1710: feature: duplicate upstream service consumer
batman-ezio opened a new pull request #1710:
URL: https://github.com/apache/apisix-dashboard/pull/1710
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Add duplicate feature to upstream, service and consumer, just like the feature in route
**Related issues**
fix/resolve #1487
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [x] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1710: feat: duplicate upstream service consumer
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1710:
URL: https://github.com/apache/apisix-dashboard/pull/1710#discussion_r618901666
##########
File path: web/cypress/integration/consumer/create-edit-duplicate-and-delete-consumer.spec.js
##########
@@ -58,6 +58,70 @@ context('Create and Delete Consumer', () => {
cy.get(this.domSelector.notification).should('contain', this.data.createConsumerSuccess);
});
+ it('should edit the consumer', function () {
+ cy.visit('/consumer/list');
+
+ cy.contains('Search').click();
+ cy.get(this.domSelector.nameSelector).type(this.data.consumerName);
+ cy.contains(this.data.consumerName).siblings().contains('Configure').click();
+ cy.get(this.domSelector.description).clear().type(this.data.description2);
+ cy.contains('button', 'Next').click();
+ // plugin config
+ cy.contains(this.domSelector.pluginCard, 'key-auth').within(() => {
+ cy.contains('Enable').click({
+ force: true,
+ });
+ });
+ cy.focused(this.domSelector.drawer).should('exist');
+ // edit codemirror
+ cy.get(this.domSelector.codeMirror)
+ .first()
+ .then((editor) => {
+ editor[0].CodeMirror.setValue(
+ JSON.stringify({
+ key: 'test',
+ }),
+ );
+ cy.contains('button', 'Submit').click();
+ });
+ cy.contains('button', 'Next').click();
+ cy.contains('button', 'Submit').click();
+ cy.get(this.domSelector.notification).should('contain', this.data.updateConsumerSuccess);
+
+ });
+
+ it('should duplicate the consumer', function () {
+ cy.visit('/consumer/list');
+
+ cy.contains('Search').click();
+ cy.get(this.domSelector.nameSelector).type(this.data.consumerName);
+ cy.contains(this.data.consumerName).siblings().contains('Duplicate').click();
+ cy.get(this.domSelector.username).type(this.data.consumerName2);
Review comment:
it would be better to add a assert about default username is empty when duplicate a consumer.
##########
File path: web/src/pages/Upstream/locales/zh-CN.ts
##########
@@ -88,6 +88,7 @@ export default {
'page.upstream.list.edit.time': '更新时间',
'page.upstream.list.operation': '操作',
'page.upstream.list.edit': '配置',
+ 'page.upstream.list.duplicate': '复制',
Review comment:
we already have a global i18n key `component.global.duplicate` for duplicate button, it would be better to reuse it
##########
File path: web/cypress/integration/service/create-edit-duplicate-delete-service.spec.js
##########
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/* eslint-disable no-undef */
+
+context('Create and Delete Service ', () => {
+ const timeout = 5000;
+
+ beforeEach(() => {
+ cy.login();
+
+ cy.fixture('selector.json').as('domSelector');
+ cy.fixture('data.json').as('data');
+ });
+
+ it('should create service', function () {
+ cy.visit('/');
+ cy.contains('Service').click();
+ cy.contains('Create').click();
+
+ cy.get(this.domSelector.name).type(this.data.serviceName);
+ cy.get(this.domSelector.description).type(this.data.description);
+ cy.get(this.domSelector.nodes_0_host).click();
+ cy.get(this.domSelector.nodes_0_host).type(this.data.ip1);
+
+ cy.contains('Next').click();
+
+ cy.contains(this.data.basicAuthPlugin).parents(this.domSelector.pluginCardBordered).within(() => {
+ cy.get('button').click({ force: true });
+ });
+
+ cy.get(this.domSelector.drawer).should('be.visible').within(() => {
+ cy.get(this.domSelector.disabledSwitcher).click();
+ cy.get(this.domSelector.checkedSwitcher).should('exist');
+ });
+
+ cy.contains('button', 'Submit').click();
+ cy.get(this.domSelector.drawer, { timeout }).should('not.exist');
+
+ cy.contains(this.data.basicAuthPlugin).parents(this.domSelector.pluginCardBordered).within(() => {
+ cy.get('button').click({ force: true });
+ });
+
+ cy.get(this.domSelector.drawerFooter).contains('button', 'Delete').click({ force: true });
+ cy.contains('button', 'Confirm').click({ force: true });
+
+ cy.contains(this.data.basicAuthPlugin).parents(this.domSelector.pluginCardBordered).within(() => {
+ cy.get('button').click({ force: true });
+ });
+
+ cy.get(this.domSelector.drawerFooter).contains('button', 'Delete').should('not.exist');
+ cy.contains('button', 'Cancel').click({ force: true });
+
+ cy.contains('Next').click();
+ cy.contains('Submit').click();
+ cy.get(this.domSelector.notification).should('contain', this.data.createServiceSuccess);
+ });
+
+ it('should view the service', function () {
+ cy.visit('/');
+ cy.contains('Service').click();
+
+ cy.get(this.domSelector.nameSelector).type(this.data.serviceName);
+ cy.contains('Search').click();
+ cy.contains(this.data.serviceName).siblings().contains('View').click();
+ cy.get(this.domSelector.drawer).should('be.visible');
+
+ cy.get(this.domSelector.codemirrorScroll).within(() => {
+ cy.contains('upstream').should('exist');
+ cy.contains(this.data.serviceName).should('exist');
+ });
+ });
+
+ it('should edit the service', function () {
+ cy.visit('/');
+ cy.contains('Service').click();
+
+ cy.get(this.domSelector.nameSelector).type(this.data.serviceName);
+ cy.contains('Search').click();
+ cy.contains(this.data.serviceName).siblings().contains('Configure').click();
+
+ // Confirm whether the created data is saved.
+ cy.get(this.domSelector.nodes_0_host).should('value', this.data.ip1);
+ cy.get(this.domSelector.description).should('value', this.data.description);
+ cy.get(this.domSelector.name).clear().type(this.data.serviceName2);
+ cy.get(this.domSelector.description).clear().type(this.data.description2);
+ cy.get(this.domSelector.nodes_0_host).click();
+ cy.get(this.domSelector.nodes_0_host).clear().type(this.data.ip2);
+ cy.contains('Next').click();
+ cy.contains('Next').click();
+ cy.contains('Submit').click();
+ cy.get(this.domSelector.notification).should('contain', this.data.editServiceSuccess);
+
+ // test view
+ cy.contains(this.data.serviceName2).siblings().contains('View').click();
+ cy.get(this.domSelector.drawer).should('be.visible');
+
+ cy.get(this.domSelector.codemirrorScroll).within(() => {
+ cy.contains('upstream').should('exist');
+ cy.contains(this.data.serviceName2).should('exist');
+ });
+ });
+
+ it('should duplicate the service', function () {
+ cy.visit('/');
+ cy.contains('Service').click();
+
+ cy.get(this.domSelector.nameSelector).type(this.data.serviceName2);
+ cy.contains('Search').click();
+ cy.contains(this.data.serviceName2).siblings().contains('Duplicate').click();
+ cy.get(this.domSelector.name).clear().type(this.data.serviceName3);
Review comment:
it would be better to assert about default service name is empty when duplicate a service.
##########
File path: web/cypress/integration/consumer/create-edit-duplicate-and-delete-consumer.spec.js
##########
@@ -58,6 +58,70 @@ context('Create and Delete Consumer', () => {
cy.get(this.domSelector.notification).should('contain', this.data.createConsumerSuccess);
});
+ it('should edit the consumer', function () {
+ cy.visit('/consumer/list');
+
+ cy.contains('Search').click();
+ cy.get(this.domSelector.nameSelector).type(this.data.consumerName);
+ cy.contains(this.data.consumerName).siblings().contains('Configure').click();
+ cy.get(this.domSelector.description).clear().type(this.data.description2);
+ cy.contains('button', 'Next').click();
+ // plugin config
+ cy.contains(this.domSelector.pluginCard, 'key-auth').within(() => {
+ cy.contains('Enable').click({
+ force: true,
+ });
+ });
+ cy.focused(this.domSelector.drawer).should('exist');
+ // edit codemirror
+ cy.get(this.domSelector.codeMirror)
+ .first()
+ .then((editor) => {
+ editor[0].CodeMirror.setValue(
+ JSON.stringify({
+ key: 'test',
+ }),
+ );
+ cy.contains('button', 'Submit').click();
+ });
+ cy.contains('button', 'Next').click();
+ cy.contains('button', 'Submit').click();
+ cy.get(this.domSelector.notification).should('contain', this.data.updateConsumerSuccess);
+
+ });
+
+ it('should duplicate the consumer', function () {
+ cy.visit('/consumer/list');
+
+ cy.contains('Search').click();
+ cy.get(this.domSelector.nameSelector).type(this.data.consumerName);
+ cy.contains(this.data.consumerName).siblings().contains('Duplicate').click();
+ cy.get(this.domSelector.username).type(this.data.consumerName2);
+ cy.contains('button', 'Next').click();
+ // plugin config
+ cy.contains(this.domSelector.pluginCard, 'key-auth').within(() => {
+ cy.contains('Enable').click({
+ force: true,
+ });
+ });
+ cy.focused(this.domSelector.drawer).should('exist');
+ // edit codemirror
+ cy.get(this.domSelector.codeMirror)
Review comment:
it would be better to add assert about the default `key-auth` setting is the same with the original one when duplicate a consumer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1710: feat: duplicate upstream service consumer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1710:
URL: https://github.com/apache/apisix-dashboard/pull/1710#issuecomment-813794509
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=h1) Report
> Merging [#1710](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=desc) (374e36e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8494e45a94f3afc40dbd44f562ea09f7baf0fd46?el=desc) (8494e45) will **decrease** coverage by `0.47%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1710 +/- ##
==========================================
- Coverage 71.87% 71.40% -0.48%
==========================================
Files 130 47 -83
Lines 5660 3126 -2534
Branches 661 0 -661
==========================================
- Hits 4068 2232 -1836
+ Misses 1352 650 -702
- Partials 240 244 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `62.15% <ø> (+0.06%)` | :arrow_up: |
| backend-e2e-test-ginkgo | `48.30% <ø> (-0.07%)` | :arrow_down: |
| backend-unit-test | `52.29% <ø> (ø)` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `86.74% <0.00%> (-1.21%)` | :arrow_down: |
| [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `33.33% <0.00%> (ø)` | |
| [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `45.45% <0.00%> (ø)` | |
| [web/src/access.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-d2ViL3NyYy9hY2Nlc3MudHM=) | | |
| [web/src/components/HeaderDropdown/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL0hlYWRlckRyb3Bkb3duL2luZGV4LnRzeA==) | | |
| [...ages/Route/components/Step2/RequestRewriteView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAyL1JlcXVlc3RSZXdyaXRlVmlldy50c3g=) | | |
| [web/src/services/user.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-d2ViL3NyYy9zZXJ2aWNlcy91c2VyLnRz) | | |
| [web/src/pages/Upstream/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS90cmFuc2Zvcm0udHM=) | | |
| [web/src/pages/Consumer/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9zZXJ2aWNlLnRz) | | |
| [web/src/components/IconFont/IconFont.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL0ljb25Gb250L0ljb25Gb250LnRzeA==) | | |
| ... and [71 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=footer). Last update [8494e45...374e36e](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1710: feat: duplicate upstream service consumer
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1710:
URL: https://github.com/apache/apisix-dashboard/pull/1710#issuecomment-823973770
Conflicting, please resolve it , thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1710: feat: duplicate upstream service consumer
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1710:
URL: https://github.com/apache/apisix-dashboard/pull/1710#issuecomment-818368730
Deploy preview for *apisix-dashboard* ready!
Built with commit 2493762405d3ea1ff9014d5618e6c7f8a79aaed2
https://deploy-preview-1710--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1710: feat: duplicate upstream service consumer
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1710:
URL: https://github.com/apache/apisix-dashboard/pull/1710#issuecomment-818368730
Deploy preview for *apisix-dashboard* processing.
Building with commit 5bde2d483d7d7c183cf99c26471615066511e440
https://app.netlify.com/sites/apisix-dashboard/deploys/6074f6c6bd48450008bb8ba1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1710: feat: duplicate upstream service consumer
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1710:
URL: https://github.com/apache/apisix-dashboard/pull/1710#issuecomment-814194903
wow! good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1710: feat: duplicate upstream service consumer
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1710:
URL: https://github.com/apache/apisix-dashboard/pull/1710#issuecomment-818368730
Deploy preview for *apisix-dashboard* processing.
Building with commit 2493762405d3ea1ff9014d5618e6c7f8a79aaed2
https://app.netlify.com/sites/apisix-dashboard/deploys/6076c887f6ada300088ca4ce
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #1710: feat: duplicate upstream service consumer
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #1710:
URL: https://github.com/apache/apisix-dashboard/pull/1710#discussion_r713595267
##########
File path: web/src/pages/Upstream/locales/en-US.ts
##########
@@ -88,6 +88,7 @@ export default {
'page.upstream.list.edit.time': 'Updated At',
'page.upstream.list.operation': 'Operation',
'page.upstream.list.edit': 'Configure',
+ 'page.upstream.list.duplicate': 'Duplicate',
Review comment:
```suggestion
```
##########
File path: web/src/pages/Upstream/locales/zh-CN.ts
##########
@@ -88,6 +88,7 @@ export default {
'page.upstream.list.edit.time': '更新时间',
'page.upstream.list.operation': '操作',
'page.upstream.list.edit': '配置',
+ 'page.upstream.list.duplicate': '复制',
Review comment:
```suggestion
```
##########
File path: web/src/pages/Upstream/List.tsx
##########
@@ -92,6 +92,12 @@ const Page: React.FC = () => {
}}>
{formatMessage({ id: 'component.global.view' })}
</Button>
+ <Button
+ type="primary"
+ onClick={() => history.push(`/upstream/${record.id}/duplicate`)}
+ >
+ {formatMessage({ id: 'page.upstream.list.duplicate' })}
Review comment:
```suggestion
{formatMessage({ id: 'component.global.duplicate' })}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1710: feat: duplicate upstream service consumer
Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #1710:
URL: https://github.com/apache/apisix-dashboard/pull/1710#discussion_r618998603
##########
File path: web/src/pages/Upstream/Create.tsx
##########
@@ -30,13 +30,19 @@ const Page: React.FC = (props) => {
const [form1] = Form.useForm();
const { formatMessage } = useIntl();
const upstreamRef = useRef<any>();
+ const isDuplicate = (props as any).route.path.split('/').slice(-1)[0] === 'duplicate';
useEffect(() => {
const { id } = (props as any).match.params;
if (id) {
fetchOne(id).then((data) => {
form1.setFieldsValue(data.data);
+ if (isDuplicate) {
+ form1.setFieldsValue({
+ 'name': ''
Review comment:
```suggestion
name: ''
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] github-actions[bot] commented on pull request #1710: feat: duplicate upstream service consumer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1710:
URL: https://github.com/apache/apisix-dashboard/pull/1710#issuecomment-974787536
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time ordiscuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1710: feat: duplicate upstream service consumer
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1710:
URL: https://github.com/apache/apisix-dashboard/pull/1710#issuecomment-818368730
Deploy preview for *apisix-dashboard* ready!
Built with commit 5bde2d483d7d7c183cf99c26471615066511e440
https://deploy-preview-1710--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1710: feat: duplicate upstream service consumer
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1710:
URL: https://github.com/apache/apisix-dashboard/pull/1710#issuecomment-814195469
also cc @guoqqqi @iamayushdas @KishaniKandasamy and more contributors to review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] github-actions[bot] commented on pull request #1710: feat: duplicate upstream service consumer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1710:
URL: https://github.com/apache/apisix-dashboard/pull/1710#issuecomment-997777773
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] github-actions[bot] closed pull request #1710: feat: duplicate upstream service consumer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1710:
URL: https://github.com/apache/apisix-dashboard/pull/1710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1710: feat: duplicate upstream service consumer
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1710:
URL: https://github.com/apache/apisix-dashboard/pull/1710#issuecomment-813794509
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=h1) Report
> Merging [#1710](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=desc) (374e36e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8494e45a94f3afc40dbd44f562ea09f7baf0fd46?el=desc) (8494e45) will **decrease** coverage by `19.57%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1710 +/- ##
===========================================
- Coverage 71.87% 52.29% -19.58%
===========================================
Files 130 38 -92
Lines 5660 2660 -3000
Branches 661 0 -661
===========================================
- Hits 4068 1391 -2677
+ Misses 1352 1081 -271
+ Partials 240 188 -52
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `52.29% <ø> (ø)` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: |
| [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
| [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: |
| [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| ... and [110 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=footer). Last update [8494e45...374e36e](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1710: feat: duplicate upstream service consumer
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1710:
URL: https://github.com/apache/apisix-dashboard/pull/1710#issuecomment-813794509
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=h1) Report
> Merging [#1710](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=desc) (374e36e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8494e45a94f3afc40dbd44f562ea09f7baf0fd46?el=desc) (8494e45) will **decrease** coverage by `4.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1710 +/- ##
==========================================
- Coverage 71.87% 67.56% -4.32%
==========================================
Files 130 47 -83
Lines 5660 3126 -2534
Branches 661 0 -661
==========================================
- Hits 4068 2112 -1956
+ Misses 1352 768 -584
- Partials 240 246 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `48.30% <ø> (-0.07%)` | :arrow_down: |
| backend-unit-test | `52.29% <ø> (ø)` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `35.08% <0.00%> (-29.84%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: |
| [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: |
| [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `76.47% <0.00%> (-8.83%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `67.28% <0.00%> (-3.74%)` | :arrow_down: |
| [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `41.81% <0.00%> (-3.64%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `52.10% <0.00%> (-3.37%)` | :arrow_down: |
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `67.03% <0.00%> (-2.24%)` | :arrow_down: |
| [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `80.18% <0.00%> (-1.89%)` | :arrow_down: |
| ... and [80 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1710/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=footer). Last update [8494e45...374e36e](https://codecov.io/gh/apache/apisix-dashboard/pull/1710?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] github-actions[bot] commented on pull request #1710: feat: duplicate upstream service consumer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1710:
URL: https://github.com/apache/apisix-dashboard/pull/1710#issuecomment-974787536
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time ordiscuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org