[GitHub] [beam] damccorm commented on a diff in pull request #21916: [21709] - Fix for "beam_PostCommit_Java_ValidatesRunner_Samza Failing"

[GitBox <gi...@apache.org>]

damccorm commented on code in PR #21916:
URL: https://github.com/apache/beam/pull/21916#discussion_r899335188


##########
runners/samza/build.gradle:
##########
@@ -110,6 +110,8 @@ def sickbayTests = [
         'org.apache.beam.sdk.coders.PCollectionCustomCoderTest.testEncodingIOException',
         'org.apache.beam.sdk.coders.PCollectionCustomCoderTest.testDecodingNPException',
         'org.apache.beam.sdk.coders.PCollectionCustomCoderTest.testDecodingIOException',
+        // https://issues.apache.org/jira/browse/BEAM-6354
+        'org.apache.beam.sdk.io.BoundedReadFromUnboundedSourceTest.testTimeBound',

Review Comment:
   Is there an example of this failing in CI/how did we discover this issue? If there is, could you link it in the PR description?



##########
runners/samza/build.gradle:
##########
@@ -110,6 +110,8 @@ def sickbayTests = [
         'org.apache.beam.sdk.coders.PCollectionCustomCoderTest.testEncodingIOException',
         'org.apache.beam.sdk.coders.PCollectionCustomCoderTest.testDecodingNPException',
         'org.apache.beam.sdk.coders.PCollectionCustomCoderTest.testDecodingIOException',
+        // https://issues.apache.org/jira/browse/BEAM-6354

Review Comment:
   ```suggestion
           // https://github.com/apache/beam/issues/19344
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org