You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/04/21 04:13:50 UTC

[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #1719: [Bug][IT]Fix it run problem in windows

ruanwenjun commented on code in PR #1719:
URL: https://github.com/apache/incubator-seatunnel/pull/1719#discussion_r854758833


##########
seatunnel-e2e/seatunnel-spark-e2e/src/test/java/org/apache/seatunnel/e2e/spark/SparkContainer.java:
##########
@@ -84,6 +85,8 @@ public Container.ExecResult executeSeaTunnelSparkJob(String confFile) throws IOE
         master.copyFileToContainer(MountableFile.forHostPath(confPath), targetConfInContainer);
 
         // TODO: use start-seatunnel-spark.sh to run the spark job. Need to modified the SparkStarter can find the seatunnel-core-spark.jar.
+        String jar = SPARK_JAR_PATH.replaceAll("\\\\", "/");
+        String conf = targetConfInContainer.replaceAll("\\\\", "/");

Review Comment:
   Please add a comment, why you need to do a replacement here, e.g. `we need to replase the \\ due to campatible with Windows`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org