You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/12 20:29:20 UTC
[GitHub] [superset] codecov-io edited a comment on pull request #12104: fix: scroll top when drag element over dashboard's header
codecov-io edited a comment on pull request #12104:
URL: https://github.com/apache/superset/pull/12104#issuecomment-747732864
# [Codecov](https://codecov.io/gh/apache/superset/pull/12104?src=pr&el=h1) Report
> Merging [#12104](https://codecov.io/gh/apache/superset/pull/12104?src=pr&el=desc) (3a70fa9) into [master](https://codecov.io/gh/apache/superset/commit/a3bbbf8ea33fbec5a58fc07f56d2fd8fdf30135f?el=desc) (a3bbbf8) will **decrease** coverage by `0.31%`.
> The diff coverage is `53.33%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12104/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12104?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12104 +/- ##
==========================================
- Coverage 67.11% 66.79% -0.32%
==========================================
Files 996 531 -465
Lines 49176 22300 -26876
Branches 4993 6099 +1106
==========================================
- Hits 33006 14896 -18110
+ Misses 16047 7262 -8785
- Partials 123 142 +19
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.38% <53.33%> (+0.08%)` | :arrow_up: |
| javascript | `60.72% <13.33%> (-0.39%)` | :arrow_down: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12104?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ntend/src/dashboard/components/dnd/handleScroll.js](https://codecov.io/gh/apache/superset/pull/12104/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwuanM=) | `40.00% <40.00%> (ø)` | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12104/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.42% <66.66%> (+0.36%)` | :arrow_up: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/superset/pull/12104/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/superset/pull/12104/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `48.00% <0.00%> (-52.00%)` | :arrow_down: |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/12104/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/12104/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `70.58% <0.00%> (-29.42%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/12104/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `50.00% <0.00%> (-28.58%)` | :arrow_down: |
| [...end/src/dashboard/components/StickyVerticalBar.tsx](https://codecov.io/gh/apache/superset/pull/12104/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1N0aWNreVZlcnRpY2FsQmFyLnRzeA==) | `72.72% <0.00%> (-27.28%)` | :arrow_down: |
| [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/superset/pull/12104/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `55.59% <0.00%> (-26.50%)` | :arrow_down: |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/12104/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `58.13% <0.00%> (-25.20%)` | :arrow_down: |
| ... and [595 more](https://codecov.io/gh/apache/superset/pull/12104/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12104?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12104?src=pr&el=footer). Last update [a3bbbf8...3a70fa9](https://codecov.io/gh/apache/superset/pull/12104?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org