[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25375: [SPARK-28642][SQL] Hide credentials in SHOW CREATE TABLE

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #25375: [SPARK-28642][SQL] Hide credentials in SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/25375#discussion_r312248271
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
 ##########
 @@ -1029,6 +1030,32 @@ class JDBCSuite extends QueryTest
     }
   }
 
+  test("Hide credentials in show create table") {
+    val password = "testPass"
+    val tableName = "tab1"
+    withTable(tableName) {
+      val df = sql(
 
 Review comment:
   Shall we remove `val df = ` since this is not required here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org