You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2013/01/11 06:37:53 UTC
[v2] Add missing serial version IDs?
Hi All:
Many classes are missing serial version IDs.
Should we add them now?
If no, why not?
If yes, what should the value be? The usual default of -1 or a generated ID?
Gary
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [v2] Add missing serial version IDs?
Posted by Ralph Goers <ra...@dslextreme.com>.
;-}
Ralph
On Jan 10, 2013, at 10:46 PM, Gary Gregory wrote:
> When in doubt, JIRA! https://issues.apache.org/jira/browse/LOG4J2-145
>
> Gary
>
>
> On Fri, Jan 11, 2013 at 1:28 AM, Gary Gregory <ga...@gmail.com> wrote:
> Does this warrant a JIRA?
>
> Gary
>
>
> On Fri, Jan 11, 2013 at 1:15 AM, Ralph Goers <ra...@dslextreme.com> wrote:
> Yes. Anything that is Serializable should have an id. I know Eclipse will generate them but I don't use Eclipse. I believe IntelliJ will too but I've never been able to get it to do it. Not a fan of -1.
>
> Ralph
>
> On Jan 10, 2013, at 9:37 PM, Gary Gregory wrote:
>
>> Hi All:
>>
>> Many classes are missing serial version IDs.
>>
>> Should we add them now?
>>
>> If no, why not?
>>
>> If yes, what should the value be? The usual default of -1 or a generated ID?
>>
>> Gary
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
>> Spring Batch in Action: http://bit.ly/bqpbCK
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
> Spring Batch in Action: http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
> Spring Batch in Action: http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
Re: [v2] Add missing serial version IDs?
Posted by Gary Gregory <ga...@gmail.com>.
When in doubt, JIRA! https://issues.apache.org/jira/browse/LOG4J2-145
Gary
On Fri, Jan 11, 2013 at 1:28 AM, Gary Gregory <ga...@gmail.com>wrote:
> Does this warrant a JIRA?
>
> Gary
>
>
> On Fri, Jan 11, 2013 at 1:15 AM, Ralph Goers <ra...@dslextreme.com>wrote:
>
>> Yes. Anything that is Serializable should have an id. I know Eclipse
>> will generate them but I don't use Eclipse. I believe IntelliJ will too but
>> I've never been able to get it to do it. Not a fan of -1.
>>
>> Ralph
>>
>> On Jan 10, 2013, at 9:37 PM, Gary Gregory wrote:
>>
>> Hi All:
>>
>> Many classes are missing serial version IDs.
>>
>> Should we add them now?
>>
>> If no, why not?
>>
>> If yes, what should the value be? The usual default of -1 or a generated
>> ID?
>>
>> Gary
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> JUnit in Action, 2nd Ed: <http://goog_1249600977/>http://bit.ly/ECvg0
>> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [v2] Add missing serial version IDs?
Posted by Ralph Goers <ra...@dslextreme.com>.
I probably wouldn't make one. It hasn't caused a problem and I really wouldn't call it a new feature. How many classes did I miss?
Ralph
On Jan 10, 2013, at 10:28 PM, Gary Gregory wrote:
> Does this warrant a JIRA?
>
> Gary
>
>
> On Fri, Jan 11, 2013 at 1:15 AM, Ralph Goers <ra...@dslextreme.com> wrote:
> Yes. Anything that is Serializable should have an id. I know Eclipse will generate them but I don't use Eclipse. I believe IntelliJ will too but I've never been able to get it to do it. Not a fan of -1.
>
> Ralph
>
> On Jan 10, 2013, at 9:37 PM, Gary Gregory wrote:
>
>> Hi All:
>>
>> Many classes are missing serial version IDs.
>>
>> Should we add them now?
>>
>> If no, why not?
>>
>> If yes, what should the value be? The usual default of -1 or a generated ID?
>>
>> Gary
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
>> Spring Batch in Action: http://bit.ly/bqpbCK
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
> Spring Batch in Action: http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
Re: [v2] Add missing serial version IDs?
Posted by Gary Gregory <ga...@gmail.com>.
Does this warrant a JIRA?
Gary
On Fri, Jan 11, 2013 at 1:15 AM, Ralph Goers <ra...@dslextreme.com>wrote:
> Yes. Anything that is Serializable should have an id. I know Eclipse will
> generate them but I don't use Eclipse. I believe IntelliJ will too but I've
> never been able to get it to do it. Not a fan of -1.
>
> Ralph
>
> On Jan 10, 2013, at 9:37 PM, Gary Gregory wrote:
>
> Hi All:
>
> Many classes are missing serial version IDs.
>
> Should we add them now?
>
> If no, why not?
>
> If yes, what should the value be? The usual default of -1 or a generated
> ID?
>
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: <http://goog_1249600977/>http://bit.ly/ECvg0
> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [v2] Add missing serial version IDs?
Posted by Joern Huxhorn <jh...@googlemail.com>.
You need to configure your IDEA inspections accordingly.
See http://germanogiudici.wordpress.com/2011/09/16/how-to-generate-serialversionuid-with-intellij-idea-no-external-plugin-needed/ - that way, a Serializable without a serialVersionUID will get a yellow warning and Alt-Enter creation of it.
Never understood why this is disabled by default.
Joern
On 11.01.2013, at 07:15, Ralph Goers <ra...@dslextreme.com> wrote:
> Yes. Anything that is Serializable should have an id. I know Eclipse will generate them but I don't use Eclipse. I believe IntelliJ will too but I've never been able to get it to do it. Not a fan of -1.
>
> Ralph
>
> On Jan 10, 2013, at 9:37 PM, Gary Gregory wrote:
>
>> Hi All:
>>
>> Many classes are missing serial version IDs.
>>
>> Should we add them now?
>>
>> If no, why not?
>>
>> If yes, what should the value be? The usual default of -1 or a generated ID?
>>
>> Gary
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
>> Spring Batch in Action: http://bit.ly/bqpbCK
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: [v2] Add missing serial version IDs?
Posted by Ralph Goers <ra...@dslextreme.com>.
Yes. Anything that is Serializable should have an id. I know Eclipse will generate them but I don't use Eclipse. I believe IntelliJ will too but I've never been able to get it to do it. Not a fan of -1.
Ralph
On Jan 10, 2013, at 9:37 PM, Gary Gregory wrote:
> Hi All:
>
> Many classes are missing serial version IDs.
>
> Should we add them now?
>
> If no, why not?
>
> If yes, what should the value be? The usual default of -1 or a generated ID?
>
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
> Spring Batch in Action: http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory