You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Tom Bentley <tb...@redhat.com> on 2020/07/06 08:14:29 UTC
[VOTE] KIP-621: Deprecate and replace DescribeLogDirsResult.all() and .values()
Hi,
I'd like to start a vote on KIP-621 which is about deprecating methods in
DescribeLogDirsResult which leak internal classes, replacing them with
public API classes.
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158862109
Thanks,
Tom
Re: [VOTE] KIP-621: Deprecate and replace DescribeLogDirsResult.all()
and .values()
Posted by Tom Bentley <tb...@redhat.com>.
Thanks Dongjin, I was hoping to close the vote, but was waiting till we had
consensus around the points you raised on the discussion thread.
On Fri, Jul 10, 2020 at 2:39 PM Dongjin Lee <do...@apache.org> wrote:
> +1. (non-binding)
>
> As of present, it has 3 bindings (Colin, Manikumar, and Mickael) and 2
> non-bindings (David, Dongjin).
>
> Since it has 3 binding +1 votes and more binding +1 votes than -1 votes,
> this KIP is accepted.
>
> Thanks everyone for the votes.
>
> On Thu, Jul 9, 2020 at 6:19 PM Mickael Maison <mi...@gmail.com>
> wrote:
>
> > +1 (binding)
> > Thanks
> >
> > On Thu, Jul 9, 2020 at 9:11 AM David Jacot <dj...@confluent.io> wrote:
> > >
> > > I couldn't think of a better alternative either. Thanks for the KIP!
> > >
> > > +1 (non-binding)
> > >
> > > On Wed, Jul 8, 2020 at 12:42 PM Manikumar <ma...@gmail.com>
> > wrote:
> > >
> > > > +1 (binding)
> > > >
> > > > Thanks for the KIP.
> > > >
> > > > On Tue, Jul 7, 2020 at 8:19 PM Colin McCabe <cm...@apache.org>
> > wrote:
> > > >
> > > > > Thanks, Tom.
> > > > >
> > > > > I tried to think of a better way to do this, but I think you're
> right
> > > > that
> > > > > we probably just need different methods.
> > > > >
> > > > > +1 (binding).
> > > > >
> > > > > best,
> > > > > Colin
> > > > >
> > > > > On Mon, Jul 6, 2020, at 01:14, Tom Bentley wrote:
> > > > > > Hi,
> > > > > >
> > > > > > I'd like to start a vote on KIP-621 which is about deprecating
> > methods
> > > > in
> > > > > > DescribeLogDirsResult which leak internal classes, replacing them
> > with
> > > > > > public API classes.
> > > > > >
> > > > > >
> > > > >
> > > >
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158862109
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > Tom
> > > > > >
> > > > >
> > > >
> >
>
>
> --
> *Dongjin Lee*
>
> *A hitchhiker in the mathematical world.*
>
>
>
>
> *github: <http://goog_969573159/>github.com/dongjinleekr
> <https://github.com/dongjinleekr>keybase: https://keybase.io/dongjinleekr
> <https://keybase.io/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr
> <https://kr.linkedin.com/in/dongjinleekr>speakerdeck:
> speakerdeck.com/dongjin
> <https://speakerdeck.com/dongjin>*
>
Re: [VOTE] KIP-621: Deprecate and replace DescribeLogDirsResult.all()
and .values()
Posted by Dongjin Lee <do...@apache.org>.
+1. (non-binding)
As of present, it has 3 bindings (Colin, Manikumar, and Mickael) and 2
non-bindings (David, Dongjin).
Since it has 3 binding +1 votes and more binding +1 votes than -1 votes,
this KIP is accepted.
Thanks everyone for the votes.
On Thu, Jul 9, 2020 at 6:19 PM Mickael Maison <mi...@gmail.com>
wrote:
> +1 (binding)
> Thanks
>
> On Thu, Jul 9, 2020 at 9:11 AM David Jacot <dj...@confluent.io> wrote:
> >
> > I couldn't think of a better alternative either. Thanks for the KIP!
> >
> > +1 (non-binding)
> >
> > On Wed, Jul 8, 2020 at 12:42 PM Manikumar <ma...@gmail.com>
> wrote:
> >
> > > +1 (binding)
> > >
> > > Thanks for the KIP.
> > >
> > > On Tue, Jul 7, 2020 at 8:19 PM Colin McCabe <cm...@apache.org>
> wrote:
> > >
> > > > Thanks, Tom.
> > > >
> > > > I tried to think of a better way to do this, but I think you're right
> > > that
> > > > we probably just need different methods.
> > > >
> > > > +1 (binding).
> > > >
> > > > best,
> > > > Colin
> > > >
> > > > On Mon, Jul 6, 2020, at 01:14, Tom Bentley wrote:
> > > > > Hi,
> > > > >
> > > > > I'd like to start a vote on KIP-621 which is about deprecating
> methods
> > > in
> > > > > DescribeLogDirsResult which leak internal classes, replacing them
> with
> > > > > public API classes.
> > > > >
> > > > >
> > > >
> > >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158862109
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Tom
> > > > >
> > > >
> > >
>
--
*Dongjin Lee*
*A hitchhiker in the mathematical world.*
*github: <http://goog_969573159/>github.com/dongjinleekr
<https://github.com/dongjinleekr>keybase: https://keybase.io/dongjinleekr
<https://keybase.io/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr
<https://kr.linkedin.com/in/dongjinleekr>speakerdeck: speakerdeck.com/dongjin
<https://speakerdeck.com/dongjin>*
Re: [VOTE] KIP-621: Deprecate and replace DescribeLogDirsResult.all()
and .values()
Posted by Mickael Maison <mi...@gmail.com>.
+1 (binding)
Thanks
On Thu, Jul 9, 2020 at 9:11 AM David Jacot <dj...@confluent.io> wrote:
>
> I couldn't think of a better alternative either. Thanks for the KIP!
>
> +1 (non-binding)
>
> On Wed, Jul 8, 2020 at 12:42 PM Manikumar <ma...@gmail.com> wrote:
>
> > +1 (binding)
> >
> > Thanks for the KIP.
> >
> > On Tue, Jul 7, 2020 at 8:19 PM Colin McCabe <cm...@apache.org> wrote:
> >
> > > Thanks, Tom.
> > >
> > > I tried to think of a better way to do this, but I think you're right
> > that
> > > we probably just need different methods.
> > >
> > > +1 (binding).
> > >
> > > best,
> > > Colin
> > >
> > > On Mon, Jul 6, 2020, at 01:14, Tom Bentley wrote:
> > > > Hi,
> > > >
> > > > I'd like to start a vote on KIP-621 which is about deprecating methods
> > in
> > > > DescribeLogDirsResult which leak internal classes, replacing them with
> > > > public API classes.
> > > >
> > > >
> > >
> > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158862109
> > > >
> > > > Thanks,
> > > >
> > > > Tom
> > > >
> > >
> >
Re: [VOTE] KIP-621: Deprecate and replace DescribeLogDirsResult.all()
and .values()
Posted by David Jacot <dj...@confluent.io>.
I couldn't think of a better alternative either. Thanks for the KIP!
+1 (non-binding)
On Wed, Jul 8, 2020 at 12:42 PM Manikumar <ma...@gmail.com> wrote:
> +1 (binding)
>
> Thanks for the KIP.
>
> On Tue, Jul 7, 2020 at 8:19 PM Colin McCabe <cm...@apache.org> wrote:
>
> > Thanks, Tom.
> >
> > I tried to think of a better way to do this, but I think you're right
> that
> > we probably just need different methods.
> >
> > +1 (binding).
> >
> > best,
> > Colin
> >
> > On Mon, Jul 6, 2020, at 01:14, Tom Bentley wrote:
> > > Hi,
> > >
> > > I'd like to start a vote on KIP-621 which is about deprecating methods
> in
> > > DescribeLogDirsResult which leak internal classes, replacing them with
> > > public API classes.
> > >
> > >
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158862109
> > >
> > > Thanks,
> > >
> > > Tom
> > >
> >
>
Re: [VOTE] KIP-621: Deprecate and replace DescribeLogDirsResult.all()
and .values()
Posted by Manikumar <ma...@gmail.com>.
+1 (binding)
Thanks for the KIP.
On Tue, Jul 7, 2020 at 8:19 PM Colin McCabe <cm...@apache.org> wrote:
> Thanks, Tom.
>
> I tried to think of a better way to do this, but I think you're right that
> we probably just need different methods.
>
> +1 (binding).
>
> best,
> Colin
>
> On Mon, Jul 6, 2020, at 01:14, Tom Bentley wrote:
> > Hi,
> >
> > I'd like to start a vote on KIP-621 which is about deprecating methods in
> > DescribeLogDirsResult which leak internal classes, replacing them with
> > public API classes.
> >
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158862109
> >
> > Thanks,
> >
> > Tom
> >
>
Re: [VOTE] KIP-621: Deprecate and replace DescribeLogDirsResult.all() and .values()
Posted by Colin McCabe <cm...@apache.org>.
Thanks, Tom.
I tried to think of a better way to do this, but I think you're right that we probably just need different methods.
+1 (binding).
best,
Colin
On Mon, Jul 6, 2020, at 01:14, Tom Bentley wrote:
> Hi,
>
> I'd like to start a vote on KIP-621 which is about deprecating methods in
> DescribeLogDirsResult which leak internal classes, replacing them with
> public API classes.
>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158862109
>
> Thanks,
>
> Tom
>