You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2018/09/06 00:44:57 UTC

[GitHub] zeppelin pull request #3170: ZEPPELIN-3689. Shade all dependencies of zeppel...

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/3170

    ZEPPELIN-3689. Shade all dependencies of zeppelin-interpreter

    ### What is this PR for?
    This PR will shade all dependencies of zeppelin-interpreter, this is just to avoid the conflict with the custom interpreter implementation which may use jars that conflicts with dependency of zeppelin-interpreter.
    
    
    ### What type of PR is it?
    [ Improvement]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3689
    
    ### How should this be tested?
    * CI pass
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3689

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3170.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3170
    
----
commit 43b8f31436cbe44d7286277ac9ed490265120832
Author: Jeff Zhang <zj...@...>
Date:   2018-09-03T08:12:52Z

    ZEPPELIN-3689. Shade all dependencies of zeppelin-interpreter

----


---

[GitHub] zeppelin issue #3170: ZEPPELIN-3689. Shade all dependencies of zeppelin-inte...

Posted by liuxunorg <gi...@git.apache.org>.

Github user liuxunorg commented on the issue:

    https://github.com/apache/zeppelin/pull/3170
  
    Thanks @zjffdu , This design perfectly solves the problem of dependency package conflicts.
    If I need to add a dependency package to zeppelin-interpreter, Is the dependency package added in the zeppelin-interpreter/pom.xml, and then excluded in the zeppelin-interpreter-api/pom.xml, right?


---

[GitHub] zeppelin pull request #3170: ZEPPELIN-3689. Shade all dependencies of zeppel...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/3170


---

[GitHub] zeppelin issue #3170: ZEPPELIN-3689. Shade all dependencies of zeppelin-inte...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/3170
  
    That's correct @liuxunorg 


---