You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/09 00:15:38 UTC

[GitHub] [beam] pcoet commented on a change in pull request #15653: [BEAM-12644] Javascript files moved to assets

pcoet commented on a change in pull request #15653:
URL: https://github.com/apache/beam/pull/15653#discussion_r725400290



##########
File path: website/www/site/layouts/commercial/list.html
##########
@@ -76,7 +76,8 @@ <h5 class="use-title">{{ .Title }}</h5>
     </div>
 
 </div>
-<script src='{{ "js/categories-filter.js" | relURL }}'></script>
+{{ $categoriesFilter := resources.Get "js/categories-filter.js" | minify| fingerprint }}

Review comment:
       I thought you had to invoke `minify` and `fingerprint` on the `resources` object, like: `resources.Minify`. But as long as this works too...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org