[ https://issues.apache.org/jira/browse/OPENNLP-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011022#comment-16011022 ]
ASF GitHub Bot commented on OPENNLP-1057:
-----------------------------------------
GitHub user thygesen opened a pull request:
https://github.com/apache/opennlp/pull/200
OPENNLP-1057: Add all Eval tests to the Eval profile
Enabled all Eval tests
-------
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [√ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [√ ] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [√ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- √[ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [√ ] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
- [n/a ] Have you written or updated unit tests to verify your changes?
- [ n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [n/a ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
- [n/a ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
### For documentation related changes:
- [n/a ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thygesen/opennlp opennlp-1057
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/opennlp/pull/200.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #200
----
commit 940f8bc4a267ea24e7e235da2a32896c5271d132
Author: thygesen <th...@apache.org>
Date: 2017-05-15T18:07:14Z
OPENNLP-1057: Add all Eval tests to the Eval profile
----
> Add all Eval tests to the Eval profile
> ---------------------------------------
>
> Key: OPENNLP-1057
> URL: https://issues.apache.org/jira/browse/OPENNLP-1057
> Project: OpenNLP
> Issue Type: Bug
> Components: Build, Packaging and Test
> Reporter: Peter Thygesen
> Assignee: Peter Thygesen
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Running the Eval profile (-D OPENNLP_DATA_DIR=path) only runs the normal tests and the SourceForgeEval. Change the include pattern to include all Eval test.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)