You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/14 00:12:07 UTC
[GitHub] [incubator-mxnet] apeforest opened a new pull request #17294: fix
build from source instruction
apeforest opened a new pull request #17294: fix build from source instruction
URL: https://github.com/apache/incubator-mxnet/pull/17294
## Description ##
Need to add a blank line before bash section, otherwise the html page is not rendered properly
https://mxnet.apache.org/get_started/ubuntu_setup.html
- break long lines
- remove unnecesarry tab space
- remove $ to make it consistent
@leezu @aaronmarkham please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request
#17294: fix build from source instruction
Posted by GitBox <gi...@apache.org>.
apeforest commented on a change in pull request #17294: fix build from source instruction
URL: https://github.com/apache/incubator-mxnet/pull/17294#discussion_r366157949
##########
File path: docs/static_site/src/pages/get_started/ubuntu_setup.md
##########
@@ -63,11 +63,11 @@ Then download [cuDNN 7.1.4](https://developer.nvidia.com/cudnn).
Unzip the file and change to the cuDNN root directory. Move the header and libraries to your local CUDA Toolkit folder:
```bash
- tar xvzf cudnn-9.2-linux-x64-v7.1
- sudo cp -P cuda/include/cudnn.h /usr/local/cuda/include
Review comment:
This PR only changes formatting and spacing. For content change, please create a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu merged pull request #17294: fix build from
source instruction
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #17294: fix build from source instruction
URL: https://github.com/apache/incubator-mxnet/pull/17294
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on issue #17294: fix build
from source instruction
Posted by GitBox <gi...@apache.org>.
apeforest commented on issue #17294: fix build from source instruction
URL: https://github.com/apache/incubator-mxnet/pull/17294#issuecomment-574008165
> Why do we have 2 build from source pages, this is all extremely confusing.
>
> https://mxnet.apache.org/get_started/ubuntu_setup.html
> https://mxnet.apache.org/get_started/build_from_source
This is out of scope of this PR. Please raise this in a seprate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] larroy commented on a change in pull request
#17294: fix build from source instruction
Posted by GitBox <gi...@apache.org>.
larroy commented on a change in pull request #17294: fix build from source instruction
URL: https://github.com/apache/incubator-mxnet/pull/17294#discussion_r366108454
##########
File path: docs/static_site/src/pages/get_started/ubuntu_setup.md
##########
@@ -63,11 +63,11 @@ Then download [cuDNN 7.1.4](https://developer.nvidia.com/cudnn).
Unzip the file and change to the cuDNN root directory. Move the header and libraries to your local CUDA Toolkit folder:
```bash
- tar xvzf cudnn-9.2-linux-x64-v7.1
Review comment:
Why are we recommending cuda 9.2 in the install instructions? Most are using 10.1 and 10.2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request
#17294: fix build from source instruction
Posted by GitBox <gi...@apache.org>.
apeforest commented on a change in pull request #17294: fix build from source instruction
URL: https://github.com/apache/incubator-mxnet/pull/17294#discussion_r366157969
##########
File path: docs/static_site/src/pages/get_started/ubuntu_setup.md
##########
@@ -63,11 +63,11 @@ Then download [cuDNN 7.1.4](https://developer.nvidia.com/cudnn).
Unzip the file and change to the cuDNN root directory. Move the header and libraries to your local CUDA Toolkit folder:
```bash
- tar xvzf cudnn-9.2-linux-x64-v7.1
Review comment:
This PR only changes formatting and spacing. For content change, please create a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] larroy commented on issue #17294: fix build from
source instruction
Posted by GitBox <gi...@apache.org>.
larroy commented on issue #17294: fix build from source instruction
URL: https://github.com/apache/incubator-mxnet/pull/17294#issuecomment-573949265
Why do we have 2 build from source pages, this is all extremely confusing.
https://mxnet.apache.org/get_started/ubuntu_setup.html
https://mxnet.apache.org/get_started/build_from_source
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17294: fix build from
source instruction
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17294: fix build from source instruction
URL: https://github.com/apache/incubator-mxnet/pull/17294#issuecomment-574216920
@larroy One page contains Ubuntu specific instructions, the other page contains generic instructions.
I think that's reasonable in principle, but the current instructions have a lot of room for simplification and improvement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] larroy commented on a change in pull request
#17294: fix build from source instruction
Posted by GitBox <gi...@apache.org>.
larroy commented on a change in pull request #17294: fix build from source instruction
URL: https://github.com/apache/incubator-mxnet/pull/17294#discussion_r366109119
##########
File path: docs/static_site/src/pages/get_started/ubuntu_setup.md
##########
@@ -63,11 +63,11 @@ Then download [cuDNN 7.1.4](https://developer.nvidia.com/cudnn).
Unzip the file and change to the cuDNN root directory. Move the header and libraries to your local CUDA Toolkit folder:
```bash
- tar xvzf cudnn-9.2-linux-x64-v7.1
- sudo cp -P cuda/include/cudnn.h /usr/local/cuda/include
Review comment:
this shouldn't be necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services