[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #751: [#750]feat: add RssFetchFailedException

["advancedxy (via GitHub)" <gi...@apache.org>]

advancedxy commented on code in PR #751:
URL: https://github.com/apache/incubator-uniffle/pull/751#discussion_r1143424814


##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java:
##########
@@ -584,7 +585,7 @@ public Roaring64NavigableMap getShuffleResult(String clientType, Set<ShuffleServ
       }
     }
     if (!isSuccessful) {
-      throw new RssException("Get shuffle result is failed for appId["
+      throw new RssFetchFailedException("Get shuffle result is failed for appId["

Review Comment:
   This seems wrong.. This method should belong to ShuffleReadClient. But it's out of this PR's scope.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org