[GitHub] [spark] mridulm commented on a diff in pull request #37471: [SPARK-40036][CORE] Ensure `LevelDB/RocksDBIterator` can't iterate after `db/iterator` closing

[GitBox <gi...@apache.org>]

mridulm commented on code in PR #37471:
URL: https://github.com/apache/spark/pull/37471#discussion_r942808271


##########
common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDBIterator.java:
##########
@@ -189,6 +189,7 @@ public synchronized void close() throws IOException {
     if (!closed) {
       it.close();
       closed = true;
+      next = null;

Review Comment:
   Do we want to add a `!closed` check to `skip` as well ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org