You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/15 12:54:44 UTC

[GitHub] [flink] wuchong opened a new pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

wuchong opened a new pull request #12657:
URL: https://github.com/apache/flink/pull/12657


   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   The existing `SQLClientKafkaITCase` uses YAML to register old connectors which can't cover new connector and format implementations. However, we got many reported bugs related to classloading, class shading about the new connectors.
   
   This PR migrate this e2e test to execute a SQL file by passing the lines to SQL CLI terminal by using {{java.lang.Process#getOutputStream}}. Thus we slightly update `AutoClosableProcess` to support setting the standard inputs.
   
   This also disovers 2 bug/improvement (FLINK-18302, FLINK-18303) when we migrate to DDL and fixed together in this PR.
   
   ## Brief change log
   
   - Support to set standard inputs for AutoClosableProcess
   - Migrate SQLClientKafkaITCase to use DDL and new options to create tables
   - Fix SQL client uses wrong class loader when execute INSERT statements
   - Fix Filesystem connector doesn't flush part files after rolling interval
   
   ## Verifying this change
   
   This change is covered by existing e2e tests.
   ## Brief change log
   
   The commit messages describe the changes.
   
   ## Verifying this change
   
   This change added a test which transforms a nested data type.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644140243


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515",
       "triggerID" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "triggerType" : "PUSH"
     }, {
       "hash" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3558",
       "triggerID" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3569",
       "triggerID" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "triggerType" : "PUSH"
     }, {
       "hash" : "475eb448054654a9d4cfd0e3e8b32f9f12cdec83",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3592",
       "triggerID" : "475eb448054654a9d4cfd0e3e8b32f9f12cdec83",
       "triggerType" : "PUSH"
     }, {
       "hash" : "957ed3e9d9c1d0b48d11f6573dc3a0d85de01fd9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3642",
       "triggerID" : "957ed3e9d9c1d0b48d11f6573dc3a0d85de01fd9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 475eb448054654a9d4cfd0e3e8b32f9f12cdec83 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3592) 
   * 957ed3e9d9c1d0b48d11f6573dc3a0d85de01fd9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3642) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] JingsongLi commented on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644522570


   50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a Looks good to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on a change in pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12657:
URL: https://github.com/apache/flink/pull/12657#discussion_r440643763



##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/AutoClosableProcess.java
##########
@@ -167,6 +186,18 @@ private static void processStream(final InputStream stream, final Consumer<Strin
 		).start();
 	}
 
+	private static void processOutputStream(final OutputStream stream, final List<String> inputs) {
+		new Thread(() -> {

Review comment:
       This keeps align with `processInputStream`, we shouldn't block here, because the blocking/non-blocking is determined by user `AutoClosableProcessBuilder#runNonBlocking` or `AutoClosableProcessBuilder#runBlocking()`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644140243


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515",
       "triggerID" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 14cdb5d641588f9dfa7f8536fe92e3e57abd8e14 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644140243


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515",
       "triggerID" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "triggerType" : "PUSH"
     }, {
       "hash" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3558",
       "triggerID" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 14cdb5d641588f9dfa7f8536fe92e3e57abd8e14 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515) 
   * 50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3558) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-645103026


   Build is passed. Merging... 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong closed pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
wuchong closed pull request #12657:
URL: https://github.com/apache/flink/pull/12657


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644140243


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515",
       "triggerID" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "triggerType" : "PUSH"
     }, {
       "hash" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3558",
       "triggerID" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3569",
       "triggerID" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "triggerType" : "PUSH"
     }, {
       "hash" : "475eb448054654a9d4cfd0e3e8b32f9f12cdec83",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "475eb448054654a9d4cfd0e3e8b32f9f12cdec83",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3558) 
   * 5338beac68736a1dc6518ef5972aa110b5bffe24 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3569) 
   * 475eb448054654a9d4cfd0e3e8b32f9f12cdec83 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644140243


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515",
       "triggerID" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "triggerType" : "PUSH"
     }, {
       "hash" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3558",
       "triggerID" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 14cdb5d641588f9dfa7f8536fe92e3e57abd8e14 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515) 
   * 50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3558) 
   * 5338beac68736a1dc6518ef5972aa110b5bffe24 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644140243


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 14cdb5d641588f9dfa7f8536fe92e3e57abd8e14 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644140243


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515",
       "triggerID" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "triggerType" : "PUSH"
     }, {
       "hash" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3558",
       "triggerID" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3569",
       "triggerID" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "triggerType" : "PUSH"
     }, {
       "hash" : "475eb448054654a9d4cfd0e3e8b32f9f12cdec83",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3592",
       "triggerID" : "475eb448054654a9d4cfd0e3e8b32f9f12cdec83",
       "triggerType" : "PUSH"
     }, {
       "hash" : "957ed3e9d9c1d0b48d11f6573dc3a0d85de01fd9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3642",
       "triggerID" : "957ed3e9d9c1d0b48d11f6573dc3a0d85de01fd9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e2db1dcc6a5a60210a4452849048b915cf794aaf",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3648",
       "triggerID" : "e2db1dcc6a5a60210a4452849048b915cf794aaf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e2db1dcc6a5a60210a4452849048b915cf794aaf Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3648) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on a change in pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12657:
URL: https://github.com/apache/flink/pull/12657#discussion_r440651382



##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/AutoClosableProcess.java
##########
@@ -167,6 +186,18 @@ private static void processStream(final InputStream stream, final Consumer<Strin
 		).start();
 	}
 
+	private static void processOutputStream(final OutputStream stream, final List<String> inputs) {
+		new Thread(() -> {

Review comment:
       Even if we don't start a thread here, it is still possible the process is finished when we want to print lines to the process. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] JingsongLi commented on a change in pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #12657:
URL: https://github.com/apache/flink/pull/12657#discussion_r440626499



##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/AutoClosableProcess.java
##########
@@ -167,6 +186,18 @@ private static void processStream(final InputStream stream, final Consumer<Strin
 		).start();
 	}
 
+	private static void processOutputStream(final OutputStream stream, final List<String> inputs) {

Review comment:
       inputs -> inputLines?

##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/AutoClosableProcess.java
##########
@@ -167,6 +186,18 @@ private static void processStream(final InputStream stream, final Consumer<Strin
 		).start();
 	}
 
+	private static void processOutputStream(final OutputStream stream, final List<String> inputs) {

Review comment:
       `processOutputStream(inputs)` looks confuse to me. Can we just name it `printLinesToProcess`?

##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SQLClientKafkaITCase.java
##########
@@ -179,80 +174,55 @@ public void testKafka() throws Exception {
 		}
 	}
 
-	private void insertIntoAvroTable(ClusterController clusterController) throws IOException {
-		LOG.info("Executing SQL: Kafka {} JSON -> Kafka {} Avro", kafkaSQLVersion, kafkaSQLVersion);
-		String sqlStatement1 = "INSERT INTO AvroBothTable\n" +
-				"  SELECT\n" +
-				"    CAST(TUMBLE_START(rowtime, INTERVAL '1' HOUR) AS VARCHAR) AS event_timestamp,\n" +
-				"    user,\n" +
-				"    RegReplace(event.message, ' is ', ' was ') AS message,\n" +
-				"    COUNT(*) AS duplicate_count\n" +
-				"  FROM JsonSourceTable\n" +
-				"  WHERE user IS NOT NULL\n" +
-				"  GROUP BY\n" +
-				"    user,\n" +
-				"    event.message,\n" +
-				"    TUMBLE(rowtime, INTERVAL '1' HOUR)";
-
-		clusterController.submitSQLJob(new SQLJobSubmission.SQLJobSubmissionBuilder(sqlStatement1)
-				.addJar(sqlAvroJar)
-				.addJars(apacheAvroJars)
-				.addJar(sqlJsonJar)
-				.addJar(sqlConnectorKafkaJar)
-				.addJar(sqlToolBoxJar)
-				.setSessionEnvFile(this.sqlClientSessionConf.toAbsolutePath().toString())
-				.build());
-	}
-
-	private void insertIntoCsvSinkTable(ClusterController clusterController) throws IOException {
-		LOG.info("Executing SQL: Kafka {} Avro -> Csv sink", kafkaSQLVersion);
-		String sqlStatement2 = "INSERT INTO CsvSinkTable\n" +
-				"   SELECT AvroBothTable.*, RegReplace('Test constant folding.', 'Test', 'Success') AS constant\n" +
-				"   FROM AvroBothTable";
-
-		clusterController.submitSQLJob(new SQLJobSubmission.SQLJobSubmissionBuilder(sqlStatement2)
-				.addJar(sqlAvroJar)
-				.addJars(apacheAvroJars)
-				.addJar(sqlJsonJar)
-				.addJar(sqlConnectorKafkaJar)
-				.addJar(sqlToolBoxJar)
-				.setSessionEnvFile(this.sqlClientSessionConf.toAbsolutePath().toString())
-				.build()
-		);
+	private void executeSqlStatements(ClusterController clusterController, List<String> sqlLines) throws IOException {
+		LOG.info("Executing Kafka {} end-to-end SQL statements.", kafkaSQLVersion);
+		clusterController.submitSQLJob(new SQLJobSubmission.SQLJobSubmissionBuilder(sqlLines)
+			.addJar(sqlAvroJar)
+			.addJars(apacheAvroJars)
+			.addJar(sqlConnectorKafkaJar)
+			.addJar(sqlToolBoxJar)
+			.build());
 	}
 
-	private String initializeSessionYaml(Map<String, String> vars) throws IOException {
-		URL url = SQLClientKafkaITCase.class.getClassLoader().getResource(KAFKA_JSON_SOURCE_SCHEMA_YAML);
+	private List<String> initializeSqlLines(Map<String, String> vars) throws IOException {
+		URL url = SQLClientKafkaITCase.class.getClassLoader().getResource(KAFKA_E2E_SQL);
 		if (url == null) {
-			throw new FileNotFoundException(KAFKA_JSON_SOURCE_SCHEMA_YAML);
+			throw new FileNotFoundException(KAFKA_E2E_SQL);
 		}
 
-		String schema = FileUtils.readFileUtf8(new File(url.getFile()));
-		for (Map.Entry<String, String> var : vars.entrySet()) {
-			schema = schema.replace(var.getKey(), var.getValue());
+		List<String> lines = Files.readAllLines(new File(url.getFile()).toPath());
+		List<String> result = new ArrayList<>();
+		for (String line : lines) {
+			for (Map.Entry<String, String> var : vars.entrySet()) {
+				line = line.replace(var.getKey(), var.getValue());
+			}
+			result.add(line);
 		}
-		return schema;
+
+		return result;
 	}
 
 	private void checkCsvResultFile() throws Exception {
 		boolean success = false;
 		final Deadline deadline = Deadline.fromNow(Duration.ofSeconds(120));
-		while (!success && deadline.hasTimeLeft()) {
+		while (deadline.hasTimeLeft()) {
 			if (Files.exists(result)) {
-				byte[] bytes = Files.readAllBytes(result);
-				String[] lines = new String(bytes, Charsets.UTF_8).split("\n");
-				if (lines.length == 4) {
+				List<String> lines = readCsvResultFiles(result);
+				if (lines.size() == 4) {
 					success = true;
 					assertThat(
-						lines,
+						lines.toArray(new String[0]),
 						arrayContainingInAnyOrder(
-							"2018-03-12 08:00:00.000,Alice,This was a warning.,2,Success constant folding.",
-							"2018-03-12 09:00:00.000,Bob,This was another warning.,1,Success constant folding.",
-							"2018-03-12 09:00:00.000,Steve,This was another info.,2,Success constant folding.",
-							"2018-03-12 09:00:00.000,Alice,This was a info.,1,Success constant folding."
+							"\"2018-03-12 08:00:00.000\",Alice,\"This was a warning.\",2,\"Success constant folding.\"",

Review comment:
       Add `disable-quote-character` to remove `"`?

##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/AutoClosableProcess.java
##########
@@ -89,6 +95,11 @@ public AutoClosableProcessBuilder setStderrProcessor(final Consumer<String> stde
 			return this;
 		}
 
+		public AutoClosableProcessBuilder setStdInputs(final List<String> inputLines) {

Review comment:
       inputLines can be `String...`

##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/AutoClosableProcess.java
##########
@@ -167,6 +186,18 @@ private static void processStream(final InputStream stream, final Consumer<Strin
 		).start();
 	}
 
+	private static void processOutputStream(final OutputStream stream, final List<String> inputs) {
+		new Thread(() -> {

Review comment:
       I don't think we need start a thread.
   The inputs are something like commands, should print them blocking.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644581162


   Thanks for the reviewing @godfreyhe , I have updated the PR and added tests for INSERT INTO statement classloading.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644140243


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515",
       "triggerID" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "triggerType" : "PUSH"
     }, {
       "hash" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3558",
       "triggerID" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3569",
       "triggerID" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "triggerType" : "PUSH"
     }, {
       "hash" : "475eb448054654a9d4cfd0e3e8b32f9f12cdec83",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3592",
       "triggerID" : "475eb448054654a9d4cfd0e3e8b32f9f12cdec83",
       "triggerType" : "PUSH"
     }, {
       "hash" : "957ed3e9d9c1d0b48d11f6573dc3a0d85de01fd9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "957ed3e9d9c1d0b48d11f6573dc3a0d85de01fd9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 475eb448054654a9d4cfd0e3e8b32f9f12cdec83 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3592) 
   * 957ed3e9d9c1d0b48d11f6573dc3a0d85de01fd9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644140243


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515",
       "triggerID" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "triggerType" : "PUSH"
     }, {
       "hash" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3558",
       "triggerID" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3569",
       "triggerID" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "triggerType" : "PUSH"
     }, {
       "hash" : "475eb448054654a9d4cfd0e3e8b32f9f12cdec83",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3592",
       "triggerID" : "475eb448054654a9d4cfd0e3e8b32f9f12cdec83",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5338beac68736a1dc6518ef5972aa110b5bffe24 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3569) 
   * 475eb448054654a9d4cfd0e3e8b32f9f12cdec83 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3592) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644140243


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515",
       "triggerID" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "triggerType" : "PUSH"
     }, {
       "hash" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3558",
       "triggerID" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3569",
       "triggerID" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "triggerType" : "PUSH"
     }, {
       "hash" : "475eb448054654a9d4cfd0e3e8b32f9f12cdec83",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3592",
       "triggerID" : "475eb448054654a9d4cfd0e3e8b32f9f12cdec83",
       "triggerType" : "PUSH"
     }, {
       "hash" : "957ed3e9d9c1d0b48d11f6573dc3a0d85de01fd9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3642",
       "triggerID" : "957ed3e9d9c1d0b48d11f6573dc3a0d85de01fd9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e2db1dcc6a5a60210a4452849048b915cf794aaf",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3648",
       "triggerID" : "e2db1dcc6a5a60210a4452849048b915cf794aaf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 475eb448054654a9d4cfd0e3e8b32f9f12cdec83 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3592) 
   * 957ed3e9d9c1d0b48d11f6573dc3a0d85de01fd9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3642) 
   * e2db1dcc6a5a60210a4452849048b915cf794aaf Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3648) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] JingsongLi commented on a change in pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #12657:
URL: https://github.com/apache/flink/pull/12657#discussion_r440646572



##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/AutoClosableProcess.java
##########
@@ -167,6 +186,18 @@ private static void processStream(final InputStream stream, final Consumer<Strin
 		).start();
 	}
 
+	private static void processOutputStream(final OutputStream stream, final List<String> inputs) {
+		new Thread(() -> {

Review comment:
       I don't think it should be same to `processInputStream`.
   For a process, maybe this thread not start, but process ended. I'd like to think of `Input lines` as commands.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] godfreyhe commented on a change in pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #12657:
URL: https://github.com/apache/flink/pull/12657#discussion_r440569344



##########
File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
##########
@@ -462,7 +462,7 @@ public ResolvedExpression parseSqlExpression(String sqlExpression, TableSchema i
 	@Override
 	public ResultDescriptor executeQuery(String sessionId, String query) throws SqlExecutionException {
 		final ExecutionContext<?> context = getExecutionContext(sessionId);
-		return executeQueryInternal(sessionId, context, query);
+		return context.wrapClassLoader(() -> executeQueryInternal(sessionId, context, query));

Review comment:
       most operations in `executeQueryInternal ` method and `executeUpdateInternal` method are already wrapped in user classloader, only `deployer.deploy()` is  needed. Otherwise, it's better we should remove those wrappers.  btw, add some tests in sql client to verify the fix ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on a change in pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12657:
URL: https://github.com/apache/flink/pull/12657#discussion_r440655924



##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/AutoClosableProcess.java
##########
@@ -167,6 +186,18 @@ private static void processStream(final InputStream stream, final Consumer<Strin
 		).start();
 	}
 
+	private static void processOutputStream(final OutputStream stream, final List<String> inputs) {

Review comment:
       I just want to keep align with the previous `processStream(InputStream ..., Consumer...)`. I think we should have a consistent naming for them. Howabout rename them to `consumeOutput(InputStream, Consumer)`, `produceInput(OutputStream, List<String>)`? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644140243


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515",
       "triggerID" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 14cdb5d641588f9dfa7f8536fe92e3e57abd8e14 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644140243


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515",
       "triggerID" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "triggerType" : "PUSH"
     }, {
       "hash" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3558",
       "triggerID" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3569",
       "triggerID" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "triggerType" : "PUSH"
     }, {
       "hash" : "475eb448054654a9d4cfd0e3e8b32f9f12cdec83",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3592",
       "triggerID" : "475eb448054654a9d4cfd0e3e8b32f9f12cdec83",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3558) 
   * 5338beac68736a1dc6518ef5972aa110b5bffe24 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3569) 
   * 475eb448054654a9d4cfd0e3e8b32f9f12cdec83 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3592) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644140243


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515",
       "triggerID" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "triggerType" : "PUSH"
     }, {
       "hash" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 14cdb5d641588f9dfa7f8536fe92e3e57abd8e14 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515) 
   * 50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644140243


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515",
       "triggerID" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "triggerType" : "PUSH"
     }, {
       "hash" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3558",
       "triggerID" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3569",
       "triggerID" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 14cdb5d641588f9dfa7f8536fe92e3e57abd8e14 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515) 
   * 50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3558) 
   * 5338beac68736a1dc6518ef5972aa110b5bffe24 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3569) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644118225


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 14cdb5d641588f9dfa7f8536fe92e3e57abd8e14 (Mon Jun 15 12:57:02 UTC 2020)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644140243


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515",
       "triggerID" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "triggerType" : "PUSH"
     }, {
       "hash" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3558",
       "triggerID" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3569",
       "triggerID" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "triggerType" : "PUSH"
     }, {
       "hash" : "475eb448054654a9d4cfd0e3e8b32f9f12cdec83",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3592",
       "triggerID" : "475eb448054654a9d4cfd0e3e8b32f9f12cdec83",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 475eb448054654a9d4cfd0e3e8b32f9f12cdec83 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3592) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644140243


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515",
       "triggerID" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "triggerType" : "PUSH"
     }, {
       "hash" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3558",
       "triggerID" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3569",
       "triggerID" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "triggerType" : "PUSH"
     }, {
       "hash" : "475eb448054654a9d4cfd0e3e8b32f9f12cdec83",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3592",
       "triggerID" : "475eb448054654a9d4cfd0e3e8b32f9f12cdec83",
       "triggerType" : "PUSH"
     }, {
       "hash" : "957ed3e9d9c1d0b48d11f6573dc3a0d85de01fd9",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3642",
       "triggerID" : "957ed3e9d9c1d0b48d11f6573dc3a0d85de01fd9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e2db1dcc6a5a60210a4452849048b915cf794aaf",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3648",
       "triggerID" : "e2db1dcc6a5a60210a4452849048b915cf794aaf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 957ed3e9d9c1d0b48d11f6573dc3a0d85de01fd9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3642) 
   * e2db1dcc6a5a60210a4452849048b915cf794aaf Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3648) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644117502


   Hi @zentol could you help to review the first commit? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644140243


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3515",
       "triggerID" : "14cdb5d641588f9dfa7f8536fe92e3e57abd8e14",
       "triggerType" : "PUSH"
     }, {
       "hash" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3558",
       "triggerID" : "50108ca39ff114f9c85ae5f2b5cc72eb3dd4357a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3569",
       "triggerID" : "5338beac68736a1dc6518ef5972aa110b5bffe24",
       "triggerType" : "PUSH"
     }, {
       "hash" : "475eb448054654a9d4cfd0e3e8b32f9f12cdec83",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3592",
       "triggerID" : "475eb448054654a9d4cfd0e3e8b32f9f12cdec83",
       "triggerType" : "PUSH"
     }, {
       "hash" : "957ed3e9d9c1d0b48d11f6573dc3a0d85de01fd9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3642",
       "triggerID" : "957ed3e9d9c1d0b48d11f6573dc3a0d85de01fd9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e2db1dcc6a5a60210a4452849048b915cf794aaf",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e2db1dcc6a5a60210a4452849048b915cf794aaf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 475eb448054654a9d4cfd0e3e8b32f9f12cdec83 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3592) 
   * 957ed3e9d9c1d0b48d11f6573dc3a0d85de01fd9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3642) 
   * e2db1dcc6a5a60210a4452849048b915cf794aaf UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] JingsongLi commented on a change in pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #12657:
URL: https://github.com/apache/flink/pull/12657#discussion_r440718820



##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/AutoClosableProcess.java
##########
@@ -167,6 +186,18 @@ private static void processStream(final InputStream stream, final Consumer<Strin
 		).start();
 	}
 
+	private static void processOutputStream(final OutputStream stream, final List<String> inputs) {
+		new Thread(() -> {
+			try (PrintStream printStream = new PrintStream(stream, true, StandardCharsets.UTF_8.name())) {

Review comment:
       Actually, try with resource will close this output put stream, and in this way, will close process.
   I think you should create a better method name for this, and add comments to explain.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] godfreyhe commented on pull request #12657: [FLINK-18086][tests][e2e][kafka] Migrate SQLClientKafkaITCase to use DDL and new options to create tables

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #12657:
URL: https://github.com/apache/flink/pull/12657#issuecomment-644628865


   for https://github.com/apache/flink/pull/12657/commits/5338beac68736a1dc6518ef5972aa110b5bffe24 LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org