You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/16 01:53:20 UTC
[GitHub] [arrow] mrkn opened a new pull request #7780: ARROW-9499: [C++] AdaptiveIntBuilder::null_count does not return the null count
mrkn opened a new pull request #7780:
URL: https://github.com/apache/arrow/pull/7780
I found that both `AdaptiveIntBuilder::AppendNull` and `AdaptiveUIntBuilder::AppendNull` did not increment its `null_count_`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7780: ARROW-9499: [C++] AdaptiveIntBuilder::AppendNull does not increment the null count
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7780:
URL: https://github.com/apache/arrow/pull/7780#issuecomment-659391073
Apologies. Perhaps we can open a JIRA to enhance test coverage around this issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #7780: ARROW-9499: [C++] AdaptiveIntBuilder::AppendNull does not increment the null count
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #7780:
URL: https://github.com/apache/arrow/pull/7780#issuecomment-659319039
I think this PR is wrong. The null count is incremented when the pending data is committed to the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #7780: ARROW-9499: [C++] AdaptiveIntBuilder::AppendNull does not increment the null count
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #7780:
URL: https://github.com/apache/arrow/pull/7780#issuecomment-659322407
Actually, we're lucky: the null count is overwritten by `UnsafeAppendToBitmap(const uint8_t* valid_bytes, int64_t length)`. Still, I think it was hasty to merge this PR during the 1.0 release window.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7780: ARROW-9499: [C++] AdaptiveIntBuilder::AppendNull does not increment the null count
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7780:
URL: https://github.com/apache/arrow/pull/7780#issuecomment-659114558
https://issues.apache.org/jira/browse/ARROW-9499
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm closed pull request #7780: ARROW-9499: [C++] AdaptiveIntBuilder::AppendNull does not increment the null count
Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7780:
URL: https://github.com/apache/arrow/pull/7780
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mrkn commented on pull request #7780: ARROW-9499: [C++] AdaptiveIntBuilder::AppendNull does not increment the null count
Posted by GitBox <gi...@apache.org>.
mrkn commented on pull request #7780:
URL: https://github.com/apache/arrow/pull/7780#issuecomment-659414501
Committing the pending data does not occur every time after calling `AppendNull` so `null_count` couldn't reflect the number of nulls in realtime without incrementing in `AppendNull`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org