You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/02/28 03:18:28 UTC

[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change in pull request #64: Update report process as a entity

wu-sheng commented on a change in pull request #64:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/64#discussion_r815555091



##########
File path: ebpf/profiling/Process.proto
##########
@@ -39,8 +39,8 @@ service EBPFProcessService {
 
 message EBPFProcessReportList {
     repeated EBPFProcessProperties processes = 1;
-    // Rover generate instance id in local, make sure it inconsistent every time when start
-    string roverInstanceId = 2;
+    // Report instance generate instance id in local, make sure it inconsistent every time when start

Review comment:
       ```suggestion
       // An ID generated by eBPF agent, should be unique globally.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org